All of lore.kernel.org
 help / color / mirror / Atom feed
From: sai.gowtham.ch@intel.com
To: igt-dev@lists.freedesktop.org, kamil.konieczny@linux.intel.com,
	sai.gowtham.ch@intel.com
Subject: [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case.
Date: Wed, 29 Jun 2022 12:11:27 +0530	[thread overview]
Message-ID: <20220629064128.9291-2-sai.gowtham.ch@intel.com> (raw)
In-Reply-To: <20220629064128.9291-1-sai.gowtham.ch@intel.com>

From: Sai Gowtham Ch <sai.gowtham.ch@intel.com>

Added test description for test and to all the subtests that are
available.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch@intel.com>
---
 tests/i915/gem_softpin.c | 40 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 38 insertions(+), 2 deletions(-)

diff --git a/tests/i915/gem_softpin.c b/tests/i915/gem_softpin.c
index b851c90e..153f5f6b 100644
--- a/tests/i915/gem_softpin.c
+++ b/tests/i915/gem_softpin.c
@@ -32,6 +32,10 @@
 #include "igt_rand.h"
 #include "intel_allocator.h"
 
+IGT_TEST_DESCRIPTION("Tests softpin feature with normal usage, invalid inputs"
+		     " scenarios and couple of eviction tests which copy buffers"
+		     " between CPU and GPU.");
+
 #define EXEC_OBJECT_PINNED	(1<<4)
 #define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
 
@@ -1248,6 +1252,7 @@ igt_main
 		ctx = intel_ctx_create_all_physical(fd);
 	}
 
+	igt_describe("Check that invalid inputs are handled correctly.");
 	igt_subtest("invalid")
 		test_invalid(fd);
 
@@ -1258,64 +1263,95 @@ igt_main
 			igt_require(gem_uses_full_ppgtt(fd));
 		}
 
+		igt_describe("Check full placement control under full-ppGTT.");
 		igt_subtest("zero")
 			test_zero(fd);
 
+		igt_describe("Check the last 32b page is excluded.");
 		igt_subtest("32b-excludes-last-page")
 			test_32b_last_page(fd);
 
+		igt_describe("Check the total occupancy by using pad-to-size to fill"
+			     " the entire GTT.");
 		igt_subtest("full")
 			test_full(fd);
 
+		igt_describe("Check that we can place objects at start/end of the GTT"
+			     " using the allocator.");
 		igt_subtest("allocator-basic")
 			test_allocator_basic(fd, false);
 
+		igt_describe("Check that if we can reserve a space for an object"
+			     " starting from a given offset.");
 		igt_subtest("allocator-basic-reserve")
 			test_allocator_basic(fd, true);
 
+		igt_describe("Check that we can combine manual placement with automatic"
+			     " GTT placement.");
 		igt_subtest("allocator-nopin")
 			test_allocator_nopin(fd, false);
 
+		igt_describe("Check that we can combine manual placement with automatic"
+			     " GTT placement and reserves/unreserves space for objects.");
 		igt_subtest("allocator-nopin-reserve")
 			test_allocator_nopin(fd, true);
 
+		igt_describe("Check if multiple processes can use alloctor.");
 		igt_subtest("allocator-fork")
 			test_allocator_fork(fd);
 
+		igt_describe("Exercise eviction with softpinning.");
 		test_each_engine("allocator-evict", fd, ctx, e)
 			test_allocator_evict(fd, ctx, e->flags, 20);
 
-		igt_describe("Use same offset for all engines and for different handles");
+		igt_describe("Use same offset for all engines and for different handles.");
 		igt_subtest("evict-single-offset")
 			evict_single_offset(fd, ctx, 20);
 	}
 
-	igt_describe("Check start offset and alignment detection");
+	igt_describe("Check start offset and alignment detection.");
 	igt_subtest("safe-alignment")
 		safe_alignment(fd);
 
+	igt_describe("Check softpinning of a gem buffer object.");
 	igt_subtest("softpin")
 		test_softpin(fd);
+
+	igt_describe("Check all the possible pages aligned overlaps.");
 	igt_subtest("overlap")
 		test_overlap(fd);
+
+	igt_describe("Check that if the user demands the vma will be swapped.");
 	igt_subtest("reverse")
 		test_reverse(fd);
 
+	igt_describe("Check that noreloc support works.");
 	igt_subtest("noreloc")
 		test_noreloc(fd, NOSLEEP, 0);
+
+	igt_describe("Check noreloc support with interruptible.");
 	igt_subtest("noreloc-interruptible")
 		test_noreloc(fd, NOSLEEP, INTERRUPTIBLE);
+
+	igt_describe("Check noreloc survives after suspend to RAM/resume cycle.");
 	igt_subtest("noreloc-S3")
 		test_noreloc(fd, SUSPEND, 0);
+
+	igt_describe("Check noreloc survives after suspend to disk/resume cycle.");
 	igt_subtest("noreloc-S4")
 		test_noreloc(fd, HIBERNATE, 0);
 
 	for (int signal = 0; signal <= 1; signal++) {
+		igt_describe_f("Check eviction with active bo %s.", signal ? "with interrupts" : "");
 		igt_subtest_f("evict-active%s", signal ? "-interruptible" : "")
 			test_evict_active(fd, signal);
+
+		igt_describe_f("Check eviction against snooping %s.", signal ? "with interrupts" : "");
 		igt_subtest_f("evict-snoop%s", signal ? "-interruptible" : "")
 			test_evict_snoop(fd, signal);
 	}
+
+	igt_describe("Check eviction of softpinned bo with hung batch.");
 	igt_subtest("evict-hang")
 		test_evict_hang(fd);
 
-- 
2.35.1

  reply	other threads:[~2022-06-29  6:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29  6:41 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-29  6:41 ` sai.gowtham.ch [this message]
2022-06-29  7:03   ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case Kamil Konieczny
2022-06-29  6:41 ` [igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run sai.gowtham.ch
2022-06-29  7:17 ` [igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_softpin. (rev3) Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2022-06-29  7:28 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-29  7:28 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-26 18:07 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-26 18:07 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-28 17:18   ` Kamil Konieczny
2022-06-20  7:03 [igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_softpin sai.gowtham.ch
2022-06-20  7:03 ` [igt-dev] [PATCH i-g-t 1/2] i915/gem_softpin: Added test description for test case sai.gowtham.ch
2022-06-22 16:14   ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629064128.9291-2-sai.gowtham.ch@intel.com \
    --to=sai.gowtham.ch@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.