From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C86D0CCA47C for ; Wed, 29 Jun 2022 08:08:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230349AbiF2IIA (ORCPT ); Wed, 29 Jun 2022 04:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231171AbiF2IH5 (ORCPT ); Wed, 29 Jun 2022 04:07:57 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 791C53BA5D; Wed, 29 Jun 2022 01:07:56 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id q18so13348717pld.13; Wed, 29 Jun 2022 01:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=26ZIBRUEZIPtCeugGBeQrsgT3aaPi/jFrSW3XtqmO4E=; b=LD2k1fnO3PEvw5iSj+odGBaj3uUJ/1bZXafHiHJr8dwAQMh7HAro80QefSH/JLvsY/ 9sVfjCsCTwTv1NgQt+NxnMlz9HWC6fsejYqt30mAbe9+ExgjCwO4Kmmak2r5UC6RsJCL 8KKLQeTQjogfO0ePGfWqS0wNbZHCQq3mmG1tZQTkntPEPx2ch1LPrxVCROG63Rv0w/Xf 56VD/0HfdhM9EPbPE2o0Qjsrjh4U6qLgIYafgkpLjc5IWUESAZS4q5EPhmJhUoR7Af1I 5UrMChIu5XMEHhzVLRVqnYjj24lrm6dtT1PU81wYmPPhJ09bYSI1o61PDN2VphUf/6lI EQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=26ZIBRUEZIPtCeugGBeQrsgT3aaPi/jFrSW3XtqmO4E=; b=NDG4hEKsFpIk6twQf8NdMRFiSfAFbQlqMq1bjIVflbuuVJcDZGzH6mhn5dSQfBu82g n3XTH91X2qX3D0KYda1UUDoRrakEWZX8on6RSVQszN9SgToZpvvjgMrqwwSRltPkA3qh Sy94EJ4WW03Ln9EoR4exiRxuLQs7Y6qXY0BVnjVrnDJ82PQxMDkRxxrFHHAg5/zq4eem cm44ldW1U8QiBfvDAb3k0KdHvf3yF9KECWoWFaS0Vlygufx0d3YAiTn98wMKU9Ck45RT BWhU44Guci3bdetfwHB31n74kCWWXX4uSEbI5Taojks1EAPo9lPiwBJGSgK50GDHKrJK YLvA== X-Gm-Message-State: AJIora/t4DTEghgjSji2n9eD/ylNuLPj/t0zphrzVzXSOpicGyW93+fL KF9pBOd//hiwHMn7y1PqUW0= X-Google-Smtp-Source: AGRyM1tilyHqgJTXrJU1LG7dIY6Y7oBwOtiPbyUrYr/8vnrGlc6jHnz2pPhlEKAouHlMINKMc7UTTw== X-Received: by 2002:a17:90b:4b8c:b0:1ec:c7b8:7cb9 with SMTP id lr12-20020a17090b4b8c00b001ecc7b87cb9mr4345566pjb.86.1656490075939; Wed, 29 Jun 2022 01:07:55 -0700 (PDT) Received: from sebin-inspiron.bbrouter ([103.160.233.84]) by smtp.gmail.com with ESMTPSA id kk2-20020a17090b4a0200b001cd4989febcsm1398292pjb.8.2022.06.29.01.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 01:07:55 -0700 (PDT) From: SebinSebastian Cc: mailmesebin00@gmail.com, skhan@linuxfoundation.org, Neal Liu , Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] usb: gadget: dereference before null check Date: Wed, 29 Jun 2022 13:37:25 +0530 Message-Id: <20220629080726.107297-1-mailmesebin00@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix coverity warning dereferencing before null check. _ep and desc is dereferenced on all paths until the check for null. Move the initializations after the check for null. Coverity issue: 1518209 Signed-off-by: SebinSebastian --- drivers/usb/gadget/udc/aspeed_udc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index d75a4e070bf7..96f8193fca15 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -341,10 +341,6 @@ static void ast_udc_stop_activity(struct ast_udc_dev *udc) static int ast_udc_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { - u16 maxpacket = usb_endpoint_maxp(desc); - struct ast_udc_ep *ep = to_ast_ep(_ep); - struct ast_udc_dev *udc = ep->udc; - u8 epnum = usb_endpoint_num(desc); unsigned long flags; u32 ep_conf = 0; u8 dir_in; @@ -356,6 +352,11 @@ static int ast_udc_ep_enable(struct usb_ep *_ep, return -EINVAL; } + u16 maxpacket = usb_endpoint_maxp(desc); + struct ast_udc_ep *ep = to_ast_ep(_ep); + struct ast_udc_dev *udc = ep->udc; + u8 epnum = usb_endpoint_num(desc); + if (!udc->driver) { EP_DBG(ep, "bogus device state\n"); return -ESHUTDOWN; -- 2.34.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03F5EC43334 for ; Wed, 29 Jun 2022 08:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=ZUEBwRTlW72GGMZxSlres7ypPfEB1mG/FmCjpt1O9k0=; b=Wnz7CurWnJbW6a 4V4Rn0vD6cZnKKuINdTXMD8TlIQs7UeqvuIM0kVbJnJfuuUW8KueIU2M4hku2cwhz0ijLVHJ3BpDb jQrNHW/HOOyKXomOtE3p2YcVt1FBhod+BM2qEsMSXr4l/JHZRghuNybw/6AiWXp+1Pyo5NYwVvzLZ HdiDu9cv3vzSDm1+QYWnfsEls6Z0AmMLquJAGCPSOsiDE+ZMb+dr3qrKyHE8RbSEq/kTO/p4SNVsW +CL04dyp4N8O5cSI7hs9gMjPgevposYaDFxg980kpIMMlgUE+tq2a/A+cVhKmpd6+SxKpsocm2otx B+nzlekvWYblN70xMbRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Sk0-00AIl7-Jx; Wed, 29 Jun 2022 08:08:04 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6Sjw-00AIhJ-Ln for linux-arm-kernel@lists.infradead.org; Wed, 29 Jun 2022 08:08:02 +0000 Received: by mail-pl1-x62b.google.com with SMTP id x20so7775418plx.6 for ; Wed, 29 Jun 2022 01:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=26ZIBRUEZIPtCeugGBeQrsgT3aaPi/jFrSW3XtqmO4E=; b=LD2k1fnO3PEvw5iSj+odGBaj3uUJ/1bZXafHiHJr8dwAQMh7HAro80QefSH/JLvsY/ 9sVfjCsCTwTv1NgQt+NxnMlz9HWC6fsejYqt30mAbe9+ExgjCwO4Kmmak2r5UC6RsJCL 8KKLQeTQjogfO0ePGfWqS0wNbZHCQq3mmG1tZQTkntPEPx2ch1LPrxVCROG63Rv0w/Xf 56VD/0HfdhM9EPbPE2o0Qjsrjh4U6qLgIYafgkpLjc5IWUESAZS4q5EPhmJhUoR7Af1I 5UrMChIu5XMEHhzVLRVqnYjj24lrm6dtT1PU81wYmPPhJ09bYSI1o61PDN2VphUf/6lI EQWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=26ZIBRUEZIPtCeugGBeQrsgT3aaPi/jFrSW3XtqmO4E=; b=Ip0A8eVEgakZJ7vxIYY+VJRUXeE9wFpe72ojbmuCbHtN43EmUrtGqXzPZGIyJtOvxQ NUM2/N5KZNj1FHhRv8GSISNR2RG2GAXHUp091iSvHgUtFzvNb1uwSrq4yeujwuj8LbUX QA8OuPi5qbgrzmFJG2BV12gtK2uaJercxZD07Z1PXOlO20MBOoNnPPdeKfUPTLTxvJK5 bG9X8aumkL2u1tyEWkhmhkgDZQn2r6udvj91dBeeFIDXtM9qlG43MPjfbw/EUD/uWbLG cuF33mc+yMDUK29hoewQ4iCHm/+z9zzoPzu/ZfI7DMY8m5hZWHLDaok1GH4xm4ToXyfk YwcQ== X-Gm-Message-State: AJIora89oChTosT2br6mONkBymsM3y8qOgyIF+pLf8PNkqF3w/RjCi4t EazxEo3ig4C5NLf406CwACY= X-Google-Smtp-Source: AGRyM1tilyHqgJTXrJU1LG7dIY6Y7oBwOtiPbyUrYr/8vnrGlc6jHnz2pPhlEKAouHlMINKMc7UTTw== X-Received: by 2002:a17:90b:4b8c:b0:1ec:c7b8:7cb9 with SMTP id lr12-20020a17090b4b8c00b001ecc7b87cb9mr4345566pjb.86.1656490075939; Wed, 29 Jun 2022 01:07:55 -0700 (PDT) Received: from sebin-inspiron.bbrouter ([103.160.233.84]) by smtp.gmail.com with ESMTPSA id kk2-20020a17090b4a0200b001cd4989febcsm1398292pjb.8.2022.06.29.01.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 01:07:55 -0700 (PDT) From: SebinSebastian To: Cc: mailmesebin00@gmail.com, skhan@linuxfoundation.org, Neal Liu , Felipe Balbi , Greg Kroah-Hartman , Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] usb: gadget: dereference before null check Date: Wed, 29 Jun 2022 13:37:25 +0530 Message-Id: <20220629080726.107297-1-mailmesebin00@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_010800_732385_6D1BF751 X-CRM114-Status: GOOD ( 11.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fix coverity warning dereferencing before null check. _ep and desc is dereferenced on all paths until the check for null. Move the initializations after the check for null. Coverity issue: 1518209 Signed-off-by: SebinSebastian --- drivers/usb/gadget/udc/aspeed_udc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/aspeed_udc.c b/drivers/usb/gadget/udc/aspeed_udc.c index d75a4e070bf7..96f8193fca15 100644 --- a/drivers/usb/gadget/udc/aspeed_udc.c +++ b/drivers/usb/gadget/udc/aspeed_udc.c @@ -341,10 +341,6 @@ static void ast_udc_stop_activity(struct ast_udc_dev *udc) static int ast_udc_ep_enable(struct usb_ep *_ep, const struct usb_endpoint_descriptor *desc) { - u16 maxpacket = usb_endpoint_maxp(desc); - struct ast_udc_ep *ep = to_ast_ep(_ep); - struct ast_udc_dev *udc = ep->udc; - u8 epnum = usb_endpoint_num(desc); unsigned long flags; u32 ep_conf = 0; u8 dir_in; @@ -356,6 +352,11 @@ static int ast_udc_ep_enable(struct usb_ep *_ep, return -EINVAL; } + u16 maxpacket = usb_endpoint_maxp(desc); + struct ast_udc_ep *ep = to_ast_ep(_ep); + struct ast_udc_dev *udc = ep->udc; + u8 epnum = usb_endpoint_num(desc); + if (!udc->driver) { EP_DBG(ep, "bogus device state\n"); return -ESHUTDOWN; -- 2.34.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel