Hi,

On Wed, Jun 29, 2022 at 02:05:43AM -0700, Stephen Boyd wrote:
> > diff --git a/include/linux/clk.h b/include/linux/clk.h
> > index 1507d5147898..39710b8453fa 100644
> > --- a/include/linux/clk.h
> > +++ b/include/linux/clk.h
> > @@ -755,8 +755,9 @@ int clk_set_parent(struct clk *clk, struct clk *parent);
> >   * clk_get_parent - get the parent clock source for this clock
> >   * @clk: clock source
> >   *
> > - * Returns struct clk corresponding to parent clock source, or
> > - * valid IS_ERR() condition containing errno.
> > + * Returns struct clk corresponding to parent clock source, a NULL
> > + * pointer if it doesn't have a parent, or a valid IS_ERR() condition
> > + * containing errno.
> 
> I'd rather not update this. A return value of NULL is a 'struct clk
> corresponding to parent clock source' already, and we don't want to
> document CCF implementation details in clk.h because there are other
> implementations of the API.

I find it slightly misleading still since using IS_ERR still doesn't get
you a safe pointer you can use.

I'll drop it though if you feel like it's too troublesome

Maxime