All of lore.kernel.org
 help / color / mirror / Atom feed
From: "José Roberto de Souza" <jose.souza@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display
Date: Wed, 29 Jun 2022 06:47:21 -0700	[thread overview]
Message-ID: <20220629134721.48375-1-jose.souza@intel.com> (raw)

Display is turned off by i915_drm_suspend() during the suspend
procedure, removing the last reference of some gem objects that were
used by display.

The issue is that those objects are only actually freed when
mm.free_work executed and that can happen very late in the suspend
process causing issues.
So here draining all freed objects released by display fixing suspend
issues.

Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
 drivers/gpu/drm/i915/i915_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
index 6e5849c1086f6..aa2a5ea30c7bb 100644
--- a/drivers/gpu/drm/i915/i915_driver.c
+++ b/drivers/gpu/drm/i915/i915_driver.c
@@ -1186,6 +1186,8 @@ static int i915_drm_suspend(struct drm_device *dev)
 
 	enable_rpm_wakeref_asserts(&dev_priv->runtime_pm);
 
+	i915_gem_drain_freed_objects(dev_priv);
+
 	return 0;
 }
 
-- 
2.37.0


             reply	other threads:[~2022-06-29 13:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 13:47 José Roberto de Souza [this message]
2022-06-29 14:30 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Drain freed object after suspend display Patchwork
2022-06-29 16:01 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Drain freed object after suspend display (rev2) Patchwork
2022-06-29 17:33 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drain freed object after suspend display (rev3) Patchwork
2022-06-29 22:11 ` [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display Matt Atwood
2022-06-30  7:48 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Drain freed object after suspend display (rev3) Patchwork
2022-06-30 14:26 ` [Intel-gfx] [PATCH] drm/i915: Drain freed object after suspend display Andrzej Hajda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629134721.48375-1-jose.souza@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.