From: Davidlohr Bueso <dave@stgolabs.net>
To: syzbot+ce3408364c4a234dd90c@syzkaller.appspotmail.com
Cc: aldas60@gmail.com, gregkh@linuxfoundation.org,
keescook@chromium.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev, linux-usb@vger.kernel.org,
nathan@kernel.org, syzkaller-bugs@googlegroups.com,
Davidlohr Bueso <dave@stgolabs.net>
Subject: [PATCH] staging/wlan-ng: get the correct struct hfa384x in work callback
Date: Wed, 29 Jun 2022 09:52:25 -0700 [thread overview]
Message-ID: <20220629165225.3436822-1-dave@stgolabs.net> (raw)
In-Reply-To: <000000000000e3fc8905e2608d4f@google.com>
hfa384x_usbctlx_completion_task() is bogusly using the reaper BH when
in fact this is the completion_bh. This was reflected when trying
to acquire the hw->ctlxq.lock and getting a failed lockdep class
initialized to it.
Reported-by: syzbot+ce3408364c4a234dd90c@syzkaller.appspotmail.com
Fixes: 9442e81d7e7 (staging/wlan-ng, prism2usb: replace completion_bh tasklet with work)
Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index 33844526c797..02fdef7a16c8 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -2632,7 +2632,7 @@ static void hfa384x_usbctlx_reaper_task(struct work_struct *work)
*/
static void hfa384x_usbctlx_completion_task(struct work_struct *work)
{
- struct hfa384x *hw = container_of(work, struct hfa384x, reaper_bh);
+ struct hfa384x *hw = container_of(work, struct hfa384x, completion_bh);
struct hfa384x_usbctlx *ctlx, *temp;
unsigned long flags;
--
2.36.1
prev parent reply other threads:[~2022-06-29 23:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-26 21:33 [syzbot] WARNING: locking bug in hfa384x_usbctlx_completion_task syzbot
[not found] ` <20220627105336.990-1-hdanton@sina.com>
2022-06-27 11:12 ` syzbot
2022-06-27 11:24 ` Dan Carpenter
2022-06-27 17:08 ` Davidlohr Bueso
2022-06-29 9:06 ` Greg KH
2022-06-29 16:52 ` Davidlohr Bueso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629165225.3436822-1-dave@stgolabs.net \
--to=dave@stgolabs.net \
--cc=aldas60@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=syzbot+ce3408364c4a234dd90c@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.