From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3C7C433EF for ; Wed, 29 Jun 2022 17:54:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231550AbiF2Ryu (ORCPT ); Wed, 29 Jun 2022 13:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbiF2Ryt (ORCPT ); Wed, 29 Jun 2022 13:54:49 -0400 Received: from mail-qk1-x72a.google.com (mail-qk1-x72a.google.com [IPv6:2607:f8b0:4864:20::72a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77BDE2180D for ; Wed, 29 Jun 2022 10:54:48 -0700 (PDT) Received: by mail-qk1-x72a.google.com with SMTP id k10so12585014qke.9 for ; Wed, 29 Jun 2022 10:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1fsl8to06dogIPqUQjmSvbiVa6q0GzvolownxJAZN2o=; b=jmFVNkgq0O81qfLOajkc6SLpytRvNa3u/VcTc09RKl+SDNfWua4GjSHs5vRkwJQPps EtfEqGSzxQ1iGfThunfK1OHQu+iP+4vD+sTQBecS1fM6IXFQZRE43q8kk5/puKiCgSn9 wA5ES2MLczklmjIYC/LaM8+piOb33PKGUQ1GkfRI0Hwav1pC7EFr45grNIRiane9T/UM 5HwIj6ks3hoFw/sU0v7VuIJsq9s7ODXli3cWoHVnjP1hGkvWX1ZpBlmkfpiMLeZKxuHc PFIPjc51fUIe9IJ5atTBsELiYbQdPh56dy8GjXz0k1Izasu8A0wBwcmdCQunv9hT2mtg Ckwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1fsl8to06dogIPqUQjmSvbiVa6q0GzvolownxJAZN2o=; b=VApxpI4DAVOKGicFkwkjmecZPjsRgzKGVcEFnGC/xfuMcNBc0BZSt4W3Ed/rJ+qWMi tuxnrwF6iqDC/ErWyAp3Q+G5n4GtjJtUU7a68c6qHiUQythD5Nkyx4rh7mjTU1n6fdfB wd5sIbX8mCs19pfRCtrKIOmTJuJkS8JfNhTY0kAqaYZhxUURT/N8kJi74WGNJn9xUOrH 6hWuyblAAc88mH25oLS2kkjRf+kfGtupPI8JCYIWNpbBiQqE265LQ2I0xI8jTOo2YYCI A1vG5dMZraSncGRN4jyGCWzQ7LZhuT69GKLVasC0IloodgrZHg1VC6lRK3OH4s73sK3q nIoQ== X-Gm-Message-State: AJIora/98R38kzuw9lTJEoaiR+2W334KXu8AuEpjgm3D5NonSP93G9Aj y/dkgx/zW392sVCR1NQXmjoy/w== X-Google-Smtp-Source: AGRyM1s3giy4qA8reYkPdnnUv03x6Kvxir+MsCRluYDAZYS7sfECqklFOO+ac87j7/NQTnAgVwjSkQ== X-Received: by 2002:a05:620a:4451:b0:6ae:fd29:149d with SMTP id w17-20020a05620a445100b006aefd29149dmr3115223qkp.724.1656525287652; Wed, 29 Jun 2022 10:54:47 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id u16-20020a05620a431000b006a7284e5741sm13625849qko.54.2022.06.29.10.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jun 2022 10:54:47 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1o6btm-003b76-By; Wed, 29 Jun 2022 14:54:46 -0300 Date: Wed, 29 Jun 2022 14:54:46 -0300 From: Jason Gunthorpe To: Liam Ni Cc: alex.williamson@redhat.com, cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio: check iommu_group_set_name() return value Message-ID: <20220629175446.GT23621@ziepe.ca> References: <20220625114239.9301-1-zhiguangni01@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220625114239.9301-1-zhiguangni01@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 25, 2022 at 07:42:39PM +0800, Liam Ni wrote: > As iommu_group_set_name() can fail,we should check the return value. > > Signed-off-by: Liam Ni > --- > drivers/vfio/vfio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) I prefer this - but notice it is not a bug because if iommu_group_set_name() fails then iommu_group_add_device() will return -ENOMEM. Reviewed-by: Jason Gunthorpe Jason