All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca
Cc: stefanb@linux.vnet.ibm.com, linux@mniewoehner.de,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	l.sanfilippo@kunbus.com, LinoSanfilippo@gmx.de, lukas@wunner.de,
	p.rosenberger@kunbus.com
Subject: [PATCH v7 08/10] tpm, tpm_tis: Request threaded interrupt handler
Date: Thu, 30 Jun 2022 01:26:51 +0200	[thread overview]
Message-ID: <20220629232653.1306735-9-LinoSanfilippo@gmx.de> (raw)
In-Reply-To: <20220629232653.1306735-1-LinoSanfilippo@gmx.de>

From: Lino Sanfilippo <l.sanfilippo@kunbus.com>

The TIS interrupt handler at least has to read and write the interrupt
status register. In case of SPI both operations result in a call to
tpm_tis_spi_transfer() which uses the bus_lock_mutex of the spi device
and thus must only be called from a sleepable context.

To ensure this request a threaded interrupt handler.

Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
Tested-by: Michael Niewöhner <linux@mniewoehner.de>
---
 drivers/char/tpm/tpm_tis_core.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
index e50a2c78de9f..83b31c25e55c 100644
--- a/drivers/char/tpm/tpm_tis_core.c
+++ b/drivers/char/tpm/tpm_tis_core.c
@@ -802,8 +802,11 @@ static int tpm_tis_probe_irq_single(struct tpm_chip *chip, u32 intmask,
 	int rc;
 	u32 int_status;
 
-	if (devm_request_irq(chip->dev.parent, irq, tis_int_handler, flags,
-			     dev_name(&chip->dev), chip) != 0) {
+
+	rc = devm_request_threaded_irq(chip->dev.parent, irq, NULL,
+				       tis_int_handler, IRQF_ONESHOT | flags,
+				       dev_name(&chip->dev), chip);
+	if (rc) {
 		dev_info(&chip->dev, "Unable to request irq: %d for probe\n",
 			 irq);
 		return -1;
-- 
2.25.1


  parent reply	other threads:[~2022-06-29 23:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-29 23:26 [PATCH v7 00/10] TPM IRQ fixes Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 01/10] tpm, tpm_tis: Avoid cache incoherency in test for interrupts Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 02/10] tpm, tpm_tis: Claim locality before writing TPM_INT_ENABLE register Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 03/10] tpm, tpm_tis: Disable interrupts if tpm_tis_probe_irq() failed Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 04/10] tpm, tmp_tis: Claim locality before writing interrupt registers Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 05/10] tpm, tpm_tis: Only handle supported interrupts Lino Sanfilippo
2022-06-30 23:18   ` Jarkko Sakkinen
2022-08-26 17:43   ` Jason Andryuk
2022-08-29  8:03     ` Lino Sanfilippo
2022-08-30  6:29     ` Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 06/10] tpm, tpm_tis: Move interrupt mask checks into own function Lino Sanfilippo
2022-06-30 23:19   ` Jarkko Sakkinen
2022-06-29 23:26 ` [PATCH v7 07/10] tmp, tmp_tis: Implement usage counter for locality Lino Sanfilippo
2022-06-30 23:29   ` Jarkko Sakkinen
2022-06-30 23:31     ` Jarkko Sakkinen
2022-07-04 17:45     ` Lino Sanfilippo
2022-07-11  2:50       ` Jarkko Sakkinen
2022-07-11 21:03         ` Lino Sanfilippo
2022-07-15 13:41           ` Jarkko Sakkinen
2022-07-27 12:16         ` Lino Sanfilippo
2022-07-28  8:15           ` Jarkko Sakkinen
2022-07-28 15:45             ` Lino Sanfilippo
2022-10-08 17:05               ` Lino Sanfilippo
2022-07-28 17:36       ` Lino Sanfilippo
2022-08-01 16:42         ` Jarkko Sakkinen
2022-07-11 19:39   ` Jason Andryuk
2022-07-11 21:15     ` Lino Sanfilippo
2022-06-29 23:26 ` Lino Sanfilippo [this message]
2022-06-30 23:32   ` [PATCH v7 08/10] tpm, tpm_tis: Request threaded interrupt handler Jarkko Sakkinen
2022-06-29 23:26 ` [PATCH v7 09/10] tpm, tpm_tis: Claim locality in " Lino Sanfilippo
2022-06-29 23:26 ` [PATCH v7 10/10] tpm, tpm_tis: Enable interrupt test Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220629232653.1306735-9-LinoSanfilippo@gmx.de \
    --to=linosanfilippo@gmx.de \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=l.sanfilippo@kunbus.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@mniewoehner.de \
    --cc=lukas@wunner.de \
    --cc=p.rosenberger@kunbus.com \
    --cc=peterhuewe@gmx.de \
    --cc=stefanb@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.