From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2EFDC433EF for ; Wed, 29 Jun 2022 23:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231416AbiF2Xbr (ORCPT ); Wed, 29 Jun 2022 19:31:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229821AbiF2Xbm (ORCPT ); Wed, 29 Jun 2022 19:31:42 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55B8625C; Wed, 29 Jun 2022 16:31:41 -0700 (PDT) Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 64A426601907; Thu, 30 Jun 2022 00:31:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656545499; bh=X82AnTeS9ql4xEMo8Ss/zWO0HusDJV9VvepmEeYZ+J0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FZFVdXWUBZB399V8KEwYh6tIku1a4jBEO9WHmqe/hDQheX/9GYKCYeSIuvT9hMLve Ie6JZ9z84WYFMRr+zJAmMA1jnBObYh9u3cy/0woI52gx455Bj1VYt+Al5R1ipAmSiV bTiP//qTup/B2Z2p+WVuWHfrjYzAgJ8I8NyX8QxPXlyV64wXu5EzmrbvGGCpTInrOV jHqgtW1FFWKCIGwkrcM3FQeO078a4e7/rbW89inh6DFIePPZUIl7EKvus9cSxKxiZ2 XWzHj3azdm/cea5pvTYt8fayc0UHP/STwO1vk1BFo7sJl7Fep5f9d5n1a/E5OJAR+f H/YjOE0oqJOTw== Date: Wed, 29 Jun 2022 19:31:34 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: Allen-KH Cheng , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH 4/5] arm64: dts: mt8192: Add dsi node Message-ID: <20220629233134.zt5ua4v5itycjmlt@notapiano> References: <20220629121358.19458-1-allen-kh.cheng@mediatek.com> <20220629121358.19458-5-allen-kh.cheng@mediatek.com> <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 29, 2022 at 03:42:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 29/06/22 14:13, Allen-KH Cheng ha scritto: > > Add dsi ndoe for mt8192 SoC. Typo: s/ndoe/node. > > > > Signed-off-by: Allen-KH Cheng > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > index 26d01544b4ea..72af328126de 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -1334,6 +1334,24 @@ > > mediatek,gce-client-reg = <&gce SUBSYS_1400XXXX 0xe000 0x1000>; > > }; > > + dsi0: dsi@14010000 { > > + compatible = "mediatek,mt8183-dsi"; > > + reg = <0 0x14010000 0 0x1000>; > > + interrupts = ; > > + mediatek,syscon-dsi = <&mmsys 0x140>; Also drop this syscon-dsi property. > > + clocks = <&mmsys CLK_MM_DSI0>, > > + <&mmsys CLK_MM_DSI_DSI0>, > > + <&mipi_tx0>; > > + clock-names = "engine", "digital", "hs"; > > + phys = <&mipi_tx0>; > > + phy-names = "dphy"; It's also missing power-domains. > > resets = <&mmsys MT8192_MMSYS_SW0_RST_B_DISP_DSI0>; > > ^^^ This is missing, please add it and resend :-) Also, when this is added you'll need #include With those addressed, Reviewed-by: Nícolas F. R. A. Prado Thanks, Nícolas > > > + status = "disabled"; > > + > > + port { > > + dsi_out: endpoint { }; > > + }; > > + }; > > + > > ovl_2l2: ovl@14014000 { > > compatible = "mediatek,mt8192-disp-ovl-2l"; > > reg = <0 0x14014000 0 0x1000>; > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2196C433EF for ; Wed, 29 Jun 2022 23:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TrNs33zWYDMiHqgqDKhcxX5VUgKyJ4PujxwU0C645Ts=; b=ZTzXjYinNeVYJK WgHBjjkbaTG0ZxT4Z3/iOTT8X+es33geCmMfJkxFRQcDcqdyr+l17uOCWbBsVI5ofReH5faie+SVf FcqNwkMy31zjMu23Y6oZpjl+KaQGV/NtY3ftXB9/kJylAlyglGpmZTBV3JxLRA+FKZvq7roMTpK9u onIbihyw49T1WHHNBsSRhpdLp52FiboHYmMXu/Fk4tw/9M4msVVRoTNFbgZ0sio/c9I0TQct4kcxl 7xZJbteMGfztuS/ZQgifVSyzoKsS+BoRF31Y0V0ZoulMa6U5aVpBIbGCWG808qGsX0sLp6L3FjFHL aNJ4pQ9TjzJQr0ZtI5nQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6h9t-00EPZC-6W; Wed, 29 Jun 2022 23:31:45 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6h9p-00EPYC-CO; Wed, 29 Jun 2022 23:31:43 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 64A426601907; Thu, 30 Jun 2022 00:31:38 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656545499; bh=X82AnTeS9ql4xEMo8Ss/zWO0HusDJV9VvepmEeYZ+J0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FZFVdXWUBZB399V8KEwYh6tIku1a4jBEO9WHmqe/hDQheX/9GYKCYeSIuvT9hMLve Ie6JZ9z84WYFMRr+zJAmMA1jnBObYh9u3cy/0woI52gx455Bj1VYt+Al5R1ipAmSiV bTiP//qTup/B2Z2p+WVuWHfrjYzAgJ8I8NyX8QxPXlyV64wXu5EzmrbvGGCpTInrOV jHqgtW1FFWKCIGwkrcM3FQeO078a4e7/rbW89inh6DFIePPZUIl7EKvus9cSxKxiZ2 XWzHj3azdm/cea5pvTYt8fayc0UHP/STwO1vk1BFo7sJl7Fep5f9d5n1a/E5OJAR+f H/YjOE0oqJOTw== Date: Wed, 29 Jun 2022 19:31:34 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: AngeloGioacchino Del Regno Cc: Allen-KH Cheng , Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH 4/5] arm64: dts: mt8192: Add dsi node Message-ID: <20220629233134.zt5ua4v5itycjmlt@notapiano> References: <20220629121358.19458-1-allen-kh.cheng@mediatek.com> <20220629121358.19458-5-allen-kh.cheng@mediatek.com> <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <730f334e-c10d-8f8b-94e6-b66a56e03320@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220629_163141_614723_13D545EF X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 29, 2022 at 03:42:42PM +0200, AngeloGioacchino Del Regno wrote: > Il 29/06/22 14:13, Allen-KH Cheng ha scritto: > > Add dsi ndoe for mt8192 SoC. Typo: s/ndoe/node. > > = > > Signed-off-by: Allen-KH Cheng > > --- > > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 18 ++++++++++++++++++ > > 1 file changed, 18 insertions(+) > > = > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot= /dts/mediatek/mt8192.dtsi > > index 26d01544b4ea..72af328126de 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > > @@ -1334,6 +1334,24 @@ > > mediatek,gce-client-reg =3D <&gce SUBSYS_1400XXXX 0xe000 0x1000>; > > }; > > + dsi0: dsi@14010000 { > > + compatible =3D "mediatek,mt8183-dsi"; > > + reg =3D <0 0x14010000 0 0x1000>; > > + interrupts =3D ; > > + mediatek,syscon-dsi =3D <&mmsys 0x140>; Also drop this syscon-dsi property. > > + clocks =3D <&mmsys CLK_MM_DSI0>, > > + <&mmsys CLK_MM_DSI_DSI0>, > > + <&mipi_tx0>; > > + clock-names =3D "engine", "digital", "hs"; > > + phys =3D <&mipi_tx0>; > > + phy-names =3D "dphy"; It's also missing power-domains. > = > resets =3D <&mmsys MT8192_MMSYS_SW0_RST_B_DISP_DSI0>; > = > ^^^ This is missing, please add it and resend :-) Also, when this is added you'll need #include With those addressed, Reviewed-by: N=EDcolas F. R. A. Prado Thanks, N=EDcolas > = > > + status =3D "disabled"; > > + > > + port { > > + dsi_out: endpoint { }; > > + }; > > + }; > > + > > ovl_2l2: ovl@14014000 { > > compatible =3D "mediatek,mt8192-disp-ovl-2l"; > > reg =3D <0 0x14014000 0 0x1000>; > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel