From: Prashant Malani <pmalani@chromium.org>
To: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
chrome-platform@lists.linux.dev
Cc: bleung@chromium.org, heikki.krogerus@linux.intel.com,
Prashant Malani <pmalani@chromium.org>,
Daisuke Nojiri <dnojiri@chromium.org>,
"Dustin L. Howett" <dustin@howett.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Kees Cook <keescook@chromium.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: [PATCH 8/9] platform/chrome: cros_ec_typec: Cleanup switch handle return paths
Date: Wed, 29 Jun 2022 23:32:26 +0000 [thread overview]
Message-ID: <20220629233314.3540377-9-pmalani@chromium.org> (raw)
In-Reply-To: <20220629233314.3540377-1-pmalani@chromium.org>
Some of the return paths for the cros_typec_get_switch_handles()
aren't necessary. Clean up the return paths to only undo the handle
get's which succeeded.
Signed-off-by: Prashant Malani <pmalani@chromium.org>
---
drivers/platform/chrome/cros_ec_typec.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 7cb2e35c4ded..39e6fd4491a9 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -157,12 +157,10 @@ static int cros_typec_get_switch_handles(struct cros_typec_port *port,
return 0;
role_sw_err:
- usb_role_switch_put(port->role_sw);
-ori_sw_err:
typec_switch_put(port->ori_sw);
-mux_err:
+ori_sw_err:
typec_mux_put(port->mux);
-
+mux_err:
return -ENODEV;
}
--
2.37.0.rc0.161.g10f37bed90-goog
next prev parent reply other threads:[~2022-06-29 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 23:32 [PATCH 0/9] platform/chrome: Type-C switch driver and Type-C framework updates Prashant Malani
2022-06-29 23:32 ` [PATCH 1/9] usb: typec: Add support for retimers Prashant Malani
2022-06-30 8:17 ` Heikki Krogerus
2022-06-30 10:18 ` Mika Westerberg
2022-06-30 17:13 ` Prashant Malani
2022-06-29 23:32 ` [PATCH 2/9] usb: typec: Add retimer handle to port Prashant Malani
2022-06-30 8:27 ` Heikki Krogerus
2022-06-30 17:16 ` Prashant Malani
2022-06-29 23:32 ` [PATCH 3/9] platform/chrome: Add Type-C mux set command definitions Prashant Malani
2022-06-29 23:32 ` [PATCH 4/9] platform/chrome: cros_typec_switch: Add switch driver Prashant Malani
2022-06-29 23:32 ` [PATCH 5/9] platform/chrome: cros_typec_switch: Set EC retimer Prashant Malani
2022-06-29 23:32 ` [PATCH 6/9] platform/chrome: cros_typec_switch: Add event check Prashant Malani
2022-06-29 23:32 ` [PATCH 7/9] platform/chrome: cros_typec_switch: Register mode switches Prashant Malani
2022-06-29 23:32 ` Prashant Malani [this message]
2022-06-29 23:32 ` [PATCH 9/9] platform/chrome: cros_ec_typec: Get retimer handle Prashant Malani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220629233314.3540377-9-pmalani@chromium.org \
--to=pmalani@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dnojiri@chromium.org \
--cc=dustin@howett.net \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.