From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07F7DCCA479 for ; Fri, 1 Jul 2022 15:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232716AbiGAPB4 (ORCPT ); Fri, 1 Jul 2022 11:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58170 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231622AbiGAPBz (ORCPT ); Fri, 1 Jul 2022 11:01:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C4173BBE1; Fri, 1 Jul 2022 08:01:54 -0700 (PDT) Received: from notapiano (unknown [193.27.14.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id DA00466015C3; Fri, 1 Jul 2022 16:01:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656687712; bh=KV8txWyzuGMyvqichkLpNPrOnFdPZYz0/zumqnUbANU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c6MwbqGGGMutomiodiKiGBF8NRaBRiqjXHRNQjh/Z6HRLSkWeXbJbAk6H3H5bBDpl F3OryY1HZMCOH4O0yZhxhjTKFHVuZO7LQNsghTyVirboP9pQP1LOdYjzQbRQD/iJku niXEuJR9jkprIPN+9CCoyupfocYzBsaiuhJQ30/UmMzYPO7+7IAaMEhL5X29NjvT3/ el8lu8fd94g0OEoq7KRGDiYPlXirAidpWq0nE9Q4dO//oP+KNjlvsKoQYaM8Js8UQM 8IKHVKxeWJPT7P/zvHN95HtJiSzgkmQQXueQHE1+or2bB5OPvw3LvK7jmgV2hIN2hQ pICV7f9Ur7B2g== Date: Fri, 1 Jul 2022 11:01:45 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Allen-KH Cheng , Fabien Parent , Hsin-Yi Wang , Krzysztof Kozlowski , Luca Weiss , Maxim Kutnij , Rob Herring , Sam Shih , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Message-ID: <20220701150145.2myyk2o3vxydyhql@notapiano> References: <20220629155956.1138955-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote: > On Thu, Jun 30, 2022 at 12:00 AM Nícolas F. R. A. Prado > wrote: > > > > > > This series introduces Devicetrees for the MT8192-based Asurada platform > > as well as Asurada Spherion and Asurada Hayato boards. > > > > Support for the boards is added to the extent that is currently enabled > > in the mt8192.dtsi, and using only properties already merged in the > > dt-bindings, as to not add any dependencies to this series. > > > > This series was peer-reviewed internally before submission. > > > > Series tested on next-20220629. > > Just FYI I also got the internal display to work after some fixes to > the dtsi [1] and copying the stuff over from the ChromeOS kernel tree. > > It might be harder to enable the external display, given that we don't > have a good way of describing the weird design of using the DP bridge > also as a mux. See [2] for ongoing discussion. Hi ChenYu, I actually have both the internal and external display working on my local branch [1], but the commits there aren't final, and I'm also following the Type-C switch discussion to update my commits whenever the binding is settled on. I noticed the lack of the mandatory display aliases in the mt8192 series but somehow missed mentioning that in the review, so thanks for adding that. Thanks, Nícolas [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asurada > > ChenYu > > [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=vV1NSk0AGRVYCa3Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/ > [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalani@chromium.org/ > > > v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@collabora.com/ > > v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@collabora.com/ > > v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/ > > > > Changes in v4: > > - Added patches 17-19 enabling MMC, SCP and SPI NOR flash > > - Switched mediatek,drive-strength-adv for drive-strength-microamp > > - Switched mediatek,pull-up-adv for bias-pull-up > > - Updated Vgpu minimum voltage to appropriate value > > > > Changes in v3: > > - Renamed regulator nodes to be generic > > - Fixed keyboard layout for Hayato > > > > Changes in v2: > > - Added patches 1-2 for Mediatek board dt-bindings > > - Added patches 13-16 enabling hardware for Asurada that has since been > > enabled on mt8192.dtsi > > > > Nícolas F. R. A. Prado (19): > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato > > arm64: dts: mediatek: Introduce MT8192-based Asurada board family > > arm64: dts: mediatek: asurada: Document GPIO names > > arm64: dts: mediatek: asurada: Add system-wide power supplies > > arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses > > arm64: dts: mediatek: asurada: Add ChromeOS EC > > arm64: dts: mediatek: asurada: Add keyboard mapping for the top row > > arm64: dts: mediatek: asurada: Add Cr50 TPM > > arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad > > arm64: dts: mediatek: asurada: Add I2C touchscreen > > arm64: dts: mediatek: spherion: Add keyboard backlight > > arm64: dts: mediatek: asurada: Enable XHCI > > arm64: dts: mediatek: asurada: Enable PCIe and add WiFi > > arm64: dts: mediatek: asurada: Add MT6359 PMIC > > arm64: dts: mediatek: asurada: Add SPMI regulators > > arm64: dts: mediatek: asurada: Enable MMC > > arm64: dts: mediatek: asurada: Enable SCP > > arm64: dts: mediatek: asurada: Add SPI NOR flash memory > > > > .../devicetree/bindings/arm/mediatek.yaml | 13 + > > arch/arm64/boot/dts/mediatek/Makefile | 2 + > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 + > > .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++ > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++++++ > > 5 files changed, 1083 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > > > -- > > 2.36.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2277FC43334 for ; Fri, 1 Jul 2022 15:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=irvEaGhVUkIGd1hevqDZBnqZKimcDuv6JdBy+kpnNXQ=; b=pxcTU7FqzcEIeU 2EwLnO4nLcyV2LdupHTzqPtgmz/BIbeuW61HrW1YK0oZfPvOIwrTzQSsHD2wCpQaJXUnhmabCsPmo Iouxtxl9eyh78AdU8BoKAkYM93cnKwZRQremk2xx11llTI026sfrNT9IC0ZmXpWMrOWaWZY+7acu4 j/7PGPh50ffH9qLMf2psbFCAhAkA+JiBMFiaqXW9fNgAPBd9JamQfe9G+5uv7Smq4PusjsTn8eFlE IlDUP7MfkR/J/Bjz8GNKV2ShTWaLQ2AqBGIPaj21UCYYKSip1WmnU/tLGE3febG5cQuECHt04nAxi VjcTq7RUATSzXE/z0wcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7I9l-005VzT-Ft; Fri, 01 Jul 2022 15:02:05 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7I9g-005Vvr-LI; Fri, 01 Jul 2022 15:02:04 +0000 Received: from notapiano (unknown [193.27.14.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id DA00466015C3; Fri, 1 Jul 2022 16:01:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656687712; bh=KV8txWyzuGMyvqichkLpNPrOnFdPZYz0/zumqnUbANU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c6MwbqGGGMutomiodiKiGBF8NRaBRiqjXHRNQjh/Z6HRLSkWeXbJbAk6H3H5bBDpl F3OryY1HZMCOH4O0yZhxhjTKFHVuZO7LQNsghTyVirboP9pQP1LOdYjzQbRQD/iJku niXEuJR9jkprIPN+9CCoyupfocYzBsaiuhJQ30/UmMzYPO7+7IAaMEhL5X29NjvT3/ el8lu8fd94g0OEoq7KRGDiYPlXirAidpWq0nE9Q4dO//oP+KNjlvsKoQYaM8Js8UQM 8IKHVKxeWJPT7P/zvHN95HtJiSzgkmQQXueQHE1+or2bB5OPvw3LvK7jmgV2hIN2hQ pICV7f9Ur7B2g== Date: Fri, 1 Jul 2022 11:01:45 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Allen-KH Cheng , Fabien Parent , Hsin-Yi Wang , Krzysztof Kozlowski , Luca Weiss , Maxim Kutnij , Rob Herring , Sam Shih , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Message-ID: <20220701150145.2myyk2o3vxydyhql@notapiano> References: <20220629155956.1138955-1-nfraprado@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_080201_010023_837F55EF X-CRM114-Status: GOOD ( 27.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote: > On Thu, Jun 30, 2022 at 12:00 AM N=EDcolas F. R. A. Prado > wrote: > > > > > > This series introduces Devicetrees for the MT8192-based Asurada platform > > as well as Asurada Spherion and Asurada Hayato boards. > > > > Support for the boards is added to the extent that is currently enabled > > in the mt8192.dtsi, and using only properties already merged in the > > dt-bindings, as to not add any dependencies to this series. > > > > This series was peer-reviewed internally before submission. > > > > Series tested on next-20220629. > = > Just FYI I also got the internal display to work after some fixes to > the dtsi [1] and copying the stuff over from the ChromeOS kernel tree. > = > It might be harder to enable the external display, given that we don't > have a good way of describing the weird design of using the DP bridge > also as a mux. See [2] for ongoing discussion. Hi ChenYu, I actually have both the internal and external display working on my local branch [1], but the commits there aren't final, and I'm also following the Type-C switch discussion to update my commits whenever the binding is settl= ed on. I noticed the lack of the mandatory display aliases in the mt8192 series but somehow missed mentioning that in the review, so thanks for adding that. Thanks, N=EDcolas [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asurada > = > ChenYu > = > [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=3DvV1NSk0AGRVYCa3= Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/ > [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalani@ch= romium.org/ > = > > v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@colla= bora.com/ > > v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@coll= abora.com/ > > v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@colla= bora.com/ > > > > Changes in v4: > > - Added patches 17-19 enabling MMC, SCP and SPI NOR flash > > - Switched mediatek,drive-strength-adv for drive-strength-microamp > > - Switched mediatek,pull-up-adv for bias-pull-up > > - Updated Vgpu minimum voltage to appropriate value > > > > Changes in v3: > > - Renamed regulator nodes to be generic > > - Fixed keyboard layout for Hayato > > > > Changes in v2: > > - Added patches 1-2 for Mediatek board dt-bindings > > - Added patches 13-16 enabling hardware for Asurada that has since been > > enabled on mt8192.dtsi > > > > N=EDcolas F. R. A. Prado (19): > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato > > arm64: dts: mediatek: Introduce MT8192-based Asurada board family > > arm64: dts: mediatek: asurada: Document GPIO names > > arm64: dts: mediatek: asurada: Add system-wide power supplies > > arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses > > arm64: dts: mediatek: asurada: Add ChromeOS EC > > arm64: dts: mediatek: asurada: Add keyboard mapping for the top row > > arm64: dts: mediatek: asurada: Add Cr50 TPM > > arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad > > arm64: dts: mediatek: asurada: Add I2C touchscreen > > arm64: dts: mediatek: spherion: Add keyboard backlight > > arm64: dts: mediatek: asurada: Enable XHCI > > arm64: dts: mediatek: asurada: Enable PCIe and add WiFi > > arm64: dts: mediatek: asurada: Add MT6359 PMIC > > arm64: dts: mediatek: asurada: Add SPMI regulators > > arm64: dts: mediatek: asurada: Enable MMC > > arm64: dts: mediatek: asurada: Enable SCP > > arm64: dts: mediatek: asurada: Add SPI NOR flash memory > > > > .../devicetree/bindings/arm/mediatek.yaml | 13 + > > arch/arm64/boot/dts/mediatek/Makefile | 2 + > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 + > > .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++ > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++++++ > > 5 files changed, 1083 insertions(+) > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-= r1.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherio= n-r0.dts > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > > > -- > > 2.36.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel