From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDEC3C43334 for ; Fri, 1 Jul 2022 16:40:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231881AbiGAQkx (ORCPT ); Fri, 1 Jul 2022 12:40:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiGAQkv (ORCPT ); Fri, 1 Jul 2022 12:40:51 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8926044753; Fri, 1 Jul 2022 09:40:49 -0700 (PDT) Received: from notapiano (unknown [193.27.14.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3A2C666015DA; Fri, 1 Jul 2022 17:40:45 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656693647; bh=0LN1nCFHY1IULTVl6FBa/H7bg/S9tIWVbV69kp8VbnA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAA9Si32fplazkxh8kicyhndXMgFsW4Iwzx/0yfMwj67OTUL7wGYE4ZQyAZnKtqEO iT6m6YdR/rwyrKrIVNJcb57lJfZpOyjXfncsoT+IT9UxEBvedDLpkq9nwO5uAgNMei frFMUE0Bv7Re8x2+qC0kdXny9jG3ke/Az7B41EdbKURPBmFxbOGUxYFJeVOB0UJitA 9iHPk+xxmpLp1txmzqZnuny6BoeNZZZP/hkMeo8lcfWvugQrYTeDsBht/2Dg1yPSCv Z9EeIdYXw6QCIoY/+/9UIbFEic6Ii3YwQ8Ddet0J7HWLVzn/pSaglY9OEyFrQ4muXF XEBBetMaCs1Yw== Date: Fri, 1 Jul 2022 12:40:41 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Allen-KH Cheng Cc: Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH v2 4/6] arm64: dts: mt8192: Add display nodes Message-ID: <20220701164041.rbt3idraawafubcf@notapiano> References: <20220701090547.21429-1-allen-kh.cheng@mediatek.com> <20220701090547.21429-5-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220701090547.21429-5-allen-kh.cheng@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 05:05:45PM +0800, Allen-KH Cheng wrote: > Add display nodes and gce info for mt8192 SoC. > > GCE (Global Command Engine) properties to the display nodes in order to > enable the usage of the CMDQ (Command Queue), which is required for > operating the display. > > Signed-off-by: Allen-KH Cheng > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: Nícolas F. R. A. Prado > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 137 +++++++++++++++++++++++ > 1 file changed, 137 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi > index a789b7c9b2af..c4dc8777f26c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi [..] > + rdma4: rdma@14015000 { > + compatible = "mediatek,mt8192-disp-rdma"; You added the fallback compatible on rdma0 but missing it on this node. Thanks, Nícolas > + reg = <0 0x14015000 0 0x1000>; > + interrupts = ; > + power-domains = <&spm MT8192_POWER_DOMAIN_DISP>; > + clocks = <&mmsys CLK_MM_DISP_RDMA4>; > + iommus = <&iommu0 M4U_PORT_L1_DISP_RDMA4>; > + mediatek,rdma-fifo-size = <2048>; > + mediatek,gce-client-reg = <&gce SUBSYS_1401XXXX 0x5000 0x1000>; > + }; > + > dpi0: dpi@14016000 { > compatible = "mediatek,mt8192-dpi"; > reg = <0 0x14016000 0 0x1000>; > -- > 2.18.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED565C43334 for ; Fri, 1 Jul 2022 16:41:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y9Ubc/1wz1xNYs03Z13ZMoz+J129bYQm8VeYUsHK2R0=; b=nefIkCIfG6+l3O wENHz6p+rc+dDyYXgOiko8QGaLvpMpdSECMjUdOrvJL7PuDxzLZGYWruOfHYwyqovjkTr3Nj0Bu3R R5WbjDDCIM8gc8RJtR5hRuUIzZXz59LRYswuxqX0OdqUoxWRUPX8cNCvFVWeyn1npGqGnKTv3Gyna Ns8LAl5nY/UWH6Mn0fjUhh9UyEanP+ozJG0r43n3fQzTfpeuadKwx9568WvNcuwD4CJ4swiiO+bdm 3SoR+yfke5/r0rrjBgkSZJJhNqm1QCnaoZUlPWOtoJ6BzQPB2yDhJHR7M2K3g9DmXUgR4rCxgyG62 WP4QK7WCwHLb4pbXmw8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7JhN-00631J-BH; Fri, 01 Jul 2022 16:40:53 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7JhJ-0062zl-W7; Fri, 01 Jul 2022 16:40:51 +0000 Received: from notapiano (unknown [193.27.14.116]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 3A2C666015DA; Fri, 1 Jul 2022 17:40:45 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1656693647; bh=0LN1nCFHY1IULTVl6FBa/H7bg/S9tIWVbV69kp8VbnA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BAA9Si32fplazkxh8kicyhndXMgFsW4Iwzx/0yfMwj67OTUL7wGYE4ZQyAZnKtqEO iT6m6YdR/rwyrKrIVNJcb57lJfZpOyjXfncsoT+IT9UxEBvedDLpkq9nwO5uAgNMei frFMUE0Bv7Re8x2+qC0kdXny9jG3ke/Az7B41EdbKURPBmFxbOGUxYFJeVOB0UJitA 9iHPk+xxmpLp1txmzqZnuny6BoeNZZZP/hkMeo8lcfWvugQrYTeDsBht/2Dg1yPSCv Z9EeIdYXw6QCIoY/+/9UIbFEic6Ii3YwQ8Ddet0J7HWLVzn/pSaglY9OEyFrQ4muXF XEBBetMaCs1Yw== Date: Fri, 1 Jul 2022 12:40:41 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Allen-KH Cheng Cc: Matthias Brugger , Rob Herring , Krzysztof Kozlowski , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Chen-Yu Tsai Subject: Re: [PATCH v2 4/6] arm64: dts: mt8192: Add display nodes Message-ID: <20220701164041.rbt3idraawafubcf@notapiano> References: <20220701090547.21429-1-allen-kh.cheng@mediatek.com> <20220701090547.21429-5-allen-kh.cheng@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220701090547.21429-5-allen-kh.cheng@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_094050_285604_65B0C6DA X-CRM114-Status: GOOD ( 16.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 05:05:45PM +0800, Allen-KH Cheng wrote: > Add display nodes and gce info for mt8192 SoC. > = > GCE (Global Command Engine) properties to the display nodes in order to > enable the usage of the CMDQ (Command Queue), which is required for > operating the display. > = > Signed-off-by: Allen-KH Cheng > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: N=EDcolas F. R. A. Prado > --- > arch/arm64/boot/dts/mediatek/mt8192.dtsi | 137 +++++++++++++++++++++++ > 1 file changed, 137 insertions(+) > = > diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/d= ts/mediatek/mt8192.dtsi > index a789b7c9b2af..c4dc8777f26c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi [..] > + rdma4: rdma@14015000 { > + compatible =3D "mediatek,mt8192-disp-rdma"; You added the fallback compatible on rdma0 but missing it on this node. Thanks, N=EDcolas > + reg =3D <0 0x14015000 0 0x1000>; > + interrupts =3D ; > + power-domains =3D <&spm MT8192_POWER_DOMAIN_DISP>; > + clocks =3D <&mmsys CLK_MM_DISP_RDMA4>; > + iommus =3D <&iommu0 M4U_PORT_L1_DISP_RDMA4>; > + mediatek,rdma-fifo-size =3D <2048>; > + mediatek,gce-client-reg =3D <&gce SUBSYS_1401XXXX 0x5000 0x1000>; > + }; > + > dpi0: dpi@14016000 { > compatible =3D "mediatek,mt8192-dpi"; > reg =3D <0 0x14016000 0 0x1000>; > -- = > 2.18.0 > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel