From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D88BFC43334 for ; Fri, 1 Jul 2022 19:34:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230269AbiGATes (ORCPT ); Fri, 1 Jul 2022 15:34:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbiGATeq (ORCPT ); Fri, 1 Jul 2022 15:34:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 514F71BE84 for ; Fri, 1 Jul 2022 12:34:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E247662101 for ; Fri, 1 Jul 2022 19:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AE7C3411E; Fri, 1 Jul 2022 19:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656704084; bh=dEu/u9dgfs1RHHkM0fkOgtAUXU1kmpj5LCeuGMQMttI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jdzO9DswH3WCzTLver5Ukfwgcu1y3kEayD2Udew/YpxLqyMuG4k2AmOajMU5ZhEdr 4DPH8fYP89C473mASb73jj2AGtVbyT+65zfdfVZIN+zQPw5pNL50WCxTc9e5gbiY7R diNX+0lYiYuAaDSJrj7OeFyNvWM4YJ6bDYn9j45g2P0NWEi45kswkf41xp3EoT8VRT ikHAgseGyuPYr+gGznoao+WcJDGN39lJCacnrzhVr2AcrlkYUP8A6IKP7sO5hZYzJ7 B0GzDZZiyWkoiJQhQeozynCH+I4ITfPubb1KENP352K5CjOGH6f1wrsi4vR1w0EvQQ rSSCigcEt6dpA== Date: Fri, 1 Jul 2022 21:34:35 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , "Alvin __ipraga" , Claudiu Manoil , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Hauke Mehrtens , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh Subject: Re: [PATCH RFC net-next 5/6] net: dsa: always use phylink for CPU and DSA ports Message-ID: <20220701213435.53ecdd70@thinkpad> In-Reply-To: References: X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 29 Jun 2022 13:51:43 +0100 "Russell King (Oracle)" wrote: > Currently, we only use phylink for CPU and DSA ports if there is a > fixed-link specification, or a PHY specified. The reason for this > behaviour is that when neither is specified, there was no way for > phylink to know the link parameters. >=20 > Now that we have phylink_set_max_link_speed() (which has become > possible through the addition of mac_capabilities) we now have the > ability to know the maximum link speed for a specific link, and can > now use phylink for this case as well. >=20 > However, we need DSA drivers to report the interface mode being used > on these ports so that we can select a maximum speed appropriate for > the interface mode that hardware may have configured for the port. >=20 > This is especially important with the conversion of DSA drivers to > phylink_pcs, as the PCS code only gets called if we are using > phylink for the port. >=20 > Signed-off-by: Russell King (Oracle) Reviewed-by: Marek Beh=C3=BAn So this is the one that may break other drivers? Marek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24946C433EF for ; Fri, 1 Jul 2022 19:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BLoMAdQsrtpCmMVZX28wU+r23n33etsHGIqYOnpEt0E=; b=oGruND+dSBjqSD Qg3GdJs4glFsjpZnr70/CPWXX0n1UidJuauF1dsX8z3E18pb3qdr6sDqbq12ltibE2n+TSL1M2YeF 3nDg5vhv3QRmxajpLnw9VbUYzlISJWZ7QNbsnnlwH2IUuP7hPgDj99T/a35E8oZS+62oZJYK7h8hm OrnJXRCZuvoEWsvy/V3Pb+aE82UtubawgDb5HQdZ2FpCMLpxPo1sqSFyaEj4fcUbQNohbufp94aoG 1FYp9TAhpMYw6+4D3+OHcyHC36Z92ctk50PS/NYtGiFPya6qcRveBadi5napciJj3D3L0wcQ8wtmo 1tQyjUBrSxuOTIyPnkZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7MPk-006crk-Cs; Fri, 01 Jul 2022 19:34:52 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o7MPf-006cpw-8w; Fri, 01 Jul 2022 19:34:48 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9AF75B80D15; Fri, 1 Jul 2022 19:34:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10AE7C3411E; Fri, 1 Jul 2022 19:34:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656704084; bh=dEu/u9dgfs1RHHkM0fkOgtAUXU1kmpj5LCeuGMQMttI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jdzO9DswH3WCzTLver5Ukfwgcu1y3kEayD2Udew/YpxLqyMuG4k2AmOajMU5ZhEdr 4DPH8fYP89C473mASb73jj2AGtVbyT+65zfdfVZIN+zQPw5pNL50WCxTc9e5gbiY7R diNX+0lYiYuAaDSJrj7OeFyNvWM4YJ6bDYn9j45g2P0NWEi45kswkf41xp3EoT8VRT ikHAgseGyuPYr+gGznoao+WcJDGN39lJCacnrzhVr2AcrlkYUP8A6IKP7sO5hZYzJ7 B0GzDZZiyWkoiJQhQeozynCH+I4ITfPubb1KENP352K5CjOGH6f1wrsi4vR1w0EvQQ rSSCigcEt6dpA== Date: Fri, 1 Jul 2022 21:34:35 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Belloni , "Alvin __ipraga" , Claudiu Manoil , "David S. Miller" , DENG Qingfang , Eric Dumazet , Florian Fainelli , George McCollister , Hauke Mehrtens , Jakub Kicinski , Kurt Kanzenbach , Landen Chao , Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang , UNGLinuxDriver@microchip.com, Vivien Didelot , Vladimir Oltean , Woojung Huh Subject: Re: [PATCH RFC net-next 5/6] net: dsa: always use phylink for CPU and DSA ports Message-ID: <20220701213435.53ecdd70@thinkpad> In-Reply-To: References: X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220701_123447_529829_F97394AC X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOSBKdW4gMjAyMiAxMzo1MTo0MyArMDEwMAoiUnVzc2VsbCBLaW5nIChPcmFjbGUp IiA8cm1rK2tlcm5lbEBhcm1saW51eC5vcmcudWs+IHdyb3RlOgoKPiBDdXJyZW50bHksIHdlIG9u bHkgdXNlIHBoeWxpbmsgZm9yIENQVSBhbmQgRFNBIHBvcnRzIGlmIHRoZXJlIGlzIGEKPiBmaXhl ZC1saW5rIHNwZWNpZmljYXRpb24sIG9yIGEgUEhZIHNwZWNpZmllZC4gVGhlIHJlYXNvbiBmb3Ig dGhpcwo+IGJlaGF2aW91ciBpcyB0aGF0IHdoZW4gbmVpdGhlciBpcyBzcGVjaWZpZWQsIHRoZXJl IHdhcyBubyB3YXkgZm9yCj4gcGh5bGluayB0byBrbm93IHRoZSBsaW5rIHBhcmFtZXRlcnMuCj4g Cj4gTm93IHRoYXQgd2UgaGF2ZSBwaHlsaW5rX3NldF9tYXhfbGlua19zcGVlZCgpICh3aGljaCBo YXMgYmVjb21lCj4gcG9zc2libGUgdGhyb3VnaCB0aGUgYWRkaXRpb24gb2YgbWFjX2NhcGFiaWxp dGllcykgd2Ugbm93IGhhdmUgdGhlCj4gYWJpbGl0eSB0byBrbm93IHRoZSBtYXhpbXVtIGxpbmsg c3BlZWQgZm9yIGEgc3BlY2lmaWMgbGluaywgYW5kIGNhbgo+IG5vdyB1c2UgcGh5bGluayBmb3Ig dGhpcyBjYXNlIGFzIHdlbGwuCj4gCj4gSG93ZXZlciwgd2UgbmVlZCBEU0EgZHJpdmVycyB0byBy ZXBvcnQgdGhlIGludGVyZmFjZSBtb2RlIGJlaW5nIHVzZWQKPiBvbiB0aGVzZSBwb3J0cyBzbyB0 aGF0IHdlIGNhbiBzZWxlY3QgYSBtYXhpbXVtIHNwZWVkIGFwcHJvcHJpYXRlIGZvcgo+IHRoZSBp bnRlcmZhY2UgbW9kZSB0aGF0IGhhcmR3YXJlIG1heSBoYXZlIGNvbmZpZ3VyZWQgZm9yIHRoZSBw b3J0Lgo+IAo+IFRoaXMgaXMgZXNwZWNpYWxseSBpbXBvcnRhbnQgd2l0aCB0aGUgY29udmVyc2lv biBvZiBEU0EgZHJpdmVycyB0bwo+IHBoeWxpbmtfcGNzLCBhcyB0aGUgUENTIGNvZGUgb25seSBn ZXRzIGNhbGxlZCBpZiB3ZSBhcmUgdXNpbmcKPiBwaHlsaW5rIGZvciB0aGUgcG9ydC4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBSdXNzZWxsIEtpbmcgKE9yYWNsZSkgPHJtaytrZXJuZWxAYXJtbGludXgu b3JnLnVrPgoKUmV2aWV3ZWQtYnk6IE1hcmVrIEJlaMO6biA8a2FiZWxAa2VybmVsLm9yZz4KClNv IHRoaXMgaXMgdGhlIG9uZSB0aGF0IG1heSBicmVhayBvdGhlciBkcml2ZXJzPwoKTWFyZWsKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK