From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 941E1C433EF for ; Sat, 2 Jul 2022 00:18:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2106B0071; Fri, 1 Jul 2022 20:18:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A83146B0073; Fri, 1 Jul 2022 20:18:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 971356B0074; Fri, 1 Jul 2022 20:18:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 89A0A6B0071 for ; Fri, 1 Jul 2022 20:18:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay13.hostedemail.com (Postfix) with ESMTP id 67AB560187 for ; Sat, 2 Jul 2022 00:18:21 +0000 (UTC) X-FDA: 79640248002.30.EC9BF9F Received: from mail3-162.sinamail.sina.com.cn (mail3-162.sinamail.sina.com.cn [202.108.3.162]) by imf04.hostedemail.com (Postfix) with SMTP id 5B04240035 for ; Sat, 2 Jul 2022 00:18:18 +0000 (UTC) Received: from unknown (HELO localhost.localdomain)([114.249.59.48]) by sina.com (172.16.97.27) with ESMTP id 62BF8E990001B26F; Sat, 2 Jul 2022 08:17:31 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 21450649285502 From: Hillf Danton To: Alexander Potapenko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 11/45] kmsan: add KMSAN runtime core Date: Sat, 2 Jul 2022 08:18:06 +0800 Message-Id: <20220702001806.1379-1-hdanton@sina.com> In-Reply-To: <20220701142310.2188015-12-glider@google.com> References: <20220701142310.2188015-1-glider@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656721101; a=rsa-sha256; cv=none; b=0jb5tLrd9fKf5pCyBj4bPXhYeSD80aETU//d9DEicJIxtbsMaqqAu4acydQYuGT/oQn54M uG0Tiywxjbcad4QRHV3HUR381NE22WSZcU1u8MktTAmXSrxngPffGRXSzXtUfJ93Mwejp0 8FOLlmWez+2dw4iWQYEWK+NGDfIkyRg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.162 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656721101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YGUeB1jdGhBWGmxnLdpTgC9oMUg33Az51sYP7PZ/K4Y=; b=SDNQGQGWv0D93AF4dDYhjBDZWuGOWP8EEVyMG0E5fM5NCr2eZhkIKEbZgGBMYG12++v6f1 4SBe+4QlPjybmPpzI7erNY6yop4H7A3wlZEkcH40J+hOXkdZn4JeTjdZ3Pc5vtRtYv+iC/ NxjD1LD8oPNS+Fcjmx0MuCa14N3DTm8= X-Rspamd-Queue-Id: 5B04240035 X-Rspam-User: Authentication-Results: imf04.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf04.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.162 as permitted sender) smtp.mailfrom=hdanton@sina.com X-Rspamd-Server: rspam02 X-Stat-Signature: jfcwos9nu6asiibjs4ir8agkggt4ix6f X-HE-Tag: 1656721098-412785 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 1 Jul 2022 16:22:36 +0200 Alexander Potapenko wrote: > + > +bool kmsan_internal_is_module_addr(void *vaddr) > +{ > + return ((u64)vaddr >=3D MODULES_VADDR) && ((u64)vaddr < MODULES_END); > +} > + > +bool kmsan_internal_is_vmalloc_addr(void *addr) > +{ > + return ((u64)addr >=3D VMALLOC_START) && ((u64)addr < VMALLOC_END); > +} Given is_vmalloc_addr(), feel free to add a one-line comment showing the reason for adding the kmsan internal version. Hillf