From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFB00C43334 for ; Mon, 4 Jul 2022 13:01:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234596AbiGDNB6 (ORCPT ); Mon, 4 Jul 2022 09:01:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234591AbiGDNB5 (ORCPT ); Mon, 4 Jul 2022 09:01:57 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8554B1C2; Mon, 4 Jul 2022 06:01:56 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 35AC368AA6; Mon, 4 Jul 2022 15:01:53 +0200 (CEST) Date: Mon, 4 Jul 2022 15:01:53 +0200 From: Christoph Hellwig To: Johannes Thumshirn Cc: Christoph Hellwig , Jens Axboe , Damien Le Moal , "dm-devel@redhat.com" , "linux-block@vger.kernel.org" , "linux-nvme@lists.infradead.org" , "linux-scsi@vger.kernel.org" Subject: Re: [PATCH 01/17] block: remove a superflous ifdef in blkdev.h Message-ID: <20220704130153.GA23752@lst.de> References: <20220704124500.155247-1-hch@lst.de> <20220704124500.155247-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Mon, Jul 04, 2022 at 12:58:40PM +0000, Johannes Thumshirn wrote: > > -#ifdef CONFIG_BLK_DEV_ZONED > > - > > /* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */ > > const char *blk_zone_cond_str(enum blk_zone_cond zone_cond); > > > > Won't this break tracing in null_blk, which uses blk_zone_cond_str()? How could removing an ifdef and exposing a prototype unconditionally in a header break tracing? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51D10C433EF for ; Mon, 4 Jul 2022 13:02:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656939726; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+n4eiSXGVkfqytZxFFaXahIPMqX9aDO1PGYOC9NbiS4=; b=GMyRxCSm4eHuOEzNoI0zFcJnjKbtSNkkNHu6SG5UJS9ixYADdzQSlBZfmfaY5PDV8QLsy6 oh7mJNC1WDKu8UT9jyJ0ZI2Tg2tanimfjjAmjy+fXBy8R5Y+lpBXdou94fR9ykBPgDBNHJ DtV/7wPBT0RLUEjca+Tw8W1d0xoFmqc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-79-2WqtY8BlMSWkgCxO8AXaMw-1; Mon, 04 Jul 2022 09:02:05 -0400 X-MC-Unique: 2WqtY8BlMSWkgCxO8AXaMw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6C95A101A59A; Mon, 4 Jul 2022 13:02:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58A9618EB7; Mon, 4 Jul 2022 13:02:02 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 10235194704A; Mon, 4 Jul 2022 13:02:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id CD47219466DF for ; Mon, 4 Jul 2022 13:02:00 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id BC70A400EA82; Mon, 4 Jul 2022 13:02:00 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B7AB640B40C6 for ; Mon, 4 Jul 2022 13:02:00 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A4133811E75 for ; Mon, 4 Jul 2022 13:02:00 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-vhp8yxW1P_6a0mUkQJ9yUg-1; Mon, 04 Jul 2022 09:01:57 -0400 X-MC-Unique: vhp8yxW1P_6a0mUkQJ9yUg-1 Received: by verein.lst.de (Postfix, from userid 2407) id 35AC368AA6; Mon, 4 Jul 2022 15:01:53 +0200 (CEST) Date: Mon, 4 Jul 2022 15:01:53 +0200 From: Christoph Hellwig To: Johannes Thumshirn Message-ID: <20220704130153.GA23752@lst.de> References: <20220704124500.155247-1-hch@lst.de> <20220704124500.155247-2-hch@lst.de> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 Subject: Re: [dm-devel] [PATCH 01/17] block: remove a superflous ifdef in blkdev.h X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , "linux-scsi@vger.kernel.org" , Damien Le Moal , "linux-nvme@lists.infradead.org" , "linux-block@vger.kernel.org" , "dm-devel@redhat.com" , Christoph Hellwig Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Jul 04, 2022 at 12:58:40PM +0000, Johannes Thumshirn wrote: > > -#ifdef CONFIG_BLK_DEV_ZONED > > - > > /* Helper to convert BLK_ZONE_ZONE_XXX to its string format XXX */ > > const char *blk_zone_cond_str(enum blk_zone_cond zone_cond); > > > > Won't this break tracing in null_blk, which uses blk_zone_cond_str()? How could removing an ifdef and exposing a prototype unconditionally in a header break tracing? -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel