From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBA5B29A1 for ; Tue, 5 Jul 2022 10:36:59 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8fuq-0001LC-19; Tue, 05 Jul 2022 12:36:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8fue-004XxA-J7; Tue, 05 Jul 2022 12:36:16 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8fuh-0038F6-8t; Tue, 05 Jul 2022 12:36:15 +0200 Date: Tue, 5 Jul 2022 12:36:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jean Delvare Cc: Wolfram Sang , Guenter Roeck , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705103615.ceeq7rku53x743ps@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <20220705120852.049dc235@endymion.delvare> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gut2agzhpaayxotv" Content-Disposition: inline In-Reply-To: <20220705120852.049dc235@endymion.delvare> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-staging@lists.linux.dev --gut2agzhpaayxotv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- >=20 > That's a huge change for a relatively small benefit, but if this is > approved by the I2C core maintainer then fine with me. For: Agreed, it's huge. The benefit isn't really measureable, the motivation is to improve the situation for driver authors who with the change cannot make wrong assumptions about what to return in .remove(). During the preparation this uncovered a few bugs. See for example bbc126ae381cf0a27822c1f822d0aeed74cc40d9. > > drivers/hwmon/adc128d818.c | 4 +--- > > drivers/hwmon/adt7470.c | 3 +-- > > drivers/hwmon/asb100.c | 6 ++---- > > drivers/hwmon/asc7621.c | 4 +--- > > drivers/hwmon/dme1737.c | 4 +--- > > drivers/hwmon/f75375s.c | 5 ++--- > > drivers/hwmon/fschmd.c | 6 ++---- > > drivers/hwmon/ftsteutates.c | 3 +-- > > drivers/hwmon/ina209.c | 4 +--- > > drivers/hwmon/ina3221.c | 4 +--- > > drivers/hwmon/jc42.c | 3 +-- > > drivers/hwmon/mcp3021.c | 4 +--- > > drivers/hwmon/occ/p8_i2c.c | 4 +--- > > drivers/hwmon/pcf8591.c | 3 +-- > > drivers/hwmon/smm665.c | 3 +-- > > drivers/hwmon/tps23861.c | 4 +--- > > drivers/hwmon/w83781d.c | 4 +--- > > drivers/hwmon/w83791d.c | 6 ++---- > > drivers/hwmon/w83792d.c | 6 ++---- > > drivers/hwmon/w83793.c | 6 ++---- > > drivers/hwmon/w83795.c | 4 +--- > > drivers/hwmon/w83l785ts.c | 6 ++---- > > drivers/i2c/i2c-core-base.c | 6 +----- > > drivers/i2c/i2c-slave-eeprom.c | 4 +--- > > drivers/i2c/i2c-slave-testunit.c | 3 +-- > > drivers/i2c/i2c-smbus.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- >=20 > Reviewed-by: Jean Delvare Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gut2agzhpaayxotv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLEFBwACgkQwfwUeK3K 7AkavggAgLmynakXX/rOF4Jwy2OuBXH29kecKqPd6xj4yHsu3ggy8kd/hlU4jJib vV0H9ioq69hhMqjme5AHJJsueLFi/t/iwuQwuWUKluCBBlx0RXBsVx8qxV7A0uWa mdKU3ApPaN7y0cS1jccdN7ydsL3H2ayzIwfQuNqx1G3P/uqXfkusV0fjwQ/rQct3 qs4t2/QiHUd0tStlGw2eSKxp1z5KRrDMstK17fiZSsw/SYoMyldV8Ame6+gaxx0X e93FqM5jj67ovjD3jJanfOwI5vesu4+szu4GK6vHRWvpsieHsSeyS+GNgfM5oLA7 iguZ0rauzy0je3hrHuKgp1maJ59ibQ== =fYiS -----END PGP SIGNATURE----- --gut2agzhpaayxotv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E76BC433EF for ; Tue, 5 Jul 2022 10:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TbwAcUqXYQrB04mDKB5DTQqb/ZGb4Cdr9rr8CirjKYA=; b=nhAtIB/hSCw3Bw2K+QnRWGTXgr lI62jZr5UnDjVWGASgnZTcVY+IbgfCyMUqrhxVTEVgtaaGDgRDEiVFjWFiPUcPOHGITr4lQ5piu0m 55GljA1SZTas7je5wKPkFtip5hpJ9ofIyktk6BHkklUGUaNx0QkFC7UX+EhbgRPn66Lo1H6HQ5ez5 9IJibpfUrkghjBJbMS821WT+K6KvK97Ykwrm3a8edRkiWrypPwY/txJRX2imX+3bnU81cYMOUbPoI KsEbEspngQMIvo+GNeyi1DHb0Kv/3PtBcXTxxMGK/CCdMZigQ5lbKhixPwWqXQJ/aK4dljf74z4rp 9AnWOOTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8fwB-00HCH4-6k; Tue, 05 Jul 2022 10:37:47 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8fw0-00HCE5-W5 for linux-mtd@lists.infradead.org; Tue, 05 Jul 2022 10:37:38 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8fuq-0001LC-19; Tue, 05 Jul 2022 12:36:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8fue-004XxA-J7; Tue, 05 Jul 2022 12:36:16 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8fuh-0038F6-8t; Tue, 05 Jul 2022 12:36:15 +0200 Date: Tue, 5 Jul 2022 12:36:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jean Delvare Cc: Wolfram Sang , Guenter Roeck , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705103615.ceeq7rku53x743ps@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <20220705120852.049dc235@endymion.delvare> MIME-Version: 1.0 In-Reply-To: <20220705120852.049dc235@endymion.delvare> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mtd@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_033737_080095_55A153F1 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============3595555591410652658==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============3595555591410652658== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gut2agzhpaayxotv" Content-Disposition: inline --gut2agzhpaayxotv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- >=20 > That's a huge change for a relatively small benefit, but if this is > approved by the I2C core maintainer then fine with me. For: Agreed, it's huge. The benefit isn't really measureable, the motivation is to improve the situation for driver authors who with the change cannot make wrong assumptions about what to return in .remove(). During the preparation this uncovered a few bugs. See for example bbc126ae381cf0a27822c1f822d0aeed74cc40d9. > > drivers/hwmon/adc128d818.c | 4 +--- > > drivers/hwmon/adt7470.c | 3 +-- > > drivers/hwmon/asb100.c | 6 ++---- > > drivers/hwmon/asc7621.c | 4 +--- > > drivers/hwmon/dme1737.c | 4 +--- > > drivers/hwmon/f75375s.c | 5 ++--- > > drivers/hwmon/fschmd.c | 6 ++---- > > drivers/hwmon/ftsteutates.c | 3 +-- > > drivers/hwmon/ina209.c | 4 +--- > > drivers/hwmon/ina3221.c | 4 +--- > > drivers/hwmon/jc42.c | 3 +-- > > drivers/hwmon/mcp3021.c | 4 +--- > > drivers/hwmon/occ/p8_i2c.c | 4 +--- > > drivers/hwmon/pcf8591.c | 3 +-- > > drivers/hwmon/smm665.c | 3 +-- > > drivers/hwmon/tps23861.c | 4 +--- > > drivers/hwmon/w83781d.c | 4 +--- > > drivers/hwmon/w83791d.c | 6 ++---- > > drivers/hwmon/w83792d.c | 6 ++---- > > drivers/hwmon/w83793.c | 6 ++---- > > drivers/hwmon/w83795.c | 4 +--- > > drivers/hwmon/w83l785ts.c | 6 ++---- > > drivers/i2c/i2c-core-base.c | 6 +----- > > drivers/i2c/i2c-slave-eeprom.c | 4 +--- > > drivers/i2c/i2c-slave-testunit.c | 3 +-- > > drivers/i2c/i2c-smbus.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- >=20 > Reviewed-by: Jean Delvare Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gut2agzhpaayxotv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLEFBwACgkQwfwUeK3K 7AkavggAgLmynakXX/rOF4Jwy2OuBXH29kecKqPd6xj4yHsu3ggy8kd/hlU4jJib vV0H9ioq69hhMqjme5AHJJsueLFi/t/iwuQwuWUKluCBBlx0RXBsVx8qxV7A0uWa mdKU3ApPaN7y0cS1jccdN7ydsL3H2ayzIwfQuNqx1G3P/uqXfkusV0fjwQ/rQct3 qs4t2/QiHUd0tStlGw2eSKxp1z5KRrDMstK17fiZSsw/SYoMyldV8Ame6+gaxx0X e93FqM5jj67ovjD3jJanfOwI5vesu4+szu4GK6vHRWvpsieHsSeyS+GNgfM5oLA7 iguZ0rauzy0je3hrHuKgp1maJ59ibQ== =fYiS -----END PGP SIGNATURE----- --gut2agzhpaayxotv-- --===============3595555591410652658== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============3595555591410652658==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 167D1C433EF for ; Tue, 5 Jul 2022 10:38:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MbqMbCZb9kVJGlHjWjLzMfWdiKzUgsVwH8Nb9CioYNk=; b=alpomL168kfy7esVSBGM+71n6h HeYAjYHF2ERY5aLOZo4XeNs4XpZLUtebcV7T6EFYQryRsQZKP+kvbhmWro8mxIewKxrCJ3lAD3Sg2 gXKRhqm/LjAQD6YPS/NdUpHeobCkwivqw5EpX9G0/4mYBT8V/XTNOr/fwWw2V4B6KXNBkct/OZQOE 89Yz7Fm0bXKCOes+P4DBpUXWsR1/XtwsQJlveVRjT9DvFKTcCDseTWSKX3f2aEWdUnyulzFpYc7Vl gfD8k2VRR5yAXs0knf4DCZc5GunGLNpSZzcOFxjnxtzYrfvQN6iIe4SJkWbZ8n2rlYC+2AgLXOMq+ 566dtkxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8fw2-00HCEy-To; Tue, 05 Jul 2022 10:37:39 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8fvy-00HCCD-3j for linux-arm-kernel@lists.infradead.org; Tue, 05 Jul 2022 10:37:35 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8fuq-0001LC-19; Tue, 05 Jul 2022 12:36:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8fue-004XxA-J7; Tue, 05 Jul 2022 12:36:16 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8fuh-0038F6-8t; Tue, 05 Jul 2022 12:36:15 +0200 Date: Tue, 5 Jul 2022 12:36:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jean Delvare Cc: Wolfram Sang , Guenter Roeck , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, openipmi-developer@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, chrome-platform@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, platform-driver-x86@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-pm@vger.kernel.org, linux-pwm@vger.kernel.org, linux-rtc@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, kasan-dev@googlegroups.com, linux-mediatek@lists.infradead.org Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705103615.ceeq7rku53x743ps@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <20220705120852.049dc235@endymion.delvare> MIME-Version: 1.0 In-Reply-To: <20220705120852.049dc235@endymion.delvare> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_033734_254279_19BD9512 X-CRM114-Status: GOOD ( 22.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6466679513976252955==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6466679513976252955== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gut2agzhpaayxotv" Content-Disposition: inline --gut2agzhpaayxotv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- >=20 > That's a huge change for a relatively small benefit, but if this is > approved by the I2C core maintainer then fine with me. For: Agreed, it's huge. The benefit isn't really measureable, the motivation is to improve the situation for driver authors who with the change cannot make wrong assumptions about what to return in .remove(). During the preparation this uncovered a few bugs. See for example bbc126ae381cf0a27822c1f822d0aeed74cc40d9. > > drivers/hwmon/adc128d818.c | 4 +--- > > drivers/hwmon/adt7470.c | 3 +-- > > drivers/hwmon/asb100.c | 6 ++---- > > drivers/hwmon/asc7621.c | 4 +--- > > drivers/hwmon/dme1737.c | 4 +--- > > drivers/hwmon/f75375s.c | 5 ++--- > > drivers/hwmon/fschmd.c | 6 ++---- > > drivers/hwmon/ftsteutates.c | 3 +-- > > drivers/hwmon/ina209.c | 4 +--- > > drivers/hwmon/ina3221.c | 4 +--- > > drivers/hwmon/jc42.c | 3 +-- > > drivers/hwmon/mcp3021.c | 4 +--- > > drivers/hwmon/occ/p8_i2c.c | 4 +--- > > drivers/hwmon/pcf8591.c | 3 +-- > > drivers/hwmon/smm665.c | 3 +-- > > drivers/hwmon/tps23861.c | 4 +--- > > drivers/hwmon/w83781d.c | 4 +--- > > drivers/hwmon/w83791d.c | 6 ++---- > > drivers/hwmon/w83792d.c | 6 ++---- > > drivers/hwmon/w83793.c | 6 ++---- > > drivers/hwmon/w83795.c | 4 +--- > > drivers/hwmon/w83l785ts.c | 6 ++---- > > drivers/i2c/i2c-core-base.c | 6 +----- > > drivers/i2c/i2c-slave-eeprom.c | 4 +--- > > drivers/i2c/i2c-slave-testunit.c | 3 +-- > > drivers/i2c/i2c-smbus.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- >=20 > Reviewed-by: Jean Delvare Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gut2agzhpaayxotv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLEFBwACgkQwfwUeK3K 7AkavggAgLmynakXX/rOF4Jwy2OuBXH29kecKqPd6xj4yHsu3ggy8kd/hlU4jJib vV0H9ioq69hhMqjme5AHJJsueLFi/t/iwuQwuWUKluCBBlx0RXBsVx8qxV7A0uWa mdKU3ApPaN7y0cS1jccdN7ydsL3H2ayzIwfQuNqx1G3P/uqXfkusV0fjwQ/rQct3 qs4t2/QiHUd0tStlGw2eSKxp1z5KRrDMstK17fiZSsw/SYoMyldV8Ame6+gaxx0X e93FqM5jj67ovjD3jJanfOwI5vesu4+szu4GK6vHRWvpsieHsSeyS+GNgfM5oLA7 iguZ0rauzy0je3hrHuKgp1maJ59ibQ== =fYiS -----END PGP SIGNATURE----- --gut2agzhpaayxotv-- --===============6466679513976252955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6466679513976252955==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F0FECCA47B for ; Tue, 5 Jul 2022 12:00:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5F9CB16EC; Tue, 5 Jul 2022 13:59:20 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5F9CB16EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1657022410; bh=95LY5+qJGtghE+KPUxRvTlrikxpyhWepoRD0B1kqI0M=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oIKLIssviwlwoZziTo8hz3qC1/TqBg4y0vx7DsCrpljpgJGjXmeIsCCjSwvRWbqBM QJAunyF2nNeP6BZjrg6q1GP5BmHbGjoz4+Ck2sE53Gte/mzcYGllqSA0Ha2Pj/uNd2 bwiym5/XQTjgW+t2XkkfhOZ71pdz+L0aGEWycgt4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 03E16F80515; Tue, 5 Jul 2022 13:58:48 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 830D9F8015B; Tue, 5 Jul 2022 12:36:41 +0200 (CEST) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id C646AF8012A for ; Tue, 5 Jul 2022 12:36:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz C646AF8012A Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8fuq-0001LC-19; Tue, 05 Jul 2022 12:36:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8fue-004XxA-J7; Tue, 05 Jul 2022 12:36:16 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8fuh-0038F6-8t; Tue, 05 Jul 2022 12:36:15 +0200 Date: Tue, 5 Jul 2022 12:36:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jean Delvare Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705103615.ceeq7rku53x743ps@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <20220705120852.049dc235@endymion.delvare> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gut2agzhpaayxotv" Content-Disposition: inline In-Reply-To: <20220705120852.049dc235@endymion.delvare> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org X-Mailman-Approved-At: Tue, 05 Jul 2022 13:58:46 +0200 Cc: alsa-devel@alsa-project.org, linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Guenter Roeck , linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev, linux-staging@lists.linux.dev, kasan-dev@googlegroups.com, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, openipmi-developer@lists.sourceforge.net, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, patches@opensource.cirrus.com, linux-usb@vger.kernel.org, Wolfram Sang , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --gut2agzhpaayxotv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- >=20 > That's a huge change for a relatively small benefit, but if this is > approved by the I2C core maintainer then fine with me. For: Agreed, it's huge. The benefit isn't really measureable, the motivation is to improve the situation for driver authors who with the change cannot make wrong assumptions about what to return in .remove(). During the preparation this uncovered a few bugs. See for example bbc126ae381cf0a27822c1f822d0aeed74cc40d9. > > drivers/hwmon/adc128d818.c | 4 +--- > > drivers/hwmon/adt7470.c | 3 +-- > > drivers/hwmon/asb100.c | 6 ++---- > > drivers/hwmon/asc7621.c | 4 +--- > > drivers/hwmon/dme1737.c | 4 +--- > > drivers/hwmon/f75375s.c | 5 ++--- > > drivers/hwmon/fschmd.c | 6 ++---- > > drivers/hwmon/ftsteutates.c | 3 +-- > > drivers/hwmon/ina209.c | 4 +--- > > drivers/hwmon/ina3221.c | 4 +--- > > drivers/hwmon/jc42.c | 3 +-- > > drivers/hwmon/mcp3021.c | 4 +--- > > drivers/hwmon/occ/p8_i2c.c | 4 +--- > > drivers/hwmon/pcf8591.c | 3 +-- > > drivers/hwmon/smm665.c | 3 +-- > > drivers/hwmon/tps23861.c | 4 +--- > > drivers/hwmon/w83781d.c | 4 +--- > > drivers/hwmon/w83791d.c | 6 ++---- > > drivers/hwmon/w83792d.c | 6 ++---- > > drivers/hwmon/w83793.c | 6 ++---- > > drivers/hwmon/w83795.c | 4 +--- > > drivers/hwmon/w83l785ts.c | 6 ++---- > > drivers/i2c/i2c-core-base.c | 6 +----- > > drivers/i2c/i2c-slave-eeprom.c | 4 +--- > > drivers/i2c/i2c-slave-testunit.c | 3 +-- > > drivers/i2c/i2c-smbus.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- >=20 > Reviewed-by: Jean Delvare Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gut2agzhpaayxotv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLEFBwACgkQwfwUeK3K 7AkavggAgLmynakXX/rOF4Jwy2OuBXH29kecKqPd6xj4yHsu3ggy8kd/hlU4jJib vV0H9ioq69hhMqjme5AHJJsueLFi/t/iwuQwuWUKluCBBlx0RXBsVx8qxV7A0uWa mdKU3ApPaN7y0cS1jccdN7ydsL3H2ayzIwfQuNqx1G3P/uqXfkusV0fjwQ/rQct3 qs4t2/QiHUd0tStlGw2eSKxp1z5KRrDMstK17fiZSsw/SYoMyldV8Ame6+gaxx0X e93FqM5jj67ovjD3jJanfOwI5vesu4+szu4GK6vHRWvpsieHsSeyS+GNgfM5oLA7 iguZ0rauzy0je3hrHuKgp1maJ59ibQ== =fYiS -----END PGP SIGNATURE----- --gut2agzhpaayxotv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91981C433EF for ; Tue, 5 Jul 2022 10:37:04 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LcfHg166wz3c6Q for ; Tue, 5 Jul 2022 20:37:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=pengutronix.de (client-ip=2001:67c:670:201:290:27ff:fe1d:cc33; helo=metis.ext.pengutronix.de; envelope-from=ukl@pengutronix.de; receiver=) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LcfHC4c39z3059 for ; Tue, 5 Jul 2022 20:36:37 +1000 (AEST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8fuq-0001LC-19; Tue, 05 Jul 2022 12:36:24 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1o8fue-004XxA-J7; Tue, 05 Jul 2022 12:36:16 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1o8fuh-0038F6-8t; Tue, 05 Jul 2022 12:36:15 +0200 Date: Tue, 5 Jul 2022 12:36:15 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Jean Delvare Subject: Re: [PATCH 6/6] i2c: Make remove callback return void Message-ID: <20220705103615.ceeq7rku53x743ps@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> <20220705120852.049dc235@endymion.delvare> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gut2agzhpaayxotv" Content-Disposition: inline In-Reply-To: <20220705120852.049dc235@endymion.delvare> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linuxppc-dev@lists.ozlabs.org X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org, Guenter Roeck , linux-stm32@st-md-mailman.stormreply.com, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev, linux-staging@lists.linux.dev, kasan-dev@googlegroups.com, linux-clk@vger.kernel.org, linux-serial@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, openipmi-developer@lists.sourceforge.net, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, patches@opensource.cirrus.com, linux-usb@vger.kern el.org, Wolfram Sang , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" --gut2agzhpaayxotv Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2022 at 12:08:52PM +0200, Jean Delvare wrote: > On Tue, 28 Jun 2022 16:03:12 +0200, Uwe Kleine-K=F6nig wrote: > > From: Uwe Kleine-K=F6nig > >=20 > > The value returned by an i2c driver's remove function is mostly ignored. > > (Only an error message is printed if the value is non-zero that the > > error is ignored.) > >=20 > > So change the prototype of the remove function to return no value. This > > way driver authors are not tempted to assume that passing an error to > > the upper layer is a good idea. All drivers are adapted accordingly. > > There is no intended change of behaviour, all callbacks were prepared to > > return 0 before. > >=20 > > Signed-off-by: Uwe Kleine-K=F6nig > > --- >=20 > That's a huge change for a relatively small benefit, but if this is > approved by the I2C core maintainer then fine with me. For: Agreed, it's huge. The benefit isn't really measureable, the motivation is to improve the situation for driver authors who with the change cannot make wrong assumptions about what to return in .remove(). During the preparation this uncovered a few bugs. See for example bbc126ae381cf0a27822c1f822d0aeed74cc40d9. > > drivers/hwmon/adc128d818.c | 4 +--- > > drivers/hwmon/adt7470.c | 3 +-- > > drivers/hwmon/asb100.c | 6 ++---- > > drivers/hwmon/asc7621.c | 4 +--- > > drivers/hwmon/dme1737.c | 4 +--- > > drivers/hwmon/f75375s.c | 5 ++--- > > drivers/hwmon/fschmd.c | 6 ++---- > > drivers/hwmon/ftsteutates.c | 3 +-- > > drivers/hwmon/ina209.c | 4 +--- > > drivers/hwmon/ina3221.c | 4 +--- > > drivers/hwmon/jc42.c | 3 +-- > > drivers/hwmon/mcp3021.c | 4 +--- > > drivers/hwmon/occ/p8_i2c.c | 4 +--- > > drivers/hwmon/pcf8591.c | 3 +-- > > drivers/hwmon/smm665.c | 3 +-- > > drivers/hwmon/tps23861.c | 4 +--- > > drivers/hwmon/w83781d.c | 4 +--- > > drivers/hwmon/w83791d.c | 6 ++---- > > drivers/hwmon/w83792d.c | 6 ++---- > > drivers/hwmon/w83793.c | 6 ++---- > > drivers/hwmon/w83795.c | 4 +--- > > drivers/hwmon/w83l785ts.c | 6 ++---- > > drivers/i2c/i2c-core-base.c | 6 +----- > > drivers/i2c/i2c-slave-eeprom.c | 4 +--- > > drivers/i2c/i2c-slave-testunit.c | 3 +-- > > drivers/i2c/i2c-smbus.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +--- > > drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +-- > > drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +-- >=20 > Reviewed-by: Jean Delvare Thanks Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --gut2agzhpaayxotv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLEFBwACgkQwfwUeK3K 7AkavggAgLmynakXX/rOF4Jwy2OuBXH29kecKqPd6xj4yHsu3ggy8kd/hlU4jJib vV0H9ioq69hhMqjme5AHJJsueLFi/t/iwuQwuWUKluCBBlx0RXBsVx8qxV7A0uWa mdKU3ApPaN7y0cS1jccdN7ydsL3H2ayzIwfQuNqx1G3P/uqXfkusV0fjwQ/rQct3 qs4t2/QiHUd0tStlGw2eSKxp1z5KRrDMstK17fiZSsw/SYoMyldV8Ame6+gaxx0X e93FqM5jj67ovjD3jJanfOwI5vesu4+szu4GK6vHRWvpsieHsSeyS+GNgfM5oLA7 iguZ0rauzy0je3hrHuKgp1maJ59ibQ== =fYiS -----END PGP SIGNATURE----- --gut2agzhpaayxotv--