From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90606C433EF for ; Tue, 5 Jul 2022 14:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233050AbiGEOH5 (ORCPT ); Tue, 5 Jul 2022 10:07:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233148AbiGEOHa (ORCPT ); Tue, 5 Jul 2022 10:07:30 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19992E81; Tue, 5 Jul 2022 06:56:18 -0700 (PDT) Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id AED8166017ED; Tue, 5 Jul 2022 14:56:15 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657029377; bh=TrAckFq//mcfArH9T4vThAxiQUoSnKs/JzP+6HRCZCo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cWRpW2IoEkwH4IM3aQhOMvzPgqiZk/635M4nKqLmQ1bDU4L/Q9sn8RDFJWYDW0FMY Js0EzwlsM0laerEdKwDmOKkIDM/iEHW96bHQ8Mqg5xV07lUWLOqBLd36wHf7t4oXUD irDRDjaBo3Vl00X6WZMOFcV9zHvya5NJgq2FiKFfExXv4TNL5QQyGahFi644Jv7W8n 3PBnpmoDr+aWvowlQvNb43tIPdS53p17Zpt4q8nyrzsUdPbkUapqHJaYTrwHNf4v3I 4iKibbgULKsZ7OB2XOosakrxlmQXmpx420097rKLDNfC4DlRB82s1s3MBnDnbmxGrh Hwf9mubsPsFaw== Date: Tue, 5 Jul 2022 09:56:11 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Allen-KH Cheng , Fabien Parent , Hsin-Yi Wang , Krzysztof Kozlowski , Luca Weiss , Maxim Kutnij , Rob Herring , Sam Shih , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Message-ID: <20220705135611.jlfltaormhcpuutc@notapiano> References: <20220629155956.1138955-1-nfraprado@collabora.com> <20220701150145.2myyk2o3vxydyhql@notapiano> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 05, 2022 at 12:03:08PM +0800, Chen-Yu Tsai wrote: > On Fri, Jul 1, 2022 at 11:01 PM Nícolas F. R. A. Prado > wrote: > > > > On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote: > > > On Thu, Jun 30, 2022 at 12:00 AM Nícolas F. R. A. Prado > > > wrote: > > > > > > > > > > > > This series introduces Devicetrees for the MT8192-based Asurada platform > > > > as well as Asurada Spherion and Asurada Hayato boards. > > > > > > > > Support for the boards is added to the extent that is currently enabled > > > > in the mt8192.dtsi, and using only properties already merged in the > > > > dt-bindings, as to not add any dependencies to this series. > > > > > > > > This series was peer-reviewed internally before submission. > > > > > > > > Series tested on next-20220629. > > > > > > Just FYI I also got the internal display to work after some fixes to > > > the dtsi [1] and copying the stuff over from the ChromeOS kernel tree. > > > > > > It might be harder to enable the external display, given that we don't > > > have a good way of describing the weird design of using the DP bridge > > > also as a mux. See [2] for ongoing discussion. > > > > Hi ChenYu, > > > > I actually have both the internal and external display working on my local > > branch [1], but the commits there aren't final, and I'm also following the > > Type-C switch discussion to update my commits whenever the binding is settled > > on. > > I see. I think the internal display part is more or less final. It should > be worth including it, as it is a fairly visible indication that things > are working. Yeah, it is final, but not all of the display-related nodes in mt8192.dtsi have been merged yet [1] and I didn't want to introduce dependencies to the series. If that series gets merged before this one, I could add the display to this series as well, but I'm just worried that by introducing new commits with almost every new series version, this series might never get reviewed and merged, and this series is pretty big already. So I'd prefer to leave the display for a following series. Thanks, Nícolas [1] https://lore.kernel.org/all/20220701090547.21429-1-allen-kh.cheng@mediatek.com > > ChenYu > > > I noticed the lack of the mandatory display aliases in the mt8192 series but > > somehow missed mentioning that in the review, so thanks for adding that. > > > > Thanks, > > Nícolas > > > > [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asurada > > > > > > > > ChenYu > > > > > > [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=vV1NSk0AGRVYCa3Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/ > > > [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalani@chromium.org/ > > > > > > > v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@collabora.com/ > > > > v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@collabora.com/ > > > > v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@collabora.com/ > > > > > > > > Changes in v4: > > > > - Added patches 17-19 enabling MMC, SCP and SPI NOR flash > > > > - Switched mediatek,drive-strength-adv for drive-strength-microamp > > > > - Switched mediatek,pull-up-adv for bias-pull-up > > > > - Updated Vgpu minimum voltage to appropriate value > > > > > > > > Changes in v3: > > > > - Renamed regulator nodes to be generic > > > > - Fixed keyboard layout for Hayato > > > > > > > > Changes in v2: > > > > - Added patches 1-2 for Mediatek board dt-bindings > > > > - Added patches 13-16 enabling hardware for Asurada that has since been > > > > enabled on mt8192.dtsi > > > > > > > > Nícolas F. R. A. Prado (19): > > > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion > > > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato > > > > arm64: dts: mediatek: Introduce MT8192-based Asurada board family > > > > arm64: dts: mediatek: asurada: Document GPIO names > > > > arm64: dts: mediatek: asurada: Add system-wide power supplies > > > > arm64: dts: mediatek: asurada: Enable and configure I2C and SPI busses > > > > arm64: dts: mediatek: asurada: Add ChromeOS EC > > > > arm64: dts: mediatek: asurada: Add keyboard mapping for the top row > > > > arm64: dts: mediatek: asurada: Add Cr50 TPM > > > > arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad > > > > arm64: dts: mediatek: asurada: Add I2C touchscreen > > > > arm64: dts: mediatek: spherion: Add keyboard backlight > > > > arm64: dts: mediatek: asurada: Enable XHCI > > > > arm64: dts: mediatek: asurada: Enable PCIe and add WiFi > > > > arm64: dts: mediatek: asurada: Add MT6359 PMIC > > > > arm64: dts: mediatek: asurada: Add SPMI regulators > > > > arm64: dts: mediatek: asurada: Enable MMC > > > > arm64: dts: mediatek: asurada: Enable SCP > > > > arm64: dts: mediatek: asurada: Add SPI NOR flash memory > > > > > > > > .../devicetree/bindings/arm/mediatek.yaml | 13 + > > > > arch/arm64/boot/dts/mediatek/Makefile | 2 + > > > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 + > > > > .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++ > > > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++++++ > > > > 5 files changed, 1083 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hayato-r1.dts > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-spherion-r0.dts > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > > > > > > > -- > > > > 2.36.1 > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D75A5C433EF for ; Tue, 5 Jul 2022 13:57:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m7b9Y+sFPzm+fm9S240IkkF6W4BCFJPDzX//u5LvYZo=; b=rwXGHTr2cHwAQq XpEkviMLg/nIDqsO2vE8jvlu9uuI26FvhNK0h3HXftR6x6g74qPYGC40MxFY0aDk48r1MHi3YFInw dXhTslWpr/z87od4mdnEZ/1EfEOX4bt0FtOWvcFOveyGuFv8tSPZ05kCAh0s+BlQeibZP9Z//8/WO gqF1pEU43gZwuNf6QGNZ6zu4eULJg+s4nhZTYeSn+6aQeOmRwOzAq0VyXOP/NsFc5lQrvR2pkTArL 1Br80HMVpJP1ZpkXJsfHRFUJLTL+yDj2HhGel6NFFsKOC3jvkgiO5ekIOypsYupmKNMIKfFBiaFAG 8EV3BflIhsgZlgCAQKUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8j2O-000dWN-Im; Tue, 05 Jul 2022 13:56:24 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8j2K-000dUV-Rb; Tue, 05 Jul 2022 13:56:22 +0000 Received: from notapiano (pool-98-113-53-228.nycmny.fios.verizon.net [98.113.53.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id AED8166017ED; Tue, 5 Jul 2022 14:56:15 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1657029377; bh=TrAckFq//mcfArH9T4vThAxiQUoSnKs/JzP+6HRCZCo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cWRpW2IoEkwH4IM3aQhOMvzPgqiZk/635M4nKqLmQ1bDU4L/Q9sn8RDFJWYDW0FMY Js0EzwlsM0laerEdKwDmOKkIDM/iEHW96bHQ8Mqg5xV07lUWLOqBLd36wHf7t4oXUD irDRDjaBo3Vl00X6WZMOFcV9zHvya5NJgq2FiKFfExXv4TNL5QQyGahFi644Jv7W8n 3PBnpmoDr+aWvowlQvNb43tIPdS53p17Zpt4q8nyrzsUdPbkUapqHJaYTrwHNf4v3I 4iKibbgULKsZ7OB2XOosakrxlmQXmpx420097rKLDNfC4DlRB82s1s3MBnDnbmxGrh Hwf9mubsPsFaw== Date: Tue, 5 Jul 2022 09:56:11 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Chen-Yu Tsai Cc: Matthias Brugger , AngeloGioacchino Del Regno , kernel@collabora.com, Allen-KH Cheng , Fabien Parent , Hsin-Yi Wang , Krzysztof Kozlowski , Luca Weiss , Maxim Kutnij , Rob Herring , Sam Shih , Sean Wang , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 00/19] Introduce support for MediaTek MT8192 Google Chromebooks Message-ID: <20220705135611.jlfltaormhcpuutc@notapiano> References: <20220629155956.1138955-1-nfraprado@collabora.com> <20220701150145.2myyk2o3vxydyhql@notapiano> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_065621_223609_3EBFBFC3 X-CRM114-Status: GOOD ( 37.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 05, 2022 at 12:03:08PM +0800, Chen-Yu Tsai wrote: > On Fri, Jul 1, 2022 at 11:01 PM N=EDcolas F. R. A. Prado > wrote: > > > > On Fri, Jul 01, 2022 at 08:44:53PM +0800, Chen-Yu Tsai wrote: > > > On Thu, Jun 30, 2022 at 12:00 AM N=EDcolas F. R. A. Prado > > > wrote: > > > > > > > > > > > > This series introduces Devicetrees for the MT8192-based Asurada pla= tform > > > > as well as Asurada Spherion and Asurada Hayato boards. > > > > > > > > Support for the boards is added to the extent that is currently ena= bled > > > > in the mt8192.dtsi, and using only properties already merged in the > > > > dt-bindings, as to not add any dependencies to this series. > > > > > > > > This series was peer-reviewed internally before submission. > > > > > > > > Series tested on next-20220629. > > > > > > Just FYI I also got the internal display to work after some fixes to > > > the dtsi [1] and copying the stuff over from the ChromeOS kernel tree. > > > > > > It might be harder to enable the external display, given that we don't > > > have a good way of describing the weird design of using the DP bridge > > > also as a mux. See [2] for ongoing discussion. > > > > Hi ChenYu, > > > > I actually have both the internal and external display working on my lo= cal > > branch [1], but the commits there aren't final, and I'm also following = the > > Type-C switch discussion to update my commits whenever the binding is s= ettled > > on. > = > I see. I think the internal display part is more or less final. It should > be worth including it, as it is a fairly visible indication that things > are working. Yeah, it is final, but not all of the display-related nodes in mt8192.dtsi = have been merged yet [1] and I didn't want to introduce dependencies to the seri= es. If that series gets merged before this one, I could add the display to this series as well, but I'm just worried that by introducing new commits with a= lmost every new series version, this series might never get reviewed and merged, = and this series is pretty big already. So I'd prefer to leave the display for a following series. Thanks, N=EDcolas [1] https://lore.kernel.org/all/20220701090547.21429-1-allen-kh.cheng@media= tek.com > = > ChenYu > = > > I noticed the lack of the mandatory display aliases in the mt8192 serie= s but > > somehow missed mentioning that in the review, so thanks for adding that. > > > > Thanks, > > N=EDcolas > > > > [1] https://gitlab.collabora.com/nfraprado/linux/-/commits/mt8192-asura= da > > > > > > > > ChenYu > > > > > > [1] https://lore.kernel.org/linux-mediatek/CAGXv+5F_Gi_=3DvV1NSk0AGRV= YCa3Q8+gBaE+nv3OJ1AKe2voOwg@mail.gmail.com/ > > > [2] https://lore.kernel.org/dri-devel/20220622173605.1168416-1-pmalan= i@chromium.org/ > > > > > > > v3: https://lore.kernel.org/all/20220512205602.158273-1-nfraprado@c= ollabora.com/ > > > > v2: https://lore.kernel.org/all/20220505194550.3094656-1-nfraprado@= collabora.com/ > > > > v1: https://lore.kernel.org/all/20220316151327.564214-1-nfraprado@c= ollabora.com/ > > > > > > > > Changes in v4: > > > > - Added patches 17-19 enabling MMC, SCP and SPI NOR flash > > > > - Switched mediatek,drive-strength-adv for drive-strength-microamp > > > > - Switched mediatek,pull-up-adv for bias-pull-up > > > > - Updated Vgpu minimum voltage to appropriate value > > > > > > > > Changes in v3: > > > > - Renamed regulator nodes to be generic > > > > - Fixed keyboard layout for Hayato > > > > > > > > Changes in v2: > > > > - Added patches 1-2 for Mediatek board dt-bindings > > > > - Added patches 13-16 enabling hardware for Asurada that has since = been > > > > enabled on mt8192.dtsi > > > > > > > > N=EDcolas F. R. A. Prado (19): > > > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-spherion > > > > dt-bindings: arm64: dts: mediatek: Add mt8192-asurada-hayato > > > > arm64: dts: mediatek: Introduce MT8192-based Asurada board family > > > > arm64: dts: mediatek: asurada: Document GPIO names > > > > arm64: dts: mediatek: asurada: Add system-wide power supplies > > > > arm64: dts: mediatek: asurada: Enable and configure I2C and SPI b= usses > > > > arm64: dts: mediatek: asurada: Add ChromeOS EC > > > > arm64: dts: mediatek: asurada: Add keyboard mapping for the top r= ow > > > > arm64: dts: mediatek: asurada: Add Cr50 TPM > > > > arm64: dts: mediatek: asurada: Add Elan eKTH3000 I2C trackpad > > > > arm64: dts: mediatek: asurada: Add I2C touchscreen > > > > arm64: dts: mediatek: spherion: Add keyboard backlight > > > > arm64: dts: mediatek: asurada: Enable XHCI > > > > arm64: dts: mediatek: asurada: Enable PCIe and add WiFi > > > > arm64: dts: mediatek: asurada: Add MT6359 PMIC > > > > arm64: dts: mediatek: asurada: Add SPMI regulators > > > > arm64: dts: mediatek: asurada: Enable MMC > > > > arm64: dts: mediatek: asurada: Enable SCP > > > > arm64: dts: mediatek: asurada: Add SPI NOR flash memory > > > > > > > > .../devicetree/bindings/arm/mediatek.yaml | 13 + > > > > arch/arm64/boot/dts/mediatek/Makefile | 2 + > > > > .../dts/mediatek/mt8192-asurada-hayato-r1.dts | 47 + > > > > .../mediatek/mt8192-asurada-spherion-r0.dts | 62 ++ > > > > .../boot/dts/mediatek/mt8192-asurada.dtsi | 959 ++++++++++++++= ++++ > > > > 5 files changed, 1083 insertions(+) > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-hay= ato-r1.dts > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada-sph= erion-r0.dts > > > > create mode 100644 arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi > > > > > > > > -- > > > > 2.36.1 > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel