From: Christoph Hellwig <hch@lst.de>
To: Nikolay Borisov <nborisov@suse.com>
Cc: Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, Boris Burkov <boris@bur.io>
Subject: Re: [PATCH 1/4] btrfs: simplify the pending I/O counting in struct compressed_bio
Date: Tue, 5 Jul 2022 19:17:11 +0200 [thread overview]
Message-ID: <20220705171711.GB15148@lst.de> (raw)
In-Reply-To: <47d3c2ee-e602-b6be-bd48-d6d913455a29@suse.com>
On Tue, Jul 05, 2022 at 05:40:22PM +0300, Nikolay Borisov wrote:
> nit: This slightly changes the semantics of the function because with the
> old code the bio could have been completed in submit_compressed_write iff
> there was an error during submission for one of the sub-bios. Whilst with
> this new code there is a chance even in the success case this happens (if
> the sub bios complete by the time we arrive at this code).
Yes.
> Generally that'd
> be very unlikely due to io latency and indeed this code becomes effective
> iff there is an error. Personally I'd like such changes to be called out
> explicitly in the change log or at least with a comment.
Ok, I can spell this out a little more explicitly.
next prev parent reply other threads:[~2022-07-05 17:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 16:01 fix read repair on compressed extents v2 Christoph Hellwig
2022-06-30 16:01 ` [PATCH 1/4] btrfs: simplify the pending I/O counting in struct compressed_bio Christoph Hellwig
2022-07-05 14:40 ` Nikolay Borisov
2022-07-05 17:17 ` Christoph Hellwig [this message]
2022-06-30 16:01 ` [PATCH 2/4] btrfs: pass a btrfs_bio to btrfs_repair_one_sector Christoph Hellwig
2022-06-30 16:01 ` [PATCH 3/4] btrfs: remove the start argument to check_data_csum Christoph Hellwig
2022-07-05 15:35 ` Nikolay Borisov
2022-07-05 17:18 ` Christoph Hellwig
2022-06-30 16:01 ` [PATCH 4/4] btrfs: fix repair of compressed extents Christoph Hellwig
2022-07-07 12:50 ` Nikolay Borisov
2022-07-07 13:30 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2022-06-23 5:53 fix read repair on " Christoph Hellwig
2022-06-23 5:53 ` [PATCH 1/4] btrfs: simplify the pending I/O counting in struct compressed_bio Christoph Hellwig
2022-06-29 23:42 ` Boris Burkov
2022-06-30 4:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220705171711.GB15148@lst.de \
--to=hch@lst.de \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.