All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Yu Zhao <yuzhao@google.com>
Subject: Re: [PATCH] maple_tree: Fix use of node for global range in mas_wr_spanning_store()
Date: Wed, 6 Jul 2022 14:08:20 +0000	[thread overview]
Message-ID: <20220706140814.hjf5d2hbfupd6kyp@revolver> (raw)
In-Reply-To: <20220705195535.a32ce0de9b45fe73eea72c82@linux-foundation.org>

* Andrew Morton <akpm@linux-foundation.org> [220705 22:55]:
> On Wed, 6 Jul 2022 02:05:37 +0000 Liam Howlett <liam.howlett@oracle.com> wrote:
> 
> > When writing a range with a NULL which expands to 0 - ULONG_MAX, don't
> > use a node to store this value.  Instead, call mas_new_root() which will
> > set the tree pointer to NULL and free all the nodes.
> > 
> > Fix a comment for the allocations in mas_wr_spanning_store().
> > 
> > Add mas_node_count_gfp() and use it to clean up mas_preallocate().
> > 
> > Clean up mas_preallocate() and ensure the ma_state is safe on return.
> > 
> > Update maple_tree.h to set alloc = NULL.
> 
> Cool.
> 
> How are we looking now?  Any known issues still being worked on?

Did you pick up "Subject: [PATCH] mm/mmap: Fix copy_vma() new_vma
check"?  I sent that yesterday as well.

I think we are in good shape.  There were two outstanding issues I had
and this patch plus the copy_vma() patch fixes both.

  reply	other threads:[~2022-07-06 14:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06  2:05 [PATCH] maple_tree: Fix use of node for global range in mas_wr_spanning_store() Liam Howlett
2022-07-06  2:55 ` Andrew Morton
2022-07-06 14:08   ` Liam Howlett [this message]
2022-07-08  4:37     ` Hugh Dickins
2022-07-09  1:09       ` Liam Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706140814.hjf5d2hbfupd6kyp@revolver \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.