* [PATCH v7 0/3] Add support for lan966x flexcom chip-select configuration
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
This patch series converts atmel-flexcom bindings into json-schema format.
Adds support for lan966x flexcom chip-select configurations and its
DT bindings.
v6 -> v7:
- Change filename to atmel,sama5d2-flexcom.yaml
- Add #address-cells, #size-cells to flexcom node - Fixed warnings.
v5 -> v6:
- Removed spi node from example as suggested by Rob and
also pattern properties(spi dt-bindings conversion to yaml patch is under review).
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
Once this is accepted, I will add back spi example through new patch.
v4 -> v5:
- Fix indentations of DT example.
- Fix dt-schema errors - removed minItems, maxItems for allOf:if:then
"reg" property as it is not required.
v3 -> v4:
- Fix dtschema errors.
- Add a condition to flexcom chip-selects configuration as chip-select
lines are optional.
v2 -> v3:
- changed IRQ flag in dt-bindings example.
- added reg property specific to lan66x which is missed in v2.
- used goto label for clk_disable in error cases.
v1 -> v2:
- minor fix in title of dt-bindings.
- Modified new dt properties usage in atmel,flexcom.yaml.
- Used GENMASK and macros for maximum allowed values.
- Use u32 values for flexcom chipselects instead of strings.
- disable clock in case of errors.
Kavyasree Kotagiri (3):
dt-bindings: mfd: Convert atmel-flexcom to json-schema
dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for
lan966x
mfd: atmel-flexcom: Add support for lan966x flexcom chip-select
configuration
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 137 ++++++++++++++++++
.../devicetree/bindings/mfd/atmel-flexcom.txt | 63 --------
drivers/mfd/atmel-flexcom.c | 94 +++++++++++-
3 files changed, 230 insertions(+), 64 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
--
2.25.1
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v7 0/3] Add support for lan966x flexcom chip-select configuration
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
This patch series converts atmel-flexcom bindings into json-schema format.
Adds support for lan966x flexcom chip-select configurations and its
DT bindings.
v6 -> v7:
- Change filename to atmel,sama5d2-flexcom.yaml
- Add #address-cells, #size-cells to flexcom node - Fixed warnings.
v5 -> v6:
- Removed spi node from example as suggested by Rob and
also pattern properties(spi dt-bindings conversion to yaml patch is under review).
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
Once this is accepted, I will add back spi example through new patch.
v4 -> v5:
- Fix indentations of DT example.
- Fix dt-schema errors - removed minItems, maxItems for allOf:if:then
"reg" property as it is not required.
v3 -> v4:
- Fix dtschema errors.
- Add a condition to flexcom chip-selects configuration as chip-select
lines are optional.
v2 -> v3:
- changed IRQ flag in dt-bindings example.
- added reg property specific to lan66x which is missed in v2.
- used goto label for clk_disable in error cases.
v1 -> v2:
- minor fix in title of dt-bindings.
- Modified new dt properties usage in atmel,flexcom.yaml.
- Used GENMASK and macros for maximum allowed values.
- Use u32 values for flexcom chipselects instead of strings.
- disable clock in case of errors.
Kavyasree Kotagiri (3):
dt-bindings: mfd: Convert atmel-flexcom to json-schema
dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for
lan966x
mfd: atmel-flexcom: Add support for lan966x flexcom chip-select
configuration
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 137 ++++++++++++++++++
.../devicetree/bindings/mfd/atmel-flexcom.txt | 63 --------
drivers/mfd/atmel-flexcom.c | 94 +++++++++++-
3 files changed, 230 insertions(+), 64 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
Convert the Atmel flexcom device tree bindings to json schema.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
v6 -> v7:
- Change filename to atmel,sama5d2-flexcom.yaml
- Add #address-cells, #size-cells to flexcom node - Fixed warnings.
v5 -> v6:
- Removed spi node from example as suggested by Rob and
also pattern properties(spi dt-bindings conversion to yaml patch is under review).
Once that is accepted, I will add back spi example through new patch.
v4 -> v5:
- Fixed indentations.
v3 -> v4:
- Corrected format of enum used for compatible string.
v2 -> v3:
- used enum for compatible string.
- changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
- fixed dtschema errors.
v1 -> v2:
- Fix title.
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
.../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
2 files changed, 74 insertions(+), 63 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
new file mode 100644
index 000000000000..864f490ffb83
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel Flexcom (Flexible Serial Communication Unit)
+
+maintainers:
+ - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
+
+description:
+ The Atmel Flexcom is just a wrapper which embeds a SPI controller,
+ an I2C controller and an USART. Only one function can be used at a
+ time and is chosen at boot time according to the device tree.
+
+properties:
+ compatible:
+ enum:
+ - atmel,sama5d2-flexcom
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges:
+ description:
+ One range for the full I/O register region. (including USART,
+ TWI and SPI registers).
+ items:
+ maxItems: 3
+
+ atmel,flexcom-mode:
+ description: |
+ Specifies the flexcom mode as follows:
+ 1: USART
+ 2: SPI
+ 3: I2C.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [1, 2, 3]
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+ - atmel,flexcom-mode
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ flx0: flexcom@f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <2>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
deleted file mode 100644
index 9d837535637b..000000000000
--- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
+++ /dev/null
@@ -1,63 +0,0 @@
-* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
-
-The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
-controller and an USART. Only one function can be used at a time and is chosen
-at boot time according to the device tree.
-
-Required properties:
-- compatible: Should be "atmel,sama5d2-flexcom"
-- reg: Should be the offset/length value for Flexcom dedicated
- I/O registers (without USART, TWI or SPI registers).
-- clocks: Should be the Flexcom peripheral clock from PMC.
-- #address-cells: Should be <1>
-- #size-cells: Should be <1>
-- ranges: Should be one range for the full I/O register region
- (including USART, TWI and SPI registers).
-- atmel,flexcom-mode: Should be one of the following values:
- - <1> for USART
- - <2> for SPI
- - <3> for I2C
-
-Required child:
-A single available child device of type matching the "atmel,flexcom-mode"
-property.
-
-The phandle provided by the clocks property of the child is the same as one for
-the Flexcom parent.
-
-For other properties, please refer to the documentations of the respective
-device:
-- ../serial/atmel-usart.txt
-- ../spi/spi_atmel.txt
-- ../i2c/i2c-at91.txt
-
-Example:
-
-flexcom@f8034000 {
- compatible = "atmel,sama5d2-flexcom";
- reg = <0xf8034000 0x200>;
- clocks = <&flx0_clk>;
- #address-cells = <1>;
- #size-cells = <1>;
- ranges = <0x0 0xf8034000 0x800>;
- atmel,flexcom-mode = <2>;
-
- spi@400 {
- compatible = "atmel,at91rm9200-spi";
- reg = <0x400 0x200>;
- interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flx0_default>;
- #address-cells = <1>;
- #size-cells = <0>;
- clocks = <&flx0_clk>;
- clock-names = "spi_clk";
- atmel,fifo-size = <32>;
-
- flash@0 {
- compatible = "atmel,at25f512b";
- reg = <0>;
- spi-max-frequency = <20000000>;
- };
- };
-};
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
Convert the Atmel flexcom device tree bindings to json schema.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
v6 -> v7:
- Change filename to atmel,sama5d2-flexcom.yaml
- Add #address-cells, #size-cells to flexcom node - Fixed warnings.
v5 -> v6:
- Removed spi node from example as suggested by Rob and
also pattern properties(spi dt-bindings conversion to yaml patch is under review).
Once that is accepted, I will add back spi example through new patch.
v4 -> v5:
- Fixed indentations.
v3 -> v4:
- Corrected format of enum used for compatible string.
v2 -> v3:
- used enum for compatible string.
- changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
- fixed dtschema errors.
v1 -> v2:
- Fix title.
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
.../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
2 files changed, 74 insertions(+), 63 deletions(-)
create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
new file mode 100644
index 000000000000..864f490ffb83
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Atmel Flexcom (Flexible Serial Communication Unit)
+
+maintainers:
+ - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
+
+description:
+ The Atmel Flexcom is just a wrapper which embeds a SPI controller,
+ an I2C controller and an USART. Only one function can be used at a
+ time and is chosen at boot time according to the device tree.
+
+properties:
+ compatible:
+ enum:
+ - atmel,sama5d2-flexcom
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 1
+
+ ranges:
+ description:
+ One range for the full I/O register region. (including USART,
+ TWI and SPI registers).
+ items:
+ maxItems: 3
+
+ atmel,flexcom-mode:
+ description: |
+ Specifies the flexcom mode as follows:
+ 1: USART
+ 2: SPI
+ 3: I2C.
+ $ref: /schemas/types.yaml#/definitions/uint32
+ enum: [1, 2, 3]
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - "#address-cells"
+ - "#size-cells"
+ - ranges
+ - atmel,flexcom-mode
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ flx0: flexcom@f8034000 {
+ compatible = "atmel,sama5d2-flexcom";
+ reg = <0xf8034000 0x200>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xf8034000 0x800>;
+ atmel,flexcom-mode = <2>;
+ };
+...
diff --git a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt b/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
deleted file mode 100644
index 9d837535637b..000000000000
--- a/Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
+++ /dev/null
@@ -1,63 +0,0 @@
-* Device tree bindings for Atmel Flexcom (Flexible Serial Communication Unit)
-
-The Atmel Flexcom is just a wrapper which embeds a SPI controller, an I2C
-controller and an USART. Only one function can be used at a time and is chosen
-at boot time according to the device tree.
-
-Required properties:
-- compatible: Should be "atmel,sama5d2-flexcom"
-- reg: Should be the offset/length value for Flexcom dedicated
- I/O registers (without USART, TWI or SPI registers).
-- clocks: Should be the Flexcom peripheral clock from PMC.
-- #address-cells: Should be <1>
-- #size-cells: Should be <1>
-- ranges: Should be one range for the full I/O register region
- (including USART, TWI and SPI registers).
-- atmel,flexcom-mode: Should be one of the following values:
- - <1> for USART
- - <2> for SPI
- - <3> for I2C
-
-Required child:
-A single available child device of type matching the "atmel,flexcom-mode"
-property.
-
-The phandle provided by the clocks property of the child is the same as one for
-the Flexcom parent.
-
-For other properties, please refer to the documentations of the respective
-device:
-- ../serial/atmel-usart.txt
-- ../spi/spi_atmel.txt
-- ../i2c/i2c-at91.txt
-
-Example:
-
-flexcom@f8034000 {
- compatible = "atmel,sama5d2-flexcom";
- reg = <0xf8034000 0x200>;
- clocks = <&flx0_clk>;
- #address-cells = <1>;
- #size-cells = <1>;
- ranges = <0x0 0xf8034000 0x800>;
- atmel,flexcom-mode = <2>;
-
- spi@400 {
- compatible = "atmel,at91rm9200-spi";
- reg = <0x400 0x200>;
- interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
- pinctrl-names = "default";
- pinctrl-0 = <&pinctrl_flx0_default>;
- #address-cells = <1>;
- #size-cells = <0>;
- clocks = <&flx0_clk>;
- clock-names = "spi_clk";
- atmel,fifo-size = <32>;
-
- flash@0 {
- compatible = "atmel,at25f512b";
- reg = <0>;
- spi-max-frequency = <20000000>;
- };
- };
-};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
functions being configured.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
v6 -> v7:
- Add #address-cells, #size-cells to flx3 example.
v5 -> v6:
- Removed spi node from flx3 example.
v4 -> v5:
- Fixed indentations and dt-schema errors.
- No errors seen with 'make dt_binding_check'.
v3 -> v4:
- Added else condition to allOf:if:then.
v2 -> v3:
- Add reg property of lan966x missed in v2.
v1 -> v2:
- Use allOf:if:then for lan966x dt properties
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 65 ++++++++++++++++++-
1 file changed, 64 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
index 864f490ffb83..b4b47accab49 100644
--- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
+++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
@@ -18,9 +18,11 @@ properties:
compatible:
enum:
- atmel,sama5d2-flexcom
+ - microchip,lan966x-flexcom
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
clocks:
maxItems: 1
@@ -47,6 +49,27 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
enum: [1, 2, 3]
+ microchip,flx-shrd-pins:
+ description: Specify the Flexcom shared pins to be used for flexcom
+ chip-selects.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 0
+ maximum: 20
+
+ microchip,flx-cs:
+ description: Flexcom chip selects. Here, value of '0' represents "cts" line
+ of flexcom USART or "cs0" line of flexcom SPI and value of '1' represents
+ "rts" line of flexcom USART or "cs1" line of flexcom SPI.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 0
+ maximum: 1
+
required:
- compatible
- reg
@@ -56,6 +79,31 @@ required:
- ranges
- atmel,flexcom-mode
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: microchip,lan966x-flexcom
+
+ then:
+ properties:
+ reg:
+ items:
+ - description: Flexcom base registers map
+ - description: Flexcom shared registers map
+ required:
+ - microchip,flx-shrd-pins
+ - microchip,flx-cs
+
+ else:
+ properties:
+ reg:
+ items:
+ - description: Flexcom base registers map
+ microchip,flx-shrd-pins: false
+ microchip,flx-cs: false
+
additionalProperties: false
examples:
@@ -71,4 +119,19 @@ examples:
ranges = <0x0 0xf8034000 0x800>;
atmel,flexcom-mode = <2>;
};
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ flx3: flexcom@e0064000 {
+ compatible = "microchip,lan966x-flexcom";
+ reg = <0xe0064000 0x100>,
+ <0xe2004180 0x8>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xe0040000 0x800>;
+ atmel,flexcom-mode = <2>;
+ microchip,flx-shrd-pins = <9>;
+ microchip,flx-cs = <0>;
+ };
...
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
functions being configured.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
---
v6 -> v7:
- Add #address-cells, #size-cells to flx3 example.
v5 -> v6:
- Removed spi node from flx3 example.
v4 -> v5:
- Fixed indentations and dt-schema errors.
- No errors seen with 'make dt_binding_check'.
v3 -> v4:
- Added else condition to allOf:if:then.
v2 -> v3:
- Add reg property of lan966x missed in v2.
v1 -> v2:
- Use allOf:if:then for lan966x dt properties
.../bindings/mfd/atmel,sama5d2-flexcom.yaml | 65 ++++++++++++++++++-
1 file changed, 64 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
index 864f490ffb83..b4b47accab49 100644
--- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
+++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
@@ -18,9 +18,11 @@ properties:
compatible:
enum:
- atmel,sama5d2-flexcom
+ - microchip,lan966x-flexcom
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
clocks:
maxItems: 1
@@ -47,6 +49,27 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
enum: [1, 2, 3]
+ microchip,flx-shrd-pins:
+ description: Specify the Flexcom shared pins to be used for flexcom
+ chip-selects.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 0
+ maximum: 20
+
+ microchip,flx-cs:
+ description: Flexcom chip selects. Here, value of '0' represents "cts" line
+ of flexcom USART or "cs0" line of flexcom SPI and value of '1' represents
+ "rts" line of flexcom USART or "cs1" line of flexcom SPI.
+ $ref: /schemas/types.yaml#/definitions/uint32-array
+ minItems: 1
+ maxItems: 2
+ items:
+ minimum: 0
+ maximum: 1
+
required:
- compatible
- reg
@@ -56,6 +79,31 @@ required:
- ranges
- atmel,flexcom-mode
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: microchip,lan966x-flexcom
+
+ then:
+ properties:
+ reg:
+ items:
+ - description: Flexcom base registers map
+ - description: Flexcom shared registers map
+ required:
+ - microchip,flx-shrd-pins
+ - microchip,flx-cs
+
+ else:
+ properties:
+ reg:
+ items:
+ - description: Flexcom base registers map
+ microchip,flx-shrd-pins: false
+ microchip,flx-cs: false
+
additionalProperties: false
examples:
@@ -71,4 +119,19 @@ examples:
ranges = <0x0 0xf8034000 0x800>;
atmel,flexcom-mode = <2>;
};
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ flx3: flexcom@e0064000 {
+ compatible = "microchip,lan966x-flexcom";
+ reg = <0xe0064000 0x100>,
+ <0xe2004180 0x8>;
+ clocks = <&flx0_clk>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0xe0040000 0x800>;
+ atmel,flexcom-mode = <2>;
+ microchip,flx-shrd-pins = <9>;
+ microchip,flx-cs = <0>;
+ };
...
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v7 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
LAN966x SoC have 5 flexcoms. Each flexcom has 2 chip-selects
which are optional I/O lines. For each chip select of each
flexcom there is a configuration register FLEXCOM_SHARED[0-4]:SS_MASK[0-1].
The width of configuration register is 21 because there are
21 shared pins on each of which the chip select can be mapped.
Each bit of the register represents a different FLEXCOM_SHARED pin.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
v6 -> v7:
- No changes.
v5 -> v6:
- No changes.
v4 -> v5:
- No changes.
v3 -> v4:
- Add condition for a flexcom whether to configure chip-select lines
or not, based on "microchip,flx-shrd-pins" property existence because
chip-select lines are optional.
v2 -> v3:
- used goto label for clk_disable in error cases.
v1 -> v2:
- use GENMASK for mask, macros for maximum allowed values.
- use u32 values for flexcom chipselects instead of strings.
- disable clock in case of errors.
drivers/mfd/atmel-flexcom.c | 94 ++++++++++++++++++++++++++++++++++++-
1 file changed, 93 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 33caa4fba6af..430b6783b5a7 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -28,15 +28,68 @@
#define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \
FLEX_MR_OPMODE_MASK)
+/* LAN966x flexcom shared register offsets */
+#define FLEX_SHRD_SS_MASK_0 0x0
+#define FLEX_SHRD_SS_MASK_1 0x4
+#define FLEX_SHRD_PIN_MAX 20
+#define FLEX_CS_MAX 1
+#define FLEX_SHRD_MASK GENMASK(20, 0)
+
+struct atmel_flex_caps {
+ bool has_flx_cs;
+};
+
struct atmel_flexcom {
void __iomem *base;
+ void __iomem *flexcom_shared_base;
u32 opmode;
struct clk *clk;
};
+static int atmel_flexcom_lan966x_cs_config(struct platform_device *pdev)
+{
+ struct atmel_flexcom *ddata = dev_get_drvdata(&pdev->dev);
+ struct device_node *np = pdev->dev.of_node;
+ u32 flx_shrd_pins[2], flx_cs[2], val;
+ int err, i, count;
+
+ count = of_property_count_u32_elems(np, "microchip,flx-shrd-pins");
+ if (count <= 0 || count > 2) {
+ dev_err(&pdev->dev, "Invalid %s property (%d)\n", "flx-shrd-pins",
+ count);
+ return -EINVAL;
+ }
+
+ err = of_property_read_u32_array(np, "microchip,flx-shrd-pins", flx_shrd_pins, count);
+ if (err)
+ return err;
+
+ err = of_property_read_u32_array(np, "microchip,flx-cs", flx_cs, count);
+ if (err)
+ return err;
+
+ for (i = 0; i < count; i++) {
+ if (flx_shrd_pins[i] > FLEX_SHRD_PIN_MAX)
+ return -EINVAL;
+
+ if (flx_cs[i] > FLEX_CS_MAX)
+ return -EINVAL;
+
+ val = ~(1 << flx_shrd_pins[i]) & FLEX_SHRD_MASK;
+
+ if (flx_cs[i] == 0)
+ writel(val, ddata->flexcom_shared_base + FLEX_SHRD_SS_MASK_0);
+ else
+ writel(val, ddata->flexcom_shared_base + FLEX_SHRD_SS_MASK_1);
+ }
+
+ return 0;
+}
+
static int atmel_flexcom_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
+ const struct atmel_flex_caps *caps;
struct resource *res;
struct atmel_flexcom *ddata;
int err;
@@ -76,13 +129,52 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
*/
writel(FLEX_MR_OPMODE(ddata->opmode), ddata->base + FLEX_MR);
+ caps = of_device_get_match_data(&pdev->dev);
+ if (!caps) {
+ dev_err(&pdev->dev, "Could not retrieve flexcom caps\n");
+ err = -EINVAL;
+ goto clk_disable;
+ }
+
+ if (caps->has_flx_cs && of_property_read_bool(np, "microchip,flx-shrd-pins")) {
+ ddata->flexcom_shared_base = devm_platform_get_and_ioremap_resource(pdev, 1, NULL);
+ if (IS_ERR(ddata->flexcom_shared_base)) {
+ err = dev_err_probe(&pdev->dev,
+ PTR_ERR(ddata->flexcom_shared_base),
+ "failed to get flexcom shared base address\n");
+ goto clk_disable;
+ }
+
+ err = atmel_flexcom_lan966x_cs_config(pdev);
+ if (err)
+ goto clk_disable;
+ }
+
+clk_disable:
clk_disable_unprepare(ddata->clk);
+ if (err)
+ return err;
return devm_of_platform_populate(&pdev->dev);
}
+static const struct atmel_flex_caps atmel_flexcom_caps = {};
+
+static const struct atmel_flex_caps lan966x_flexcom_caps = {
+ .has_flx_cs = true,
+};
+
static const struct of_device_id atmel_flexcom_of_match[] = {
- { .compatible = "atmel,sama5d2-flexcom" },
+ {
+ .compatible = "atmel,sama5d2-flexcom",
+ .data = &atmel_flexcom_caps,
+ },
+
+ {
+ .compatible = "microchip,lan966x-flexcom",
+ .data = &lan966x_flexcom_caps,
+ },
+
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v7 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration
@ 2022-07-06 11:06 ` Kavyasree Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree Kotagiri @ 2022-07-06 11:06 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, nicolas.ferre,
alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel, Kavyasree.Kotagiri
LAN966x SoC have 5 flexcoms. Each flexcom has 2 chip-selects
which are optional I/O lines. For each chip select of each
flexcom there is a configuration register FLEXCOM_SHARED[0-4]:SS_MASK[0-1].
The width of configuration register is 21 because there are
21 shared pins on each of which the chip select can be mapped.
Each bit of the register represents a different FLEXCOM_SHARED pin.
Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
v6 -> v7:
- No changes.
v5 -> v6:
- No changes.
v4 -> v5:
- No changes.
v3 -> v4:
- Add condition for a flexcom whether to configure chip-select lines
or not, based on "microchip,flx-shrd-pins" property existence because
chip-select lines are optional.
v2 -> v3:
- used goto label for clk_disable in error cases.
v1 -> v2:
- use GENMASK for mask, macros for maximum allowed values.
- use u32 values for flexcom chipselects instead of strings.
- disable clock in case of errors.
drivers/mfd/atmel-flexcom.c | 94 ++++++++++++++++++++++++++++++++++++-
1 file changed, 93 insertions(+), 1 deletion(-)
diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 33caa4fba6af..430b6783b5a7 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -28,15 +28,68 @@
#define FLEX_MR_OPMODE(opmode) (((opmode) << FLEX_MR_OPMODE_OFFSET) & \
FLEX_MR_OPMODE_MASK)
+/* LAN966x flexcom shared register offsets */
+#define FLEX_SHRD_SS_MASK_0 0x0
+#define FLEX_SHRD_SS_MASK_1 0x4
+#define FLEX_SHRD_PIN_MAX 20
+#define FLEX_CS_MAX 1
+#define FLEX_SHRD_MASK GENMASK(20, 0)
+
+struct atmel_flex_caps {
+ bool has_flx_cs;
+};
+
struct atmel_flexcom {
void __iomem *base;
+ void __iomem *flexcom_shared_base;
u32 opmode;
struct clk *clk;
};
+static int atmel_flexcom_lan966x_cs_config(struct platform_device *pdev)
+{
+ struct atmel_flexcom *ddata = dev_get_drvdata(&pdev->dev);
+ struct device_node *np = pdev->dev.of_node;
+ u32 flx_shrd_pins[2], flx_cs[2], val;
+ int err, i, count;
+
+ count = of_property_count_u32_elems(np, "microchip,flx-shrd-pins");
+ if (count <= 0 || count > 2) {
+ dev_err(&pdev->dev, "Invalid %s property (%d)\n", "flx-shrd-pins",
+ count);
+ return -EINVAL;
+ }
+
+ err = of_property_read_u32_array(np, "microchip,flx-shrd-pins", flx_shrd_pins, count);
+ if (err)
+ return err;
+
+ err = of_property_read_u32_array(np, "microchip,flx-cs", flx_cs, count);
+ if (err)
+ return err;
+
+ for (i = 0; i < count; i++) {
+ if (flx_shrd_pins[i] > FLEX_SHRD_PIN_MAX)
+ return -EINVAL;
+
+ if (flx_cs[i] > FLEX_CS_MAX)
+ return -EINVAL;
+
+ val = ~(1 << flx_shrd_pins[i]) & FLEX_SHRD_MASK;
+
+ if (flx_cs[i] == 0)
+ writel(val, ddata->flexcom_shared_base + FLEX_SHRD_SS_MASK_0);
+ else
+ writel(val, ddata->flexcom_shared_base + FLEX_SHRD_SS_MASK_1);
+ }
+
+ return 0;
+}
+
static int atmel_flexcom_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
+ const struct atmel_flex_caps *caps;
struct resource *res;
struct atmel_flexcom *ddata;
int err;
@@ -76,13 +129,52 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
*/
writel(FLEX_MR_OPMODE(ddata->opmode), ddata->base + FLEX_MR);
+ caps = of_device_get_match_data(&pdev->dev);
+ if (!caps) {
+ dev_err(&pdev->dev, "Could not retrieve flexcom caps\n");
+ err = -EINVAL;
+ goto clk_disable;
+ }
+
+ if (caps->has_flx_cs && of_property_read_bool(np, "microchip,flx-shrd-pins")) {
+ ddata->flexcom_shared_base = devm_platform_get_and_ioremap_resource(pdev, 1, NULL);
+ if (IS_ERR(ddata->flexcom_shared_base)) {
+ err = dev_err_probe(&pdev->dev,
+ PTR_ERR(ddata->flexcom_shared_base),
+ "failed to get flexcom shared base address\n");
+ goto clk_disable;
+ }
+
+ err = atmel_flexcom_lan966x_cs_config(pdev);
+ if (err)
+ goto clk_disable;
+ }
+
+clk_disable:
clk_disable_unprepare(ddata->clk);
+ if (err)
+ return err;
return devm_of_platform_populate(&pdev->dev);
}
+static const struct atmel_flex_caps atmel_flexcom_caps = {};
+
+static const struct atmel_flex_caps lan966x_flexcom_caps = {
+ .has_flx_cs = true,
+};
+
static const struct of_device_id atmel_flexcom_of_match[] = {
- { .compatible = "atmel,sama5d2-flexcom" },
+ {
+ .compatible = "atmel,sama5d2-flexcom",
+ .data = &atmel_flexcom_caps,
+ },
+
+ {
+ .compatible = "microchip,lan966x-flexcom",
+ .data = &lan966x_flexcom_caps,
+ },
+
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, atmel_flexcom_of_match);
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 13:29 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-07-06 13:29 UTC (permalink / raw)
To: Kavyasree Kotagiri
Cc: nicolas.ferre, robh+dt, alexandre.belloni, linux-kernel,
Kavyasree.Kotagiri, UNGLinuxDriver, krzysztof.kozlowski+dt,
linux-arm-kernel, claudiu.beznea, devicetree
On Wed, 06 Jul 2022 09:06:17 -0200, Kavyasree Kotagiri wrote:
> Convert the Atmel flexcom device tree bindings to json schema.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Change filename to atmel,sama5d2-flexcom.yaml
> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>
> v5 -> v6:
> - Removed spi node from example as suggested by Rob and
> also pattern properties(spi dt-bindings conversion to yaml patch is under review).
> Once that is accepted, I will add back spi example through new patch.
>
> v4 -> v5:
> - Fixed indentations.
>
> v3 -> v4:
> - Corrected format of enum used for compatible string.
>
> v2 -> v3:
> - used enum for compatible string.
> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> - fixed dtschema errors.
>
> v1 -> v2:
> - Fix title.
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> 2 files changed, 74 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
flexcom@e0040000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0044000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0060000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0064000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0070000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e1818000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e181c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e1824000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2018000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2024000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2818000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e281c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2824000: 'spi@400' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@f0000000: 'spi@400' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f0004000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f8010000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f801c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f8034000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@f8038000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc010000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc014000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc018000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-06 13:29 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-07-06 13:29 UTC (permalink / raw)
To: Kavyasree Kotagiri
Cc: devicetree, alexandre.belloni, krzysztof.kozlowski+dt,
linux-kernel, UNGLinuxDriver, robh+dt, Kavyasree.Kotagiri,
claudiu.beznea, linux-arm-kernel
On Wed, 06 Jul 2022 09:06:17 -0200, Kavyasree Kotagiri wrote:
> Convert the Atmel flexcom device tree bindings to json schema.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Change filename to atmel,sama5d2-flexcom.yaml
> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>
> v5 -> v6:
> - Removed spi node from example as suggested by Rob and
> also pattern properties(spi dt-bindings conversion to yaml patch is under review).
> Once that is accepted, I will add back spi example through new patch.
>
> v4 -> v5:
> - Fixed indentations.
>
> v3 -> v4:
> - Corrected format of enum used for compatible string.
>
> v2 -> v3:
> - used enum for compatible string.
> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> - fixed dtschema errors.
>
> v1 -> v2:
> - Fix title.
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> 2 files changed, 74 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/
flexcom@e0040000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0044000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0060000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0064000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e0070000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
arch/arm/boot/dts/lan966x-pcb8291.dtb
flexcom@e1818000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e181c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e1824000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2018000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2024000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2818000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e281c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@e2824000: 'spi@400' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sama7g5ek.dtb
flexcom@f0000000: 'spi@400' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f0004000: 'serial@200' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f8010000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f801c000: 'i2c@600' does not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-sam9x60ek.dtb
flexcom@f8034000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@f8038000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc010000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc014000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
flexcom@fc018000: 'i2c@600', 'serial@200', 'spi@400' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm/boot/dts/at91-kizbox3-hs.dtb
arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
arch/arm/boot/dts/at91-sama5d2_icp.dtb
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
arch/arm/boot/dts/at91-sama5d2_xplained.dtb
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 14:43 ` Rob Herring
-1 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-07-06 14:43 UTC (permalink / raw)
To: Kavyasree Kotagiri
Cc: krzysztof.kozlowski+dt, nicolas.ferre, alexandre.belloni,
claudiu.beznea, UNGLinuxDriver, devicetree, linux-arm-kernel,
linux-kernel
On Wed, Jul 06, 2022 at 09:06:18AM -0200, Kavyasree Kotagiri wrote:
> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
> functions being configured.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Add #address-cells, #size-cells to flx3 example.
>
> v5 -> v6:
> - Removed spi node from flx3 example.
>
> v4 -> v5:
> - Fixed indentations and dt-schema errors.
> - No errors seen with 'make dt_binding_check'.
>
> v3 -> v4:
> - Added else condition to allOf:if:then.
>
> v2 -> v3:
> - Add reg property of lan966x missed in v2.
>
> v1 -> v2:
> - Use allOf:if:then for lan966x dt properties
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 65 ++++++++++++++++++-
> 1 file changed, 64 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> index 864f490ffb83..b4b47accab49 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> @@ -18,9 +18,11 @@ properties:
> compatible:
> enum:
> - atmel,sama5d2-flexcom
> + - microchip,lan966x-flexcom
Don't use wildcards in compatible strings.
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> clocks:
> maxItems: 1
> @@ -47,6 +49,27 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [1, 2, 3]
>
> + microchip,flx-shrd-pins:
> + description: Specify the Flexcom shared pins to be used for flexcom
> + chip-selects.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 0
> + maximum: 20
It's not clear how one uses this. It's selecting 2 pins, or a range of
pins, or ???
> +
> + microchip,flx-cs:
> + description: Flexcom chip selects. Here, value of '0' represents "cts" line
> + of flexcom USART or "cs0" line of flexcom SPI and value of '1' represents
> + "rts" line of flexcom USART or "cs1" line of flexcom SPI.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 0
> + maximum: 1
> +
> required:
> - compatible
> - reg
> @@ -56,6 +79,31 @@ required:
> - ranges
> - atmel,flexcom-mode
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,lan966x-flexcom
> +
> + then:
> + properties:
> + reg:
> + items:
> + - description: Flexcom base registers map
> + - description: Flexcom shared registers map
> + required:
> + - microchip,flx-shrd-pins
> + - microchip,flx-cs
> +
> + else:
> + properties:
> + reg:
> + items:
> + - description: Flexcom base registers map
> + microchip,flx-shrd-pins: false
> + microchip,flx-cs: false
> +
> additionalProperties: false
>
> examples:
> @@ -71,4 +119,19 @@ examples:
> ranges = <0x0 0xf8034000 0x800>;
> atmel,flexcom-mode = <2>;
> };
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + flx3: flexcom@e0064000 {
> + compatible = "microchip,lan966x-flexcom";
> + reg = <0xe0064000 0x100>,
> + <0xe2004180 0x8>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xe0040000 0x800>;
> + atmel,flexcom-mode = <2>;
> + microchip,flx-shrd-pins = <9>;
> + microchip,flx-cs = <0>;
> + };
> ...
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
@ 2022-07-06 14:43 ` Rob Herring
0 siblings, 0 replies; 24+ messages in thread
From: Rob Herring @ 2022-07-06 14:43 UTC (permalink / raw)
To: Kavyasree Kotagiri
Cc: devicetree, alexandre.belloni, linux-kernel, UNGLinuxDriver,
krzysztof.kozlowski+dt, claudiu.beznea, linux-arm-kernel
On Wed, Jul 06, 2022 at 09:06:18AM -0200, Kavyasree Kotagiri wrote:
> LAN966x SoC flexcoms has two optional I/O lines. Namely, CS0 and CS1
> in flexcom SPI mode. CTS and RTS in flexcom USART mode. These pins
> can be mapped to lan966x FLEXCOM_SHARED[0-20] pins and usage depends on
> functions being configured.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Add #address-cells, #size-cells to flx3 example.
>
> v5 -> v6:
> - Removed spi node from flx3 example.
>
> v4 -> v5:
> - Fixed indentations and dt-schema errors.
> - No errors seen with 'make dt_binding_check'.
>
> v3 -> v4:
> - Added else condition to allOf:if:then.
>
> v2 -> v3:
> - Add reg property of lan966x missed in v2.
>
> v1 -> v2:
> - Use allOf:if:then for lan966x dt properties
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 65 ++++++++++++++++++-
> 1 file changed, 64 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> index 864f490ffb83..b4b47accab49 100644
> --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> @@ -18,9 +18,11 @@ properties:
> compatible:
> enum:
> - atmel,sama5d2-flexcom
> + - microchip,lan966x-flexcom
Don't use wildcards in compatible strings.
>
> reg:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2
>
> clocks:
> maxItems: 1
> @@ -47,6 +49,27 @@ properties:
> $ref: /schemas/types.yaml#/definitions/uint32
> enum: [1, 2, 3]
>
> + microchip,flx-shrd-pins:
> + description: Specify the Flexcom shared pins to be used for flexcom
> + chip-selects.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 0
> + maximum: 20
It's not clear how one uses this. It's selecting 2 pins, or a range of
pins, or ???
> +
> + microchip,flx-cs:
> + description: Flexcom chip selects. Here, value of '0' represents "cts" line
> + of flexcom USART or "cs0" line of flexcom SPI and value of '1' represents
> + "rts" line of flexcom USART or "cs1" line of flexcom SPI.
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + minItems: 1
> + maxItems: 2
> + items:
> + minimum: 0
> + maximum: 1
> +
> required:
> - compatible
> - reg
> @@ -56,6 +79,31 @@ required:
> - ranges
> - atmel,flexcom-mode
>
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: microchip,lan966x-flexcom
> +
> + then:
> + properties:
> + reg:
> + items:
> + - description: Flexcom base registers map
> + - description: Flexcom shared registers map
> + required:
> + - microchip,flx-shrd-pins
> + - microchip,flx-cs
> +
> + else:
> + properties:
> + reg:
> + items:
> + - description: Flexcom base registers map
> + microchip,flx-shrd-pins: false
> + microchip,flx-cs: false
> +
> additionalProperties: false
>
> examples:
> @@ -71,4 +119,19 @@ examples:
> ranges = <0x0 0xf8034000 0x800>;
> atmel,flexcom-mode = <2>;
> };
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + flx3: flexcom@e0064000 {
> + compatible = "microchip,lan966x-flexcom";
> + reg = <0xe0064000 0x100>,
> + <0xe2004180 0x8>;
> + clocks = <&flx0_clk>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0xe0040000 0x800>;
> + atmel,flexcom-mode = <2>;
> + microchip,flx-shrd-pins = <9>;
> + microchip,flx-cs = <0>;
> + };
> ...
> --
> 2.25.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-06 11:06 ` Kavyasree Kotagiri
@ 2022-07-06 15:22 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-06 15:22 UTC (permalink / raw)
To: Kavyasree Kotagiri, robh+dt, krzysztof.kozlowski+dt,
nicolas.ferre, alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 06/07/2022 13:06, Kavyasree Kotagiri wrote:
> Convert the Atmel flexcom device tree bindings to json schema.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Change filename to atmel,sama5d2-flexcom.yaml
> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>
> v5 -> v6:
> - Removed spi node from example as suggested by Rob and
> also pattern properties(spi dt-bindings conversion to yaml patch is under review).
> Once that is accepted, I will add back spi example through new patch.
>
> v4 -> v5:
> - Fixed indentations.
>
> v3 -> v4:
> - Corrected format of enum used for compatible string.
>
> v2 -> v3:
> - used enum for compatible string.
> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> - fixed dtschema errors.
>
> v1 -> v2:
> - Fix title.
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> 2 files changed, 74 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> new file mode 100644
> index 000000000000..864f490ffb83
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +maintainers:
> + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> +
> +description:
> + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> + an I2C controller and an USART. Only one function can be used at a
> + time and is chosen at boot time according to the device tree.
> +
> +properties:
> + compatible:
> + enum:
> + - atmel,sama5d2-flexcom
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
> +
> + ranges:
> + description:
> + One range for the full I/O register region. (including USART,
> + TWI and SPI registers).
> + items:
> + maxItems: 3
> +
> + atmel,flexcom-mode:
> + description: |
> + Specifies the flexcom mode as follows:
> + 1: USART
> + 2: SPI
> + 3: I2C.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2, 3]
> +
As pointed out by Rob's bot - why do you not allow the protocol-specific
children here? spi, serial etc?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-06 15:22 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-06 15:22 UTC (permalink / raw)
To: Kavyasree Kotagiri, robh+dt, krzysztof.kozlowski+dt,
nicolas.ferre, alexandre.belloni, claudiu.beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 06/07/2022 13:06, Kavyasree Kotagiri wrote:
> Convert the Atmel flexcom device tree bindings to json schema.
>
> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> ---
> v6 -> v7:
> - Change filename to atmel,sama5d2-flexcom.yaml
> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>
> v5 -> v6:
> - Removed spi node from example as suggested by Rob and
> also pattern properties(spi dt-bindings conversion to yaml patch is under review).
> Once that is accepted, I will add back spi example through new patch.
>
> v4 -> v5:
> - Fixed indentations.
>
> v3 -> v4:
> - Corrected format of enum used for compatible string.
>
> v2 -> v3:
> - used enum for compatible string.
> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> - fixed dtschema errors.
>
> v1 -> v2:
> - Fix title.
>
> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74 +++++++++++++++++++
> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> 2 files changed, 74 insertions(+), 63 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> new file mode 100644
> index 000000000000..864f490ffb83
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> @@ -0,0 +1,74 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel Flexcom (Flexible Serial Communication Unit)
> +
> +maintainers:
> + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> +
> +description:
> + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> + an I2C controller and an USART. Only one function can be used at a
> + time and is chosen at boot time according to the device tree.
> +
> +properties:
> + compatible:
> + enum:
> + - atmel,sama5d2-flexcom
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 1
> +
> + ranges:
> + description:
> + One range for the full I/O register region. (including USART,
> + TWI and SPI registers).
> + items:
> + maxItems: 3
> +
> + atmel,flexcom-mode:
> + description: |
> + Specifies the flexcom mode as follows:
> + 1: USART
> + 2: SPI
> + 3: I2C.
> + $ref: /schemas/types.yaml#/definitions/uint32
> + enum: [1, 2, 3]
> +
As pointed out by Rob's bot - why do you not allow the protocol-specific
children here? spi, serial etc?
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-06 15:22 ` Krzysztof Kozlowski
@ 2022-07-07 5:29 ` Kavyasree.Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 5:29 UTC (permalink / raw)
To: krzysztof.kozlowski, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
> > Convert the Atmel flexcom device tree bindings to json schema.
> >
> > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > ---
> > v6 -> v7:
> > - Change filename to atmel,sama5d2-flexcom.yaml
> > - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> >
> > v5 -> v6:
> > - Removed spi node from example as suggested by Rob and
> > also pattern properties(spi dt-bindings conversion to yaml patch is under
> review).
> > Once that is accepted, I will add back spi example through new patch.
> >
> > v4 -> v5:
> > - Fixed indentations.
> >
> > v3 -> v4:
> > - Corrected format of enum used for compatible string.
> >
> > v2 -> v3:
> > - used enum for compatible string.
> > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > - fixed dtschema errors.
> >
> > v1 -> v2:
> > - Fix title.
> >
> > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
> +++++++++++++++++++
> > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> > 2 files changed, 74 insertions(+), 63 deletions(-)
> > create mode 100644
> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> flexcom.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml
> > new file mode 100644
> > index 000000000000..864f490ffb83
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Atmel Flexcom (Flexible Serial Communication Unit)
> > +
> > +maintainers:
> > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > +
> > +description:
> > + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> > + an I2C controller and an USART. Only one function can be used at a
> > + time and is chosen at boot time according to the device tree.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - atmel,sama5d2-flexcom
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 1
> > +
> > + ranges:
> > + description:
> > + One range for the full I/O register region. (including USART,
> > + TWI and SPI registers).
> > + items:
> > + maxItems: 3
> > +
> > + atmel,flexcom-mode:
> > + description: |
> > + Specifies the flexcom mode as follows:
> > + 1: USART
> > + 2: SPI
> > + 3: I2C.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [1, 2, 3]
> > +
>
> As pointed out by Rob's bot - why do you not allow the protocol-specific
> children here? spi, serial etc?
>
usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-07 5:29 ` Kavyasree.Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 5:29 UTC (permalink / raw)
To: krzysztof.kozlowski, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
> > Convert the Atmel flexcom device tree bindings to json schema.
> >
> > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > ---
> > v6 -> v7:
> > - Change filename to atmel,sama5d2-flexcom.yaml
> > - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> >
> > v5 -> v6:
> > - Removed spi node from example as suggested by Rob and
> > also pattern properties(spi dt-bindings conversion to yaml patch is under
> review).
> > Once that is accepted, I will add back spi example through new patch.
> >
> > v4 -> v5:
> > - Fixed indentations.
> >
> > v3 -> v4:
> > - Corrected format of enum used for compatible string.
> >
> > v2 -> v3:
> > - used enum for compatible string.
> > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > - fixed dtschema errors.
> >
> > v1 -> v2:
> > - Fix title.
> >
> > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
> +++++++++++++++++++
> > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> > 2 files changed, 74 insertions(+), 63 deletions(-)
> > create mode 100644
> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> flexcom.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml
> > new file mode 100644
> > index 000000000000..864f490ffb83
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> flexcom.yaml
> > @@ -0,0 +1,74 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Atmel Flexcom (Flexible Serial Communication Unit)
> > +
> > +maintainers:
> > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > +
> > +description:
> > + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> > + an I2C controller and an USART. Only one function can be used at a
> > + time and is chosen at boot time according to the device tree.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - atmel,sama5d2-flexcom
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 1
> > +
> > + ranges:
> > + description:
> > + One range for the full I/O register region. (including USART,
> > + TWI and SPI registers).
> > + items:
> > + maxItems: 3
> > +
> > + atmel,flexcom-mode:
> > + description: |
> > + Specifies the flexcom mode as follows:
> > + 1: USART
> > + 2: SPI
> > + 3: I2C.
> > + $ref: /schemas/types.yaml#/definitions/uint32
> > + enum: [1, 2, 3]
> > +
>
> As pointed out by Rob's bot - why do you not allow the protocol-specific
> children here? spi, serial etc?
>
usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-07 5:29 ` Kavyasree.Kotagiri
@ 2022-07-07 6:42 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:42 UTC (permalink / raw)
To: Kavyasree.Kotagiri, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 07/07/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote:
>>> Convert the Atmel flexcom device tree bindings to json schema.
>>>
>>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
>>> ---
>>> v6 -> v7:
>>> - Change filename to atmel,sama5d2-flexcom.yaml
>>> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>>>
>>> v5 -> v6:
>>> - Removed spi node from example as suggested by Rob and
>>> also pattern properties(spi dt-bindings conversion to yaml patch is under
>> review).
>>> Once that is accepted, I will add back spi example through new patch.
>>>
>>> v4 -> v5:
>>> - Fixed indentations.
>>>
>>> v3 -> v4:
>>> - Corrected format of enum used for compatible string.
>>>
>>> v2 -> v3:
>>> - used enum for compatible string.
>>> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
>>> - fixed dtschema errors.
>>>
>>> v1 -> v2:
>>> - Fix title.
>>>
>>> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
>> +++++++++++++++++++
>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
>>> 2 files changed, 74 insertions(+), 63 deletions(-)
>>> create mode 100644
>> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
>> flexcom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>>> new file mode 100644
>>> index 000000000000..864f490ffb83
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>>> @@ -0,0 +1,74 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Atmel Flexcom (Flexible Serial Communication Unit)
>>> +
>>> +maintainers:
>>> + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
>>> +
>>> +description:
>>> + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
>>> + an I2C controller and an USART. Only one function can be used at a
>>> + time and is chosen at boot time according to the device tree.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - atmel,sama5d2-flexcom
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 1
>>> +
>>> + ranges:
>>> + description:
>>> + One range for the full I/O register region. (including USART,
>>> + TWI and SPI registers).
>>> + items:
>>> + maxItems: 3
>>> +
>>> + atmel,flexcom-mode:
>>> + description: |
>>> + Specifies the flexcom mode as follows:
>>> + 1: USART
>>> + 2: SPI
>>> + 3: I2C.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + enum: [1, 2, 3]
>>> +
>>
>> As pointed out by Rob's bot - why do you not allow the protocol-specific
>> children here? spi, serial etc?
>>
> usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted:
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
No one talks about example. Your schema does not allow any child nodes
now, which is not correct. You must describe these children - even if
their schema is not ready. In such case just type:object, description
and maybe compatibles.
I don't understand why you cannot refer to them here.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-07 6:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:42 UTC (permalink / raw)
To: Kavyasree.Kotagiri, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 07/07/2022 07:29, Kavyasree.Kotagiri@microchip.com wrote:
>>> Convert the Atmel flexcom device tree bindings to json schema.
>>>
>>> Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
>>> ---
>>> v6 -> v7:
>>> - Change filename to atmel,sama5d2-flexcom.yaml
>>> - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
>>>
>>> v5 -> v6:
>>> - Removed spi node from example as suggested by Rob and
>>> also pattern properties(spi dt-bindings conversion to yaml patch is under
>> review).
>>> Once that is accepted, I will add back spi example through new patch.
>>>
>>> v4 -> v5:
>>> - Fixed indentations.
>>>
>>> v3 -> v4:
>>> - Corrected format of enum used for compatible string.
>>>
>>> v2 -> v3:
>>> - used enum for compatible string.
>>> - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
>>> - fixed dtschema errors.
>>>
>>> v1 -> v2:
>>> - Fix title.
>>>
>>> .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
>> +++++++++++++++++++
>>> .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
>>> 2 files changed, 74 insertions(+), 63 deletions(-)
>>> create mode 100644
>> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>>> delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
>> flexcom.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>>> new file mode 100644
>>> index 000000000000..864f490ffb83
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
>> flexcom.yaml
>>> @@ -0,0 +1,74 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Atmel Flexcom (Flexible Serial Communication Unit)
>>> +
>>> +maintainers:
>>> + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
>>> +
>>> +description:
>>> + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
>>> + an I2C controller and an USART. Only one function can be used at a
>>> + time and is chosen at boot time according to the device tree.
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - atmel,sama5d2-flexcom
>>> +
>>> + reg:
>>> + maxItems: 1
>>> +
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 1
>>> +
>>> + ranges:
>>> + description:
>>> + One range for the full I/O register region. (including USART,
>>> + TWI and SPI registers).
>>> + items:
>>> + maxItems: 3
>>> +
>>> + atmel,flexcom-mode:
>>> + description: |
>>> + Specifies the flexcom mode as follows:
>>> + 1: USART
>>> + 2: SPI
>>> + 3: I2C.
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + enum: [1, 2, 3]
>>> +
>>
>> As pointed out by Rob's bot - why do you not allow the protocol-specific
>> children here? spi, serial etc?
>>
> usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings conversion is under discussion. For now, I am removing child nodes from example. I will add it through new patch once below bindings are accepted:
> https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
No one talks about example. Your schema does not allow any child nodes
now, which is not correct. You must describe these children - even if
their schema is not ready. In such case just type:object, description
and maybe compatibles.
I don't understand why you cannot refer to them here.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-07 5:29 ` Kavyasree.Kotagiri
@ 2022-07-07 6:54 ` Kavyasree.Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 6:54 UTC (permalink / raw)
To: krzysztof.kozlowski, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
> > > Convert the Atmel flexcom device tree bindings to json schema.
> > >
> > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > > ---
> > > v6 -> v7:
> > > - Change filename to atmel,sama5d2-flexcom.yaml
> > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> > >
> > > v5 -> v6:
> > > - Removed spi node from example as suggested by Rob and
> > > also pattern properties(spi dt-bindings conversion to yaml patch is
> under
> > review).
> > > Once that is accepted, I will add back spi example through new patch.
> > >
> > > v4 -> v5:
> > > - Fixed indentations.
> > >
> > > v3 -> v4:
> > > - Corrected format of enum used for compatible string.
> > >
> > > v2 -> v3:
> > > - used enum for compatible string.
> > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > > - fixed dtschema errors.
> > >
> > > v1 -> v2:
> > > - Fix title.
> > >
> > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
> > +++++++++++++++++++
> > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> > > 2 files changed, 74 insertions(+), 63 deletions(-)
> > > create mode 100644
> > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > flexcom.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml
> > > new file mode 100644
> > > index 000000000000..864f490ffb83
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml
> > > @@ -0,0 +1,74 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Atmel Flexcom (Flexible Serial Communication Unit)
> > > +
> > > +maintainers:
> > > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > > +
> > > +description:
> > > + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> > > + an I2C controller and an USART. Only one function can be used at a
> > > + time and is chosen at boot time according to the device tree.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - atmel,sama5d2-flexcom
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 1
> > > +
> > > + ranges:
> > > + description:
> > > + One range for the full I/O register region. (including USART,
> > > + TWI and SPI registers).
> > > + items:
> > > + maxItems: 3
> > > +
> > > + atmel,flexcom-mode:
> > > + description: |
> > > + Specifies the flexcom mode as follows:
> > > + 1: USART
> > > + 2: SPI
> > > + 3: I2C.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + enum: [1, 2, 3]
> > > +
> >
> > As pointed out by Rob's bot - why do you not allow the protocol-specific
> > children here? spi, serial etc?
> >
> usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them
> here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings
> conversion is under discussion. For now, I am removing child nodes from
> example. I will add it through new patch once below bindings are accepted:
> https://patchwork.kernel.org/project/linux-arm-
> kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
>
Could you please tell if child nodes can be added as below?
-----------
+patternProperties:
+ "^serial@[0-9a-f]+$":
+ description: See atmel-usart.txt for details of USART bindings.
+ type: object
+
+ "^spi@[0-9a-f]+$":
+ description: See ../spi/spi_atmel.txt for details of SPI bindings.
+ type: object
+
+ "^i2c@[0-9a-f]+$":
+ description: See ../i2c/i2c-at91.txt for details of I2C bindings.
+ type: object
-------------
> >
> > Best regards,
> > Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-07 6:54 ` Kavyasree.Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 6:54 UTC (permalink / raw)
To: krzysztof.kozlowski, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
> > > Convert the Atmel flexcom device tree bindings to json schema.
> > >
> > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > > ---
> > > v6 -> v7:
> > > - Change filename to atmel,sama5d2-flexcom.yaml
> > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> > >
> > > v5 -> v6:
> > > - Removed spi node from example as suggested by Rob and
> > > also pattern properties(spi dt-bindings conversion to yaml patch is
> under
> > review).
> > > Once that is accepted, I will add back spi example through new patch.
> > >
> > > v4 -> v5:
> > > - Fixed indentations.
> > >
> > > v3 -> v4:
> > > - Corrected format of enum used for compatible string.
> > >
> > > v2 -> v3:
> > > - used enum for compatible string.
> > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > > - fixed dtschema errors.
> > >
> > > v1 -> v2:
> > > - Fix title.
> > >
> > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 74
> > +++++++++++++++++++
> > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 ----------------
> > > 2 files changed, 74 insertions(+), 63 deletions(-)
> > > create mode 100644
> > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > flexcom.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml
> > > new file mode 100644
> > > index 000000000000..864f490ffb83
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-
> > flexcom.yaml
> > > @@ -0,0 +1,74 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mfd/atmel,sama5d2-flexcom.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Atmel Flexcom (Flexible Serial Communication Unit)
> > > +
> > > +maintainers:
> > > + - Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
> > > +
> > > +description:
> > > + The Atmel Flexcom is just a wrapper which embeds a SPI controller,
> > > + an I2C controller and an USART. Only one function can be used at a
> > > + time and is chosen at boot time according to the device tree.
> > > +
> > > +properties:
> > > + compatible:
> > > + enum:
> > > + - atmel,sama5d2-flexcom
> > > +
> > > + reg:
> > > + maxItems: 1
> > > +
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + "#address-cells":
> > > + const: 1
> > > +
> > > + "#size-cells":
> > > + const: 1
> > > +
> > > + ranges:
> > > + description:
> > > + One range for the full I/O register region. (including USART,
> > > + TWI and SPI registers).
> > > + items:
> > > + maxItems: 3
> > > +
> > > + atmel,flexcom-mode:
> > > + description: |
> > > + Specifies the flexcom mode as follows:
> > > + 1: USART
> > > + 2: SPI
> > > + 3: I2C.
> > > + $ref: /schemas/types.yaml#/definitions/uint32
> > > + enum: [1, 2, 3]
> > > +
> >
> > As pointed out by Rob's bot - why do you not allow the protocol-specific
> > children here? spi, serial etc?
> >
> usart/serial, spi and i2c dt-bindings are in .txt format. So, I cannot refer them
> here. Like I mentioned in v5 -> v6 changes description, spi dt-bindings
> conversion is under discussion. For now, I am removing child nodes from
> example. I will add it through new patch once below bindings are accepted:
> https://patchwork.kernel.org/project/linux-arm-
> kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
>
Could you please tell if child nodes can be added as below?
-----------
+patternProperties:
+ "^serial@[0-9a-f]+$":
+ description: See atmel-usart.txt for details of USART bindings.
+ type: object
+
+ "^spi@[0-9a-f]+$":
+ description: See ../spi/spi_atmel.txt for details of SPI bindings.
+ type: object
+
+ "^i2c@[0-9a-f]+$":
+ description: See ../i2c/i2c-at91.txt for details of I2C bindings.
+ type: object
-------------
> >
> > Best regards,
> > Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
2022-07-07 6:54 ` Kavyasree.Kotagiri
@ 2022-07-07 6:57 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:57 UTC (permalink / raw)
To: Kavyasree.Kotagiri, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 07/07/2022 08:54, Kavyasree.Kotagiri@microchip.com wrote:
> Could you please tell if child nodes can be added as below?
> -----------
> +patternProperties:
> + "^serial@[0-9a-f]+$":
> + description: See atmel-usart.txt for details of USART bindings.
> + type: object
> +
> + "^spi@[0-9a-f]+$":
> + description: See ../spi/spi_atmel.txt for details of SPI bindings.
> + type: object
> +
> + "^i2c@[0-9a-f]+$":
> + description: See ../i2c/i2c-at91.txt for details of I2C bindings.
> + type: object
Yes, this is good.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema
@ 2022-07-07 6:57 ` Krzysztof Kozlowski
0 siblings, 0 replies; 24+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-07 6:57 UTC (permalink / raw)
To: Kavyasree.Kotagiri, robh+dt, krzysztof.kozlowski+dt,
Nicolas.Ferre, alexandre.belloni, Claudiu.Beznea, UNGLinuxDriver
Cc: devicetree, linux-arm-kernel, linux-kernel
On 07/07/2022 08:54, Kavyasree.Kotagiri@microchip.com wrote:
> Could you please tell if child nodes can be added as below?
> -----------
> +patternProperties:
> + "^serial@[0-9a-f]+$":
> + description: See atmel-usart.txt for details of USART bindings.
> + type: object
> +
> + "^spi@[0-9a-f]+$":
> + description: See ../spi/spi_atmel.txt for details of SPI bindings.
> + type: object
> +
> + "^i2c@[0-9a-f]+$":
> + description: See ../i2c/i2c-at91.txt for details of I2C bindings.
> + type: object
Yes, this is good.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
2022-07-06 14:43 ` Rob Herring
@ 2022-07-07 7:40 ` Kavyasree.Kotagiri
-1 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 7:40 UTC (permalink / raw)
To: robh
Cc: krzysztof.kozlowski+dt, Nicolas.Ferre, alexandre.belloni,
Claudiu.Beznea, UNGLinuxDriver, devicetree, linux-arm-kernel,
linux-kernel
> > @@ -18,9 +18,11 @@ properties:
> > compatible:
> > enum:
> > - atmel,sama5d2-flexcom
> > + - microchip,lan966x-flexcom
>
> Don't use wildcards in compatible strings.
>
Ok. I will change it.
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >
> > clocks:
> > maxItems: 1
> > @@ -47,6 +49,27 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [1, 2, 3]
> >
> > + microchip,flx-shrd-pins:
> > + description: Specify the Flexcom shared pins to be used for flexcom
> > + chip-selects.
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 0
> > + maximum: 20
>
> It's not clear how one uses this. It's selecting 2 pins, or a range of
> pins, or ???
>
I used minItems and maxItems to represent number of entries allowed. Either one shared pin
can be mapped or max of 2 based on pins mapped on board and 0-20 is allowed shared pin numbers.
> > +
> > + microchip,flx-cs:
> > + description: Flexcom chip selects. Here, value of '0' represents "cts" line
> > + of flexcom USART or "cs0" line of flexcom SPI and value of '1'
> represents
> > + "rts" line of flexcom USART or "cs1" line of flexcom SPI.
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 0
> > + maximum: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -56,6 +79,31 @@ required:
> > - ranges
> > - atmel,flexcom-mode
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: microchip,lan966x-flexcom
> > +
> > + then:
> > + properties:
> > + reg:
> > + items:
> > + - description: Flexcom base registers map
> > + - description: Flexcom shared registers map
> > + required:
> > + - microchip,flx-shrd-pins
> > + - microchip,flx-cs
> > +
> > + else:
> > + properties:
> > + reg:
> > + items:
> > + - description: Flexcom base registers map
> > + microchip,flx-shrd-pins: false
> > + microchip,flx-cs: false
> > +
> > additionalProperties: false
> >
> > examples:
> > @@ -71,4 +119,19 @@ examples:
> > ranges = <0x0 0xf8034000 0x800>;
> > atmel,flexcom-mode = <2>;
> > };
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + flx3: flexcom@e0064000 {
> > + compatible = "microchip,lan966x-flexcom";
> > + reg = <0xe0064000 0x100>,
> > + <0xe2004180 0x8>;
> > + clocks = <&flx0_clk>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x0 0xe0040000 0x800>;
> > + atmel,flexcom-mode = <2>;
> > + microchip,flx-shrd-pins = <9>;
> > + microchip,flx-cs = <0>;
> > + };
> > ...
> > --
> > 2.25.1
> >
> >
^ permalink raw reply [flat|nested] 24+ messages in thread
* RE: [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x
@ 2022-07-07 7:40 ` Kavyasree.Kotagiri
0 siblings, 0 replies; 24+ messages in thread
From: Kavyasree.Kotagiri @ 2022-07-07 7:40 UTC (permalink / raw)
To: robh
Cc: devicetree, alexandre.belloni, linux-kernel, UNGLinuxDriver,
krzysztof.kozlowski+dt, Claudiu.Beznea, linux-arm-kernel
> > @@ -18,9 +18,11 @@ properties:
> > compatible:
> > enum:
> > - atmel,sama5d2-flexcom
> > + - microchip,lan966x-flexcom
>
> Don't use wildcards in compatible strings.
>
Ok. I will change it.
> >
> > reg:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> >
> > clocks:
> > maxItems: 1
> > @@ -47,6 +49,27 @@ properties:
> > $ref: /schemas/types.yaml#/definitions/uint32
> > enum: [1, 2, 3]
> >
> > + microchip,flx-shrd-pins:
> > + description: Specify the Flexcom shared pins to be used for flexcom
> > + chip-selects.
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 0
> > + maximum: 20
>
> It's not clear how one uses this. It's selecting 2 pins, or a range of
> pins, or ???
>
I used minItems and maxItems to represent number of entries allowed. Either one shared pin
can be mapped or max of 2 based on pins mapped on board and 0-20 is allowed shared pin numbers.
> > +
> > + microchip,flx-cs:
> > + description: Flexcom chip selects. Here, value of '0' represents "cts" line
> > + of flexcom USART or "cs0" line of flexcom SPI and value of '1'
> represents
> > + "rts" line of flexcom USART or "cs1" line of flexcom SPI.
> > + $ref: /schemas/types.yaml#/definitions/uint32-array
> > + minItems: 1
> > + maxItems: 2
> > + items:
> > + minimum: 0
> > + maximum: 1
> > +
> > required:
> > - compatible
> > - reg
> > @@ -56,6 +79,31 @@ required:
> > - ranges
> > - atmel,flexcom-mode
> >
> > +allOf:
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + const: microchip,lan966x-flexcom
> > +
> > + then:
> > + properties:
> > + reg:
> > + items:
> > + - description: Flexcom base registers map
> > + - description: Flexcom shared registers map
> > + required:
> > + - microchip,flx-shrd-pins
> > + - microchip,flx-cs
> > +
> > + else:
> > + properties:
> > + reg:
> > + items:
> > + - description: Flexcom base registers map
> > + microchip,flx-shrd-pins: false
> > + microchip,flx-cs: false
> > +
> > additionalProperties: false
> >
> > examples:
> > @@ -71,4 +119,19 @@ examples:
> > ranges = <0x0 0xf8034000 0x800>;
> > atmel,flexcom-mode = <2>;
> > };
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + flx3: flexcom@e0064000 {
> > + compatible = "microchip,lan966x-flexcom";
> > + reg = <0xe0064000 0x100>,
> > + <0xe2004180 0x8>;
> > + clocks = <&flx0_clk>;
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + ranges = <0x0 0xe0040000 0x800>;
> > + atmel,flexcom-mode = <2>;
> > + microchip,flx-shrd-pins = <9>;
> > + microchip,flx-cs = <0>;
> > + };
> > ...
> > --
> > 2.25.1
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2022-07-07 7:41 UTC | newest]
Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 11:06 [PATCH v7 0/3] Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-07-06 11:06 ` Kavyasree Kotagiri
2022-07-06 11:06 ` [PATCH v7 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema Kavyasree Kotagiri
2022-07-06 11:06 ` Kavyasree Kotagiri
2022-07-06 13:29 ` Rob Herring
2022-07-06 13:29 ` Rob Herring
2022-07-06 15:22 ` Krzysztof Kozlowski
2022-07-06 15:22 ` Krzysztof Kozlowski
2022-07-07 5:29 ` Kavyasree.Kotagiri
2022-07-07 5:29 ` Kavyasree.Kotagiri
2022-07-07 6:42 ` Krzysztof Kozlowski
2022-07-07 6:42 ` Krzysztof Kozlowski
2022-07-07 6:54 ` Kavyasree.Kotagiri
2022-07-07 6:54 ` Kavyasree.Kotagiri
2022-07-07 6:57 ` Krzysztof Kozlowski
2022-07-07 6:57 ` Krzysztof Kozlowski
2022-07-06 11:06 ` [PATCH v7 2/3] dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for lan966x Kavyasree Kotagiri
2022-07-06 11:06 ` Kavyasree Kotagiri
2022-07-06 14:43 ` Rob Herring
2022-07-06 14:43 ` Rob Herring
2022-07-07 7:40 ` Kavyasree.Kotagiri
2022-07-07 7:40 ` Kavyasree.Kotagiri
2022-07-06 11:06 ` [PATCH v7 3/3] mfd: atmel-flexcom: Add support for lan966x flexcom chip-select configuration Kavyasree Kotagiri
2022-07-06 11:06 ` Kavyasree Kotagiri
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.