From: Rob Herring <robh@kernel.org>
To: "Pali Rohár" <pali@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding
Date: Wed, 6 Jul 2022 09:07:26 -0600 [thread overview]
Message-ID: <20220706150726.GA40600-robh@kernel.org> (raw)
In-Reply-To: <20220705001023.14660-1-pali@kernel.org>
On Tue, Jul 05, 2022 at 02:10:22AM +0200, Pali Rohár wrote:
> GPIO is optional and used for WDI logic.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> Changes in v3:
> * Extend description
> ---
> Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index ab9641e845db..a0cf9e6c371d 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -27,6 +27,10 @@ properties:
> description: This is a 1-byte memory-mapped address
> maxItems: 1
>
> + gpios:
As I said before, add a name prefix: wdi-gpios
> + description: Optional GPIO used for controlling WDI (watchdog input) when WDI bit is not mapped to memory
Wrap lines at 80 unless wrapping at 100 provides some benefit.
yamllint is set to 110 because I don't want to fix everyone's line wrap,
not because that's the standard.
> + maxItems: 1
> +
> required:
> - compatible
> - reg
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2022-07-06 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 0:10 [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding Pali Rohár
2022-07-05 0:10 ` [PATCH v3 2/2] watchdog: max63xx_wdt: Add support for specifying WDI logic via GPIO Pali Rohár
2022-07-06 15:07 ` Rob Herring [this message]
2022-07-07 12:27 ` [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding Pali Rohár
2022-07-12 18:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706150726.GA40600-robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=pali@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.