From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B3C0C433EF for ; Wed, 6 Jul 2022 15:23:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233240AbiGFPXl (ORCPT ); Wed, 6 Jul 2022 11:23:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232585AbiGFPXj (ORCPT ); Wed, 6 Jul 2022 11:23:39 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1A9914080 for ; Wed, 6 Jul 2022 08:23:37 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id g4so14297306pgc.1 for ; Wed, 06 Jul 2022 08:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=1DDTgoj1jp1g8suA37nuSuQrm4nVNe/H8nOJKr5Nvi0=; b=cFcexwjZOJ0fITRZd/D8GaW95trrWBANNl55bssV5aM9/OKNX017JVQrPg6Wlvbmil xwVnLGDg2MSVzCt4MR+suEzCDPAw7P3z2o7EFRnoLJrbZ9vMmnWPMDn7h68QlcQaJEIO C8RhjLmdHk7PXNA7/y26Ah1FQ3cUla4ByNKGPSNH7bVo2V9AbE0J5t9sM/qNb1XaT+Or CRbBVODKq0RMKCAXSIQmJIt4eBHkxnPPXIwroFmPCUr8SL+pvnGJNMskPPDICL9M8amq 1mh0vYvN6iqYrKD7l9VY+CwGR6XMMTGzJJ8LfbxBMNe+qZxBiBTRAB8FcxK9Apdec5d6 mkIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1DDTgoj1jp1g8suA37nuSuQrm4nVNe/H8nOJKr5Nvi0=; b=aYEHyTJSHt+9FtDLA0eehv+z++Xum036QmBptmApaoIc+ySfSVQAjgtheQQJ6LHP7F lcVNUYApx/Ro1xLK7Jb6G3RhyKnHfyyfd3EhjxuYiGXrWJFJ8gYnqT+jnWxWU1oQkXhT L3wSSwNhNR9eKGtT1MS9XQjr1HfjBPBPZ122ZEyJN6EOFir5eHaOIKRo/C21Y6HZqUvn nupk5GaZBodMrks/LpDSTbZv3wySRtZ/Ni2MDkUAO8hbb45SoNA3yDPylrS79vF/58au aSA2SAFmKjokmVdzMXRQvgd3pZ0mtL7XN41tFe79SUpN3q315BdCkYOtrtLOXE+vX7f5 LbRg== X-Gm-Message-State: AJIora9UPMRN6yeXadEOvvjx0RsNfrJ5Rf8mGPsdxUzgFLBQ61tHDVGh v25eSw9qY2dg9qeX9gj3AN2NVKh572BMLQ== X-Google-Smtp-Source: AGRyM1vOu+U4rg62/OuStTjMI5ZLfLyp3YhtznAcTClM8axaxY5pjzfYIkfoMkdXZ0zgh3TpSpD/Jg== X-Received: by 2002:a63:3807:0:b0:40c:73a7:b6cf with SMTP id f7-20020a633807000000b0040c73a7b6cfmr34203690pga.240.1657121017292; Wed, 06 Jul 2022 08:23:37 -0700 (PDT) Received: from localhost ([122.171.18.80]) by smtp.gmail.com with ESMTPSA id u13-20020a63454d000000b0040d2224ae04sm24176464pgk.76.2022.07.06.08.23.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 08:23:36 -0700 (PDT) Date: Wed, 6 Jul 2022 20:53:33 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM , Vincent Guittot , kernel test robot , Linux Kernel Mailing List Subject: Re: [PATCH V2 2/3] cpufreq: Panic if policy is active in cpufreq_policy_free() Message-ID: <20220706152333.fvgybznz3j6ffmre@vireshk-i7> References: <8c3d50faf8811e86136fb3f9c459e43fc3c50bc0.1653565641.git.viresh.kumar@linaro.org> <426bf6edc80b2e944d459fa7b8dffbe8b73bb3d9.1653623526.git.viresh.kumar@linaro.org> <20220615045957.55ocdyddcac3vwct@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06-07-22, 15:49, Rafael J. Wysocki wrote: > WARN_ON() would be somewhat better, but then I'm not sure if having a > full call trace in this case is really useful, because we know when > cpufreq_policy_free() can be called anyway. > > Maybe just print a warning message. The warning will get printed, yes, but I am sure everyone will end up ignoring it, once it happens. One of the benefits of printing the call-stack is people will take it seriously and report it, and we won't miss a bug, if one gets in somehow. -- viresh