All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy McDaniel <timothy.mcdaniel@intel.com>
To: timothy.mcdaniel@intel.com
Cc: dev@dpdk.org, jerinj@marvell.com, jerinjacobk@gmail.com, stable@dpdk.org
Subject: [PATCH v2 2/2] event/dlb2: improve cq_weight error messages
Date: Wed,  6 Jul 2022 16:46:28 -0500	[thread overview]
Message-ID: <20220706214628.2375117-3-timothy.mcdaniel@intel.com> (raw)
In-Reply-To: <20220706214628.2375117-1-timothy.mcdaniel@intel.com>

This commit changes 2 error messages to better
describe cq_weight related errors, should one occur.

Fixes: ffa46fc4a2b5 ("event/dlb2: support CQ weight")
Cc: stable@dpdk.org

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 drivers/event/dlb2/dlb2.c                  | 4 ++--
 drivers/event/dlb2/pf/base/dlb2_resource.c | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c
index 93bf215762..5a443acff8 100644
--- a/drivers/event/dlb2/dlb2.c
+++ b/drivers/event/dlb2/dlb2.c
@@ -1527,8 +1527,8 @@ dlb2_hw_create_ldb_port(struct dlb2_eventdev *dlb2,
 
 	if (dlb2->version == DLB2_HW_V2 && ev_port->cq_weight != 0 &&
 	    ev_port->cq_weight > dequeue_depth) {
-		DLB2_LOG_ERR("dlb2: invalid cq depth, must be >= cq weight%d\n",
-			     DLB2_MIN_ENQUEUE_DEPTH);
+		DLB2_LOG_ERR("dlb2: invalid cq dequeue depth %d, must be >= cq weight %d\n",
+			     dequeue_depth, ev_port->cq_weight);
 		return -EINVAL;
 	}
 
diff --git a/drivers/event/dlb2/pf/base/dlb2_resource.c b/drivers/event/dlb2/pf/base/dlb2_resource.c
index e73d289445..0731416a43 100644
--- a/drivers/event/dlb2/pf/base/dlb2_resource.c
+++ b/drivers/event/dlb2/pf/base/dlb2_resource.c
@@ -6397,6 +6397,9 @@ dlb2_verify_enable_cq_weight_args(struct dlb2_hw *hw,
 	struct dlb2_ldb_port *port;
 
 	if (hw->ver == DLB2_HW_V2) {
+		DLB2_HW_ERR(hw,
+			    "[%s():%d] CQ weight feature requires DLB 2.5 or later\n",
+			    __func__, __LINE__);
 		resp->status = DLB2_ST_FEATURE_UNAVAILABLE;
 		return -EINVAL;
 	}
-- 
2.25.1


  parent reply	other threads:[~2022-07-06 21:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 21:31 [PATCH 0/2] DLB2: cq_weight fixes Timothy McDaniel
2022-07-06 21:31 ` [PATCH 1/2] event/dlb2: fix cq_weight array overflow Timothy McDaniel
2022-07-06 21:46   ` [PATCH v2 0/2] DLB2: cq_weight fixes Timothy McDaniel
2022-07-06 21:46     ` [PATCH v2 1/2] event/dlb2: fix cq_weight array overflow Timothy McDaniel
2022-07-06 21:46     ` Timothy McDaniel [this message]
2022-07-08 14:26     ` [PATCH v2 0/2] DLB2: cq_weight fixes Thomas Monjalon
2022-07-08 15:02       ` McDaniel, Timothy
2022-07-11 20:30         ` Thomas Monjalon
2022-07-11 20:33           ` McDaniel, Timothy
2022-07-06 21:31 ` [PATCH 2/2] event/dlb2: improve cq_weight error messages Timothy McDaniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220706214628.2375117-3-timothy.mcdaniel@intel.com \
    --to=timothy.mcdaniel@intel.com \
    --cc=dev@dpdk.org \
    --cc=jerinj@marvell.com \
    --cc=jerinjacobk@gmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.