All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Nishanth Menon <nm@ti.com>
Cc: Robert Nelson <robertcnelson@gmail.com>,
	gadiyar@ti.com, Praneeth Bajjuri <praneeth@ti.com>,
	Jason Kridner <jkridner@gmail.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 3/3] board: ti: common: board_detect: Do 1byte address checks first.
Date: Wed, 6 Jul 2022 21:56:20 -0400	[thread overview]
Message-ID: <20220707015620.GX1146598@bill-the-cat> (raw)
In-Reply-To: <20220617182612.12575-4-nm@ti.com>

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

On Fri, Jun 17, 2022 at 01:26:12PM -0500, Nishanth Menon wrote:

> Do 1 byte address checks first prior to doing 2 byte address checks.
> When performing 2 byte addressing on 1 byte addressing eeprom, the
> second byte is taken in as a write operation and ends up erasing the
> eeprom region we want to preserve.
> 
> While we could have theoretically handled this by ensuring the write
> protect of the eeproms are properly managed, this is not true in case
> where board are updated with 1 byte eeproms to handle supply status.
> 
> Flipping the checks by checking for 1 byte addressing prior to 2 byte
> addressing check prevents this problem at the minor cost of additional
> overhead for boards with 2 byte addressing eeproms.
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/next, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

      parent reply	other threads:[~2022-07-07  1:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-17 18:26 [PATCH 0/3] board: ti: common: Fixups and optimizations for eeprom handling Nishanth Menon
2022-06-17 18:26 ` [PATCH 1/3] board: ti: common: Optimize boot when detecting consecutive bad records Nishanth Menon
2022-06-17 18:50   ` Tom Rini
2022-06-17 19:19     ` Nishanth Menon
2022-06-17 20:31       ` Tom Rini
2022-07-07  1:56   ` Tom Rini
2022-06-17 18:26 ` [PATCH 2/3] board: ti: common: Handle the legacy eeprom address width properly Nishanth Menon
2022-06-18 17:04   ` Tom Rini
2022-07-07  1:56   ` Tom Rini
2022-06-17 18:26 ` [PATCH 3/3] board: ti: common: board_detect: Do 1byte address checks first Nishanth Menon
2022-06-18 17:04   ` Tom Rini
2022-07-07  1:56   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220707015620.GX1146598@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=gadiyar@ti.com \
    --cc=jkridner@gmail.com \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.