From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E666C433EF for ; Thu, 7 Jul 2022 14:44:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235973AbiGGOoN (ORCPT ); Thu, 7 Jul 2022 10:44:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231753AbiGGOoK (ORCPT ); Thu, 7 Jul 2022 10:44:10 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C45431A80E; Thu, 7 Jul 2022 07:44:09 -0700 (PDT) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 267Ei1PI062809; Thu, 7 Jul 2022 09:44:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1657205041; bh=ABTgJp8tO2KpPdtj4JUN1lMd40vTDK073OIeD9rsd0w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=y8DjTDhUlMpIkN+GCnusjFwbQhN5dK9d5RFqEs0FzLvzGC1TpjtbWmvMJdPNODfXZ TFLoRI6PokmLxb+6TA43CBMD6c7MnYDq3qWsIFWmcNbCweZRLQE/XGJcAAUJtoJ7ja uPzg/v0Jag/vbmXsp67HwpKLKD8gCxImraJG+2BU= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 267Ei1eh042654 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jul 2022 09:44:01 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 7 Jul 2022 09:44:01 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 7 Jul 2022 09:44:00 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 267Ei0xf028702; Thu, 7 Jul 2022 09:44:00 -0500 Date: Thu, 7 Jul 2022 09:44:00 -0500 From: Bryan Brattlof To: Andrew Davis CC: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node Message-ID: <20220707144400.tk3wmpeijdhuxpzv@bryanbrattlof.com> References: <20220706190838.26074-1-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20220706190838.26074-1-afd@ti.com> X-PGP-Fingerprint: D3D1 77E4 0A38 DF4D 1853 FEEF 41B9 0D5D 71D5 6CE0 User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew On July 6, 2022 thus sayeth Andrew Davis: > The hardware random number generator is used by OP-TEE and is access is > denied to other users with SoC level bus firewalls. Any access to this > device from Linux will result in firewall errors. Disable this node. > > Signed-off-by: Andrew Davis > --- > > Changes from v1: > - Added comment in dtsi file > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index e749343accedd..9de5a8294acd6 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -127,6 +127,7 @@ rng: rng@4e10000 { > reg = <0x0 0x4e10000 0x0 0x7d>; > interrupts = ; > clocks = <&k3_clks 136 1>; > + status = "disabled"; /* Used by OP-TEE */ Just curious about how we should document disabling nodes. I was assuming the reasoning should be described in the bindings? I would like to start disabling nodes by default in our dtsi files and enabling them in our top dts file, making it easier for others to use our device tree for a more focused purpose than our dev boards. I just didn't know where I should document why I disabled the nodes :) ~Bryan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 110C3C43334 for ; Thu, 7 Jul 2022 14:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mlNAsFbGkRvKdf8IjuJTUGmDH6Aio+EQsWXp+/tsdQA=; b=eizYdzgstv3vPL QFZCdaOQjh4Jre7bu84rqW3DM6plDjPeLimrnMOEe3SpRztBJ3062ZObBEginTEbaInWWUO3e6GNh KNti3HCbcXGTaI2mqVPmYyoi/SWIb2uPg1YWaMEnEu5q+aHBUpSG028sCUzYXf7OX6AZWaW5Ng87c 7abwXq+t5PQSPYiWWS+Snadd94u9QLyXBnO9obZmmcmwPBlX7na0E8nkryJnZHSmxgIRTrF4Fhl7d SlNghRcme5NM4319qUoArUwh+wDDcolxMvJYeRzZLjWMinp1h2RXgI68mgk3ur16ag200nIGe2eC5 P+ZCKjjmWNiMgX3aixmQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Sji-00GYnw-Oq; Thu, 07 Jul 2022 14:44:10 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9Sjf-00GYlZ-Iu for linux-arm-kernel@lists.infradead.org; Thu, 07 Jul 2022 14:44:09 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 267Ei1PI062809; Thu, 7 Jul 2022 09:44:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1657205041; bh=ABTgJp8tO2KpPdtj4JUN1lMd40vTDK073OIeD9rsd0w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=y8DjTDhUlMpIkN+GCnusjFwbQhN5dK9d5RFqEs0FzLvzGC1TpjtbWmvMJdPNODfXZ TFLoRI6PokmLxb+6TA43CBMD6c7MnYDq3qWsIFWmcNbCweZRLQE/XGJcAAUJtoJ7ja uPzg/v0Jag/vbmXsp67HwpKLKD8gCxImraJG+2BU= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 267Ei1eh042654 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 7 Jul 2022 09:44:01 -0500 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 7 Jul 2022 09:44:01 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14 via Frontend Transport; Thu, 7 Jul 2022 09:44:00 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 267Ei0xf028702; Thu, 7 Jul 2022 09:44:00 -0500 Date: Thu, 7 Jul 2022 09:44:00 -0500 From: Bryan Brattlof To: Andrew Davis CC: Nishanth Menon , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , , Subject: Re: [PATCH v2 1/4] arm64: dts: ti: k3-am65-main: Disable RNG node Message-ID: <20220707144400.tk3wmpeijdhuxpzv@bryanbrattlof.com> References: <20220706190838.26074-1-afd@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220706190838.26074-1-afd@ti.com> X-PGP-Fingerprint: D3D1 77E4 0A38 DF4D 1853 FEEF 41B9 0D5D 71D5 6CE0 User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220707_074407_840877_A1AD4BF6 X-CRM114-Status: GOOD ( 17.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew On July 6, 2022 thus sayeth Andrew Davis: > The hardware random number generator is used by OP-TEE and is access is > denied to other users with SoC level bus firewalls. Any access to this > device from Linux will result in firewall errors. Disable this node. > > Signed-off-by: Andrew Davis > --- > > Changes from v1: > - Added comment in dtsi file > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index e749343accedd..9de5a8294acd6 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -127,6 +127,7 @@ rng: rng@4e10000 { > reg = <0x0 0x4e10000 0x0 0x7d>; > interrupts = ; > clocks = <&k3_clks 136 1>; > + status = "disabled"; /* Used by OP-TEE */ Just curious about how we should document disabling nodes. I was assuming the reasoning should be described in the bindings? I would like to start disabling nodes by default in our dtsi files and enabling them in our top dts file, making it easier for others to use our device tree for a more focused purpose than our dev boards. I just didn't know where I should document why I disabled the nodes :) ~Bryan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel