[PATCH v3 3/9] tests/style: check for mixups of bool constants with int variables

From: "Daniel P. Berrangé" <berrange@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Eric Blake" <eblake@redhat.com>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v3 3/9] tests/style: check for mixups of bool constants with int variables
Date: Thu,  7 Jul 2022 17:37:14 +0100	[thread overview]
Message-ID: <20220707163720.1421716-4-berrange@redhat.com> (raw)
In-Reply-To: <20220707163720.1421716-1-berrange@redhat.com>

The 'true' and 'false' constants should only ever be used with the
'bool' type, never 'int'.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tests/style.yml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/style.yml b/tests/style.yml
index b4e7c6111f..704227d8e9 100644
--- a/tests/style.yml
+++ b/tests/style.yml
@@ -86,3 +86,8 @@
 #        A match added to the front of the regex. Useful when
 #        'terms' is a list of strings and a common prefix is
 #        desired
+
+int_assign_bool:
+  files: \.c$
+  prohibit: \<int\>.*= *(true|false)\b
+  message: use bool type for boolean values
-- 
2.36.1


