From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BFCCC43334 for ; Fri, 8 Jul 2022 01:43:08 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D4D74069D; Fri, 8 Jul 2022 03:43:07 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 2AC8F40041 for ; Fri, 8 Jul 2022 03:43:04 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LfGGP2jCjzkXdZ; Fri, 8 Jul 2022 09:41:33 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 09:42:33 +0800 Received: from localhost.localdomain (10.28.79.22) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 8 Jul 2022 09:42:33 +0800 From: Huisong Li To: , , CC: , , , , Subject: [PATCH V2] app/testpmd: fix display types failure when query RSS rule Date: Fri, 8 Jul 2022 09:41:59 +0800 Message-ID: <20220708014159.13499-1-lihuisong@huawei.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20220707105044.10567-1-lihuisong@huawei.com> References: <20220707105044.10567-1-lihuisong@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.28.79.22] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Now testpmd fails to display types when query RSS rule. The failure is because the '\n' character is missing at the end of the function 'rss_config_display()'. Actually, all places calling 'xxx_types_display()' need to '\n'. So this patch moves '\n' to the inside of these function. Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") Fixes: 44a37f3cffe0 ("app/testpmd: compact RSS types output") --- v2: - move '\n' to the inside of 'xxx_types_display()'. Signed-off-by: Huisong Li --- app/test-pmd/config.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 608bec9796..a2939867c4 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -761,6 +761,7 @@ rss_offload_types_display(uint64_t offload_types, uint16_t char_num_per_line) total_len += str_len; } } + printf("\n"); } void @@ -870,7 +871,6 @@ port_infos_display(portid_t port_id) printf("Supported RSS offload flow types:\n"); rss_offload_types_display(dev_info.flow_type_rss_offloads, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE); - printf("\n"); } printf("Minimum size of RX buffer: %u\n", dev_info.min_rx_bufsize); @@ -1648,6 +1648,7 @@ rss_types_display(uint64_t rss_types, uint16_t char_num_per_line) total_len += str_len; } } + printf("\n"); } static void @@ -3924,7 +3925,6 @@ port_rss_hash_conf_show(portid_t port_id, int show_rss_key) } printf("RSS functions:\n"); rss_types_display(rss_hf, TESTPMD_RSS_TYPES_CHAR_NUM_PER_LINE); - printf("\n"); if (!show_rss_key) return; printf("RSS key:\n"); -- 2.22.0