From: Leo Yan <leo.yan@linaro.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values
Date: Fri, 8 Jul 2022 14:33:07 +0800 [thread overview]
Message-ID: <20220708063307.GB195591@leoy-ThinkPad-X240s> (raw)
In-Reply-To: <28bf991f-7b4c-0af1-2780-842500b01a0f@kernel.org>
On Thu, Jul 07, 2022 at 05:33:58PM +0300, Georgi Djakov wrote:
[...]
> > @@ -321,12 +365,11 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> > provider = src->provider;
> > qp = to_qcom_provider(provider);
> > - list_for_each_entry(n, &provider->nodes, node_list)
> > - provider->aggregate(n, 0, n->avg_bw, n->peak_bw,
> > - &agg_avg, &agg_peak);
> > + qcom_icc_bus_aggregate(provider, agg_avg, agg_peak, &max_agg_avg,
> > + &max_agg_peak);
> > - sum_bw = icc_units_to_bps(agg_avg);
> > - max_peak_bw = icc_units_to_bps(agg_peak);
> > + sum_bw = icc_units_to_bps(max_agg_avg);
> > + max_peak_bw = icc_units_to_bps(max_agg_peak);
> > ret = __qcom_icc_set(src, src_qn, sum_bw);
> > if (ret)
> > @@ -337,12 +380,23 @@ static int qcom_icc_set(struct icc_node *src, struct icc_node *dst)
> > return ret;
> > }
> > - rate = max(sum_bw, max_peak_bw);
>
> Looks like max_peak_bw is unused now?
Yes, will drop it in next spin.
Thanks for review.
Leo
next prev parent reply other threads:[~2022-07-08 6:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 7:23 [PATCH v4 0/5] interconnect: qcom: icc-rpm: Support bucket Leo Yan
2022-07-05 7:23 ` [PATCH v4 1/5] dt-bindings: interconnect: Update property for icc-rpm path tag Leo Yan
2022-07-05 9:49 ` Krzysztof Kozlowski
2022-07-05 7:23 ` [PATCH v4 2/5] interconnect: qcom: Move qcom_icc_xlate_extended() to a common file Leo Yan
2022-07-05 7:23 ` [PATCH v4 3/5] interconnect: qcom: icc-rpm: Change to use qcom_icc_xlate_extended() Leo Yan
2022-07-05 7:23 ` [PATCH v4 4/5] interconnect: qcom: icc-rpm: Support multiple buckets Leo Yan
2022-07-07 14:29 ` Georgi Djakov
2022-07-08 6:29 ` Leo Yan
2022-07-05 7:23 ` [PATCH v4 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Leo Yan
2022-07-07 14:33 ` Georgi Djakov
2022-07-08 6:33 ` Leo Yan [this message]
2022-07-05 14:03 ` [PATCH v4 0/5] interconnect: qcom: icc-rpm: Support bucket Georgi Djakov
2022-07-07 2:52 ` Leo Yan
2022-07-07 9:56 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708063307.GB195591@leoy-ThinkPad-X240s \
--to=leo.yan@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.