From: Steven Rostedt <rostedt@goodmis.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: "Subash Abhinov Kasiviswanathan (KS)" <quic_subashab@quicinc.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
quic_jzenner@quicinc.com, "Cong Wang ." <cong.wang@bytedance.com>,
Qitao Xu <qitao.xu@bytedance.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Sean Tranchetti <quic_stranche@quicinc.com>
Subject: Re: [PATCH net-next v2] net: Print hashed skb addresses for all net and qdisc events
Date: Fri, 8 Jul 2022 16:18:28 -0400 [thread overview]
Message-ID: <20220708161828.70d108f2@gandalf.local.home> (raw)
In-Reply-To: <CAM_iQpVXs5npkommaZzTTvoPKyjhpPL3ws5DtFGvG+_yYVX4dA@mail.gmail.com>
On Sat, 2 Jul 2022 21:36:19 -0700
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > Matching skbs addresses (in a particular format) helps to track the
> > packet traversal timings / delays in processing.
>
> So... how didn't you notice the duplicated addresses with hashed ones?
> It is 100% reproducible to see duplicates with hashed ones.
Yes the hashes are reproducible giving the same address for this exact
purpose (to match like addresses).
I'm not sure if your last sentence was a question or a statement (it did
not end with a question mark).
But I agree with this patch that the trace events that reference the same
address should be consistent in its use of %p and %px, where it uses one or
the other and not mix and match. Because the value itself may not be
important to a trace, but knowing that the value is consistent throughout
the trace with different tracepoints is.
-- Steve
prev parent reply other threads:[~2022-07-08 20:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 21:34 [PATCH net-next v2] net: Print hashed skb addresses for all net and qdisc events Subash Abhinov Kasiviswanathan
2022-06-27 11:00 ` patchwork-bot+netdevbpf
2022-06-27 19:36 ` Cong Wang
2022-06-27 19:49 ` Subash Abhinov Kasiviswanathan (KS)
2022-07-03 4:36 ` Cong Wang
2022-07-08 20:18 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708161828.70d108f2@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=qitao.xu@bytedance.com \
--cc=quic_jzenner@quicinc.com \
--cc=quic_stranche@quicinc.com \
--cc=quic_subashab@quicinc.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.