From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B95E6C433EF for ; Fri, 8 Jul 2022 16:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239129AbiGHQbq (ORCPT ); Fri, 8 Jul 2022 12:31:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232748AbiGHQbp (ORCPT ); Fri, 8 Jul 2022 12:31:45 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 996351091 for ; Fri, 8 Jul 2022 09:31:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C631B828AE for ; Fri, 8 Jul 2022 16:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02B5DC341CD; Fri, 8 Jul 2022 16:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657297901; bh=+KcBQnDBBn868FciMPHZhD4GJ/zuql+WDwqJYuQjSXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oi5R+s6zMMka3CnMUPVbNXZqOjEOpVF1CxGY5s7sKo1n3buOWAs4403IHJ64dmyf3 b+umhRd8TlrX75kvlrKTnO8l46dCxANQY3Z/I9S4MzAePlOpT69Vuqkq6UVpPTXrJe C8QAaqMUkgn9Wsr2TqeP30qmXHipNOYuejTPOWXMh5m1hZbxdR0ZXQbuQCIQBDayjF fcMLQ4O0KtsIxij2dacmG1AGU0XfpPXEA8W+IzpWv3doVqzXtTij0l63GeKrHMjqVi 12PRn4rOXpyeSoUqDpqd9QUSMQak9PMZP/BD9vL6Q0Qwb72fvy6+LwMwSXuhmSRaey f/IN35Q1QJ7sg== Date: Fri, 8 Jul 2022 17:31:35 +0100 From: Will Deacon To: Doug Anderson Cc: Sumit Garg , Daniel Thompson , Wei Li , Catalin Marinas , Mark Rutland , Masami Hiramatsu , Jason Wessel , Marc Zyngier , Linux ARM , LKML Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Message-ID: <20220708163134.GB6286@willie-the-truck> References: <20220511060521.465744-1-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 03:14:16PM -0700, Doug Anderson wrote: > Hi, > > On Tue, May 10, 2022 at 11:05 PM Sumit Garg wrote: > > > > This patch-set reworks pending fixes from Wei's series [1] to make > > single-step debugging via kgdb/kdb on arm64 work as expected. There was > > a prior discussion on ML [2] regarding if we should keep the interrupts > > enabled during single-stepping. So patch #1 follows suggestion from Will > > [3] to not disable interrupts during single stepping but rather skip > > single stepping within interrupt handler. > > > > [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/ > > [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/ > > [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/ > > > > Changes in v3: > > - Reword commit descriptions as per Daniel's suggestions. > > > > Changes in v2: > > - Replace patch #1 to rather follow Will's suggestion. > > > > Sumit Garg (2): > > arm64: entry: Skip single stepping into interrupt handlers > > arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step > > > > arch/arm64/include/asm/debug-monitors.h | 1 + > > arch/arm64/kernel/debug-monitors.c | 5 +++++ > > arch/arm64/kernel/entry-common.c | 18 +++++++++++++++++- > > arch/arm64/kernel/kgdb.c | 2 ++ > > 4 files changed, 25 insertions(+), 1 deletion(-) > > Sorry it took so long for me to respond. I kept dreaming that I'd find > the time to really dig deep into this to understand it fully and I'm > finally giving up on it. I'm going to hope that Will and/or Catalin > knows this area of the code well and can give it a good review. If not > then I'll strive harder to make the time... So the good news is that I spent a couple of days on this last week. The bad news is that I'm nowhere done and about to disappear on holiday for a week! But anyway, I might be able to give this a review when I'm back. Failing that, I wonder if enough of us have a little bit of time each that we could hack on an agreed design together which covers the debug exception behaviour beyond kgdb? Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4584C433EF for ; Fri, 8 Jul 2022 16:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Gjgb0n5/v3577QCtMiQ9UBSLWIOuBwBbG1qaOE10dyI=; b=ox38k/f6vtS3WW Hkx/D/h+df46P1x1Ds2ARLB6FB5gZucyui2GNVY45++7FUMx5MqZeoIau8A1Tm2l+n2kEE1eAt1u/ ZE7Tq8W79Lik+XwVA1MQTeefq8yTqDmouEwUdDClP/mzLOiciX6Sv2qRsc+T2TOPb3GSPBNzVU4+v MWxbmkn9W6UkNlnwFP4Lc42hYjE2hDkZKAYKY+BMmkycWBtS674w1bsq57qrp4P0Ubn+XhMgN3iWk hfGrui8ZR8S8Nk5t0xP88v0gaSx8pOlgqOteFsif5fCIB4NjYwfTE9UBNZkFnZD1B6jPZSy3LF3pu Nyng7YuQeslFOj7QPT6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9qxe-004hTE-Kd; Fri, 08 Jul 2022 16:36:11 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9qtM-004fXw-Be for linux-arm-kernel@lists.infradead.org; Fri, 08 Jul 2022 16:31:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 73235B828A6; Fri, 8 Jul 2022 16:31:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02B5DC341CD; Fri, 8 Jul 2022 16:31:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657297901; bh=+KcBQnDBBn868FciMPHZhD4GJ/zuql+WDwqJYuQjSXg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oi5R+s6zMMka3CnMUPVbNXZqOjEOpVF1CxGY5s7sKo1n3buOWAs4403IHJ64dmyf3 b+umhRd8TlrX75kvlrKTnO8l46dCxANQY3Z/I9S4MzAePlOpT69Vuqkq6UVpPTXrJe C8QAaqMUkgn9Wsr2TqeP30qmXHipNOYuejTPOWXMh5m1hZbxdR0ZXQbuQCIQBDayjF fcMLQ4O0KtsIxij2dacmG1AGU0XfpPXEA8W+IzpWv3doVqzXtTij0l63GeKrHMjqVi 12PRn4rOXpyeSoUqDpqd9QUSMQak9PMZP/BD9vL6Q0Qwb72fvy6+LwMwSXuhmSRaey f/IN35Q1QJ7sg== Date: Fri, 8 Jul 2022 17:31:35 +0100 From: Will Deacon To: Doug Anderson Cc: Sumit Garg , Daniel Thompson , Wei Li , Catalin Marinas , Mark Rutland , Masami Hiramatsu , Jason Wessel , Marc Zyngier , Linux ARM , LKML Subject: Re: [PATCH v3 0/2] arm64: Fix pending single-step debugging issues Message-ID: <20220708163134.GB6286@willie-the-truck> References: <20220511060521.465744-1-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_093144_745103_7DE8EF83 X-CRM114-Status: GOOD ( 26.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 01, 2022 at 03:14:16PM -0700, Doug Anderson wrote: > Hi, > > On Tue, May 10, 2022 at 11:05 PM Sumit Garg wrote: > > > > This patch-set reworks pending fixes from Wei's series [1] to make > > single-step debugging via kgdb/kdb on arm64 work as expected. There was > > a prior discussion on ML [2] regarding if we should keep the interrupts > > enabled during single-stepping. So patch #1 follows suggestion from Will > > [3] to not disable interrupts during single stepping but rather skip > > single stepping within interrupt handler. > > > > [1] https://lore.kernel.org/all/20200509214159.19680-1-liwei391@huawei.com/ > > [2] https://lore.kernel.org/all/CAD=FV=Voyfq3Qz0T3RY+aYWYJ0utdH=P_AweB=13rcV8GDBeyQ@mail.gmail.com/ > > [3] https://lore.kernel.org/all/20200626095551.GA9312@willie-the-truck/ > > > > Changes in v3: > > - Reword commit descriptions as per Daniel's suggestions. > > > > Changes in v2: > > - Replace patch #1 to rather follow Will's suggestion. > > > > Sumit Garg (2): > > arm64: entry: Skip single stepping into interrupt handlers > > arm64: kgdb: Set PSTATE.SS to 1 to re-enable single-step > > > > arch/arm64/include/asm/debug-monitors.h | 1 + > > arch/arm64/kernel/debug-monitors.c | 5 +++++ > > arch/arm64/kernel/entry-common.c | 18 +++++++++++++++++- > > arch/arm64/kernel/kgdb.c | 2 ++ > > 4 files changed, 25 insertions(+), 1 deletion(-) > > Sorry it took so long for me to respond. I kept dreaming that I'd find > the time to really dig deep into this to understand it fully and I'm > finally giving up on it. I'm going to hope that Will and/or Catalin > knows this area of the code well and can give it a good review. If not > then I'll strive harder to make the time... So the good news is that I spent a couple of days on this last week. The bad news is that I'm nowhere done and about to disappear on holiday for a week! But anyway, I might be able to give this a review when I'm back. Failing that, I wonder if enough of us have a little bit of time each that we could hack on an agreed design together which covers the debug exception behaviour beyond kgdb? Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel