From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABD79C433EF for ; Fri, 8 Jul 2022 16:38:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9937284599; Fri, 8 Jul 2022 18:38:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RXpInNv5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5112784599; Fri, 8 Jul 2022 18:38:39 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E4229845A2 for ; Fri, 8 Jul 2022 18:38:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id i11so28156056qtr.4 for ; Fri, 08 Jul 2022 09:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pQVvDl1higF3aWHLbhd+kUuBKMpaJvd280WSG8ybeG0=; b=RXpInNv5HUqZxuh2bF1zMXnly7dJZVuVuEfmFATFSoz759yurENGeB1il4lUYNpFkO xLAjFzz+zgjmPtMOfrr2hY4A+Ej/FbnbjZ5hoPWPyLFOMjAH+pE/3j2nUQ0M3XDXscRc 5MNpIHRqVYNjN/FLbYlzeF/I1b12HYodb0pPc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pQVvDl1higF3aWHLbhd+kUuBKMpaJvd280WSG8ybeG0=; b=GaKZB2Fr6pkCIX10DlL4LRdSIVto/7qb8XEkKuMBooXqav34JI/Gw8JNmB9Kb+zBDb 7od8KTVp5pC4VNawIzPwPHNiXawC5Lr0vAfFmM5s/g+tNO6ZvMvd9imWEXQIZgwHZhVV Ec7XqTVlnVE1JqzCDqpmRrfLHbLWjTSKNFD04XEcBkQ80EP2t9nTk2QTBsRmLv0dzFBy FDN/8U2ZaU/oO1pjh7LUiB6yWgmLwGd5m6TYqitRdTPPTwg+/KstX6RxFStobK73IldR 3PuUtVdQohoTFmT2SnQn/A++RQt15w6/PYsAq6R9KSBe0sQCCrpaHyPsgZZvoVKPzEWg biig== X-Gm-Message-State: AJIora9eIiQSRxWQ+ZfMariBJbvWl86iqYFjQcV/2IAZt7ZlRUzhC9Ii TvQkGEkyUYLcqp0hAcqBNzfwyg== X-Google-Smtp-Source: AGRyM1vX7tUEqX3IicGrp9Ma+9UUTJyblgj4anMf8vksP3wqq1GEsvCgSDD+wU9ntnSg9qkc5LE9hQ== X-Received: by 2002:a05:622a:174e:b0:319:5b72:173b with SMTP id l14-20020a05622a174e00b003195b72173bmr3812300qtk.13.1657298315592; Fri, 08 Jul 2022 09:38:35 -0700 (PDT) Received: from bill-the-cat (cpe-65-184-195-139.ec.res.rr.com. [65.184.195.139]) by smtp.gmail.com with ESMTPSA id ci27-20020a05622a261b00b00316dc1ffbb9sm22140715qtb.32.2022.07.08.09.38.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jul 2022 09:38:34 -0700 (PDT) Date: Fri, 8 Jul 2022 12:38:32 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Sjoerd Simons , Govindaraji Sivanantham , Hiremath Gireesh , Marcel Ziswiler , Frieder Schrempf , Parthiban Nallathambi , Navin Sankar Velliangiri , "Derald D. Woods" , Martyn Welch , Patrick Delaunay , Patrice Chotard , u-boot@lists.denx.de Subject: Re: [PATCH] distroboot: Fix ubifs Message-ID: <20220708163832.GC1146598@bill-the-cat> References: <20220531083236.18968-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="T5OpRuc6eldFtWsL" Content-Disposition: inline In-Reply-To: <20220531083236.18968-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --T5OpRuc6eldFtWsL Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, May 31, 2022 at 10:32:36AM +0200, Pali Roh=E1r wrote: > Fix multiple issues in ubifs distroboot code: >=20 > U-Boot supports attaching only one MTD device as UBI at the time. So > always call 'ubifsmount ubi0:${bootubivol}' for mounting UBI volume > ${bootubivol}. Usage of 'ubi${devnum}' is incorrect as 'ubi part' > command attach MTD device always as UBI device ubi0. >=20 > Set distroboot ${bootfstype} variable to ubifs in ubifs_boot command. > Distroboot scripts require ${bootfstype} variable to be properly set and = it > is already set for all other boot types. >=20 > Set distroboot ${distro_bootpart} variable to ${bootubivol} value. UBI > device does not have partitions, but has volumes. Distroboot scripts > require something to be set in ${distro_bootpart} variable, so set it to > the UBI volume which is currently mounted by ubifs. >=20 > Set distroboot ${devnum} variable to fixed string "ubi0". ubifs code > differs from the other partition code that it requires "ubi" prefix before > number. >=20 > Explicitly unmount ubifs volume after loading all data from it. This allo= ws > to detach UBI device from MTD device. >=20 > Move definition of MTD device with UBI and UBI volume with ubifs filesyst= em > from global env variables ${bootubipart} and ${bootubivol} into the > distroboot "func" macro, defined in board include config files. UBIFS > distroboot macros then set ${bootubipart} and ${bootubivol} local variabl= es > for compatibility with existing distroboot scripts. >=20 > This last change allows to define more UBIFS target devices and make it > clear what is boot MTD/UBI device. >=20 > All board include config files are adjusted to use this new scheme of > specifying boot MTD/UBI device. >=20 > Signed-off-by: Pali Roh=E1r > Acked-by: Frieder Schrempf Applied to u-boot/next, thanks! --=20 Tom --T5OpRuc6eldFtWsL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmLIXYgACgkQFHw5/5Y0 tyzl6QwAoJw8a2ywdlILuuwXyHFRtLyyo4f7Z9GI7MyPYRHPxhVxowXryFx5/50C wdzIDIDlNhH7Mc6ZTRoe1PlU/S8HrCdIy/02zwqY8OFlPDcX8tuy6n3xm4ICyFhI t2Pt3dlgvyRt5UXmnQvvjGU5oyHT3I5JIoScKkVKqgK0S5GiHKkRkFxynCYWjGFl LsjEhcVrcXue/fxm/KVIpOTeCw7vwGKy9FB0KG4PUpZuMbU973gezf2fNt6luC9j rlGfuTkRA0nf6vFkgPFVOy/ZIdy+PRnY2drTWh+vd9KwKl68DOB6SK2O6CNG4/uB WEj5iQvS7Dx6srGKHeQillQJwDHZ+WhEfNIHo23628ZiLlA7mKYwzlSYxuLA3du0 K7MFHWedoYwCpQoFTcxECG3NtnZb3tLjrklEBzrIT5wCLDv6QNBbnLUmyQ5i9CZQ uCkCo7HELSxsVyTIt+ayBEH2kGZMLrPJggZE4dtEN6GNTYFtIZLsIYxDoclw+Zwr nfdcWrjD =6kex -----END PGP SIGNATURE----- --T5OpRuc6eldFtWsL--