From: Ben Dooks <ben.dooks@sifive.com>
To: linux-kernel@vger.kernel.org
Cc: Sudip Mukherjee <sudip.mukherjee@sifive.com>,
Jude Onyenegecha <jude.onyenegecha@sifive.com>,
Ben Dooks <ben.dooks@sifive.com>
Subject: [PATCH] devres: show which resource was invalid
Date: Fri, 8 Jul 2022 18:05:54 +0100 [thread overview]
Message-ID: <20220708170554.270405-1-ben.dooks@sifive.com> (raw)
If we do find a resouce that's not valid, print it to aid
identifying the issue.
Signed-off-by: Ben Dooks <ben.dooks@sifive.com>
---
lib/devres.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/devres.c b/lib/devres.c
index 14664bbb4875..df5ed06908f0 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -143,7 +143,7 @@ __devm_ioremap_resource(struct device *dev, const struct resource *res,
BUG_ON(!dev);
if (!res || resource_type(res) != IORESOURCE_MEM) {
- dev_err(dev, "invalid resource\n");
+ dev_err(dev, "invalid resource (%pR)\n", res);
return IOMEM_ERR_PTR(-EINVAL);
}
--
2.35.1
reply other threads:[~2022-07-08 17:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708170554.270405-1-ben.dooks@sifive.com \
--to=ben.dooks@sifive.com \
--cc=jude.onyenegecha@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudip.mukherjee@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.