From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90AB6C43334 for ; Fri, 8 Jul 2022 19:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239591AbiGHTHa (ORCPT ); Fri, 8 Jul 2022 15:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238639AbiGHTH3 (ORCPT ); Fri, 8 Jul 2022 15:07:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C5E12656F; Fri, 8 Jul 2022 12:07:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0E11B824F7; Fri, 8 Jul 2022 19:07:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DEB2C341C0; Fri, 8 Jul 2022 19:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657307245; bh=rjeSBuy7WINmWx1pFu173n7NXaBRljwS3TEUUol/8xA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Qr2pIIxsT2+b8vifONEdOuiCMeFMq+Fdai7jvFef2HwpemnemDmbIpP3eaGbsmuox KHOi3zFjMCjR4O7rRCM2PTdRRGSN+AQuIKuRv1LutHC81uf0AAtDdyokB3ZXlmzXQq xAeyocy5ylC80h/i6Da+PF5y694B0C79aUCgR7jUwl+9MQapwkEq6+dzOVLaWgxc7M q4D+CjrsYvDqPbHo+aZskqtk6ehJZ5dY6V20cu5ukQ58L+PMcrnXMogUzUt5UE0QGK DyFJVIkSeDLJBVraMvoBmZ2ozjZAmWgQhhT+RWfiShELqvlT/8zwhr7xiQ3oQJFLSo RCvFlPlESAAAw== Date: Fri, 8 Jul 2022 14:07:23 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Jim Quinlan , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v1 2/4] PCI: brcmstb: Add mechanism to turn on subdev regulators Message-ID: <20220708190723.GA366169@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2022 at 10:14:11AM -0400, Jim Quinlan wrote: > On Wed, Jul 6, 2022 at 7:12 PM Bjorn Helgaas wrote: > > On Fri, Jul 01, 2022 at 12:27:23PM -0400, Jim Quinlan wrote: > > > Add a mechanism to identify standard PCIe regulators in the DT, allocate > > > them, and turn them on before the rest of the bus is scanned during > > > pci_host_probe(). > > > ... > > > +static int pci_subdev_regulators_add_bus(struct pci_bus *bus); > > > +static void pci_subdev_regulators_remove_bus(struct pci_bus *bus); > > > > I think these forward declarations are unnecessary. I can remove them > > if you agree. > > It is up to you. I have a commit-set ready that will make a number of > improvements to our driver. > One of them removes all forward declarations. Other commits concern > other suggestions you > have made, e.g. rename brcm_pcie_linkup() to brcm_pcie_start_link(). If you're planning a v2, I'd drop the declarations there. No point in adding them, only to remove them in a future patch (unless we need them in the interim, of course, but in this case I don't think we do). Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34CA4C433EF for ; Fri, 8 Jul 2022 19:08:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=3OxotYhxVqKKtr9ab4weveBjUyGEg97ruXTz4ksXZ38=; b=nSUpFhzFqztdS4 0WDJiVXFqBTVG5IpuJg1tcVyfIjdS75V2CfgSkQlnDP3nyp/AYr8QFS3leoJX5Ca5xP0qtaz0042a AFVBJu3Ags1lQqr2chYvxWk1CWjxR/Oj/5rssGKelbKcsEtDOJHoMR2SXJS1JH/JT/QuoBk0dUDJq rgBH3Zn5FPhCBU8C5oRS6ub6xqGBDZaQ590S/ijpBz3WG4UZqi+3PFTQrHnqD0wEXwP933QyaNYNi y3Ha8R1DYrgaNTKDGIC2uQc4YpSPCe/n4Meb/YcqJo7hBnZy551pjzJflCwY6+t+Ggkjz8rqBD28V INjFJEOiIIeSQwOpdUHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9tK9-005Xv3-GP; Fri, 08 Jul 2022 19:07:33 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o9tK6-005XtS-UO; Fri, 08 Jul 2022 19:07:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 02517B8293C; Fri, 8 Jul 2022 19:07:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DEB2C341C0; Fri, 8 Jul 2022 19:07:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657307245; bh=rjeSBuy7WINmWx1pFu173n7NXaBRljwS3TEUUol/8xA=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Qr2pIIxsT2+b8vifONEdOuiCMeFMq+Fdai7jvFef2HwpemnemDmbIpP3eaGbsmuox KHOi3zFjMCjR4O7rRCM2PTdRRGSN+AQuIKuRv1LutHC81uf0AAtDdyokB3ZXlmzXQq xAeyocy5ylC80h/i6Da+PF5y694B0C79aUCgR7jUwl+9MQapwkEq6+dzOVLaWgxc7M q4D+CjrsYvDqPbHo+aZskqtk6ehJZ5dY6V20cu5ukQ58L+PMcrnXMogUzUt5UE0QGK DyFJVIkSeDLJBVraMvoBmZ2ozjZAmWgQhhT+RWfiShELqvlT/8zwhr7xiQ3oQJFLSo RCvFlPlESAAAw== Date: Fri, 8 Jul 2022 14:07:23 -0500 From: Bjorn Helgaas To: Jim Quinlan Cc: Jim Quinlan , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Florian Fainelli , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list Subject: Re: [PATCH v1 2/4] PCI: brcmstb: Add mechanism to turn on subdev regulators Message-ID: <20220708190723.GA366169@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220708_120731_152962_D713849B X-CRM114-Status: GOOD ( 17.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 08, 2022 at 10:14:11AM -0400, Jim Quinlan wrote: > On Wed, Jul 6, 2022 at 7:12 PM Bjorn Helgaas wrote: > > On Fri, Jul 01, 2022 at 12:27:23PM -0400, Jim Quinlan wrote: > > > Add a mechanism to identify standard PCIe regulators in the DT, allocate > > > them, and turn them on before the rest of the bus is scanned during > > > pci_host_probe(). > > > ... > > > +static int pci_subdev_regulators_add_bus(struct pci_bus *bus); > > > +static void pci_subdev_regulators_remove_bus(struct pci_bus *bus); > > > > I think these forward declarations are unnecessary. I can remove them > > if you agree. > > It is up to you. I have a commit-set ready that will make a number of > improvements to our driver. > One of them removes all forward declarations. Other commits concern > other suggestions you > have made, e.g. rename brcm_pcie_linkup() to brcm_pcie_start_link(). If you're planning a v2, I'd drop the declarations there. No point in adding them, only to remove them in a future patch (unless we need them in the interim, of course, but in this case I don't think we do). Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel