From: Jakub Kicinski <kuba@kernel.org>
To: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
tchornyi@marvell.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, lkp@intel.com,
Yevhen Orlov <yevhen.orlov@plvision.eu>
Subject: Re: [PATCH V4 net-next 4/4] net: marvell: prestera: implement software MDB entries allocation
Date: Fri, 8 Jul 2022 20:39:07 -0700 [thread overview]
Message-ID: <20220708203907.253df7a9@kernel.org> (raw)
In-Reply-To: <20220708174324.18862-5-oleksandr.mazur@plvision.eu>
On Fri, 8 Jul 2022 20:43:24 +0300 Oleksandr Mazur wrote:
> +static int
> +prestera_mdb_port_addr_obj_add(const struct switchdev_obj_port_mdb *mdb);
> +static int
> +prestera_mdb_port_addr_obj_del(struct prestera_port *port,
> + const struct switchdev_obj_port_mdb *mdb);
> +
> +static void
> +prestera_mdb_flush_bridge_port(struct prestera_bridge_port *br_port);
> +static int
> +prestera_mdb_port_add(struct prestera_mdb_entry *br_mdb,
> + struct net_device *orig_dev,
> + const unsigned char addr[ETH_ALEN], u16 vid);
> +
> +static void
> +prestera_br_mdb_entry_put(struct prestera_br_mdb_entry *br_mdb_entry);
> +static int prestera_br_mdb_mc_enable_sync(struct prestera_bridge *br_dev);
> +static int prestera_br_mdb_sync(struct prestera_bridge *br_dev);
> +static int prestera_br_mdb_port_add(struct prestera_br_mdb_entry *br_mdb,
> + struct prestera_bridge_port *br_port);
> +static void
> +prestera_mdb_port_del(struct prestera_mdb_entry *mdb,
> + struct net_device *orig_dev);
No forward declarations in the kernel, unless the there is a circular
dependency. You should be able to just order the functions correctly.
> + list_for_each_entry(br_mdb, &br_dev->br_mdb_entry_list,
> + br_mdb_entry_node)
> + if ((err = prestera_mdb_enable_set(br_mdb, enable)))
> + return err;
Like checkpatch says, no assignments in the if statements.
prev parent reply other threads:[~2022-07-09 3:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 17:43 [PATCH V4 net-next 0/4] net: marvell: prestera: add MDB offloading support Oleksandr Mazur
2022-07-08 17:43 ` [PATCH V4 net-next 1/4] net: marvell: prestera: rework bridge flags setting Oleksandr Mazur
2022-07-08 17:43 ` [PATCH V4 net-next 2/4] net: marvell: prestera: define MDB/flood domain entries and HW API to offload them to the HW Oleksandr Mazur
2022-07-08 17:43 ` [PATCH V4 net-next 3/4] net: marvell: prestera: define and implement MDB / flood domain API for entires creation and deletion Oleksandr Mazur
2022-07-08 17:43 ` [PATCH V4 net-next 4/4] net: marvell: prestera: implement software MDB entries allocation Oleksandr Mazur
2022-07-09 3:39 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220708203907.253df7a9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oleksandr.mazur@plvision.eu \
--cc=pabeni@redhat.com \
--cc=tchornyi@marvell.com \
--cc=yevhen.orlov@plvision.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.