arch/mips/boot/compressed/dbg.c:12:13: warning: no previous prototype for 'putc'

From: kernel test robot <lkp@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Kees Cook <keescook@chromium.org>
Subject: arch/mips/boot/compressed/dbg.c:12:13: warning: no previous prototype for 'putc'
Date: Sat, 9 Jul 2022 05:10:32 +0800	[thread overview]
Message-ID: <202207090522.nxw0ERcT-lkp@intel.com> (raw)

Hi Arnd,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a471da3100ef2e8feb8449d378a52e29dd1e9ae1
commit: 606b102876e3741851dfb09d53f3ee57f650a52c drm: fb_helper: fix CONFIG_FB dependency
date:   9 months ago
config: mips-randconfig-r015-20220708 (https://download.01.org/0day-ci/archive/20220709/202207090522.nxw0ERcT-lkp@intel.com/config)
compiler: mipsel-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=606b102876e3741851dfb09d53f3ee57f650a52c
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 606b102876e3741851dfb09d53f3ee57f650a52c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

Note: functions only called from assembly code should be annotated with the asmlinkage attribute
All warnings (new ones prefixed by >>):

>> arch/mips/boot/compressed/dbg.c:12:13: warning: no previous prototype for 'putc' [-Wmissing-prototypes]
      12 | void __weak putc(char c)
         |             ^~~~
>> arch/mips/boot/compressed/dbg.c:16:6: warning: no previous prototype for 'puts' [-Wmissing-prototypes]
      16 | void puts(const char *s)
         |      ^~~~
>> arch/mips/boot/compressed/dbg.c:26:6: warning: no previous prototype for 'puthex' [-Wmissing-prototypes]
      26 | void puthex(unsigned long long val)
         |      ^~~~~~
--
>> arch/mips/boot/compressed/uart-alchemy.c:4:6: warning: no previous prototype for 'putc' [-Wmissing-prototypes]
       4 | void putc(char c)
         |      ^~~~

vim +/putc +12 arch/mips/boot/compressed/dbg.c

1b93b3c3e94be2 Wu Zhangjin 2009-10-14  11  
e52dd9fc6b9e0c Wu Zhangjin 2010-01-26 @12  void __weak putc(char c)
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  13  {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  14  }
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  15  
1b93b3c3e94be2 Wu Zhangjin 2009-10-14 @16  void puts(const char *s)
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  17  {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  18  	char c;
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  19  	while ((c = *s++) != '\0') {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  20  		putc(c);
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  21  		if (c == '\n')
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  22  			putc('\r');
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  23  	}
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  24  }
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  25  
1b93b3c3e94be2 Wu Zhangjin 2009-10-14 @26  void puthex(unsigned long long val)

:::::: The code at line 12 was first introduced by commit
:::::: e52dd9fc6b9e0c17b220bd38371ff15032a1a155 MIPS: Simplify the weak annotation with __weak

:::::: TO: Wu Zhangjin <wuzhangjin@gmail.com>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp