From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252C1C43334 for ; Mon, 11 Jul 2022 08:24:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229754AbiGKIYR (ORCPT ); Mon, 11 Jul 2022 04:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229941AbiGKIYJ (ORCPT ); Mon, 11 Jul 2022 04:24:09 -0400 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53D551AD87 for ; Mon, 11 Jul 2022 01:24:08 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 001AD204E0; Mon, 11 Jul 2022 10:24:06 +0200 (CEST) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KEq9CoUBx4au; Mon, 11 Jul 2022 10:24:05 +0200 (CEST) Received: from mailout2.secunet.com (mailout2.secunet.com [62.96.220.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 72418201E5; Mon, 11 Jul 2022 10:24:05 +0200 (CEST) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) by mailout2.secunet.com (Postfix) with ESMTP id 68E9180004A; Mon, 11 Jul 2022 10:24:05 +0200 (CEST) Received: from mbx-dresden-01.secunet.de (10.53.40.199) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Jul 2022 10:24:05 +0200 Received: from gauss2.secunet.de (10.182.7.193) by mbx-dresden-01.secunet.de (10.53.40.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 11 Jul 2022 10:24:04 +0200 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 1F3C93182E41; Mon, 11 Jul 2022 10:24:04 +0200 (CEST) Date: Mon, 11 Jul 2022 10:24:04 +0200 From: Steffen Klassert To: Antony Antony CC: Herbert Xu , , "Tobias Brunner" Subject: Re: [PATCH ipsec-next 1/4] Revert "xfrm: update SA curlft.use_time" Message-ID: <20220711082404.GM566407@gauss3.secunet.de> References: <3e201e1156639286e1874ebc29233741b8b2ac54.1657260947.git.antony.antony@secunet.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <3e201e1156639286e1874ebc29233741b8b2ac54.1657260947.git.antony.antony@secunet.com> X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-dresden-01.secunet.de (10.53.40.199) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jul 08, 2022 at 08:16:28AM +0200, Antony Antony wrote: > This reverts commit af734a26a1a95a9fda51f2abb0c22a7efcafd5ca. > > The abvoce commit is a regression according RFC 2367. A better fix would be > use x->lastused. Which will be propsed later. > > according to RFC 2367 use_time == sadb_lifetime_usetime. > > "sadb_lifetime_usetime > For CURRENT, the time, in seconds, when association > was first used. For HARD and SOFT, the number of > seconds after the first use of the association until > it expires." > > Fixes: af734a26a1a9 ("xfrm: update SA curlft.use_time") > Signed-off-by: Antony Antony This is a fix, so it should go to the ipsec tree. Please slpit your patchset into fixes that go to the ipsec tree and new features that go to ipsec-next. Thanks!