Re: [PATCH ipsec-next 4/4] xfrm: clone x->lastused in xfrm_do_migrate

[Steffen Klassert <steffen.klassert@secunet.com>]

On Fri, Jul 08, 2022 at 08:18:18AM +0200, Antony Antony wrote:
> migrate x->lastused xfrm_do_migrate. It was not in the original commit

Is the commit message intentional like this?
It reads a bit odd :)

> Signed-off-by: Antony Antony <antony.antony@secunet.com>
> ---
>  net/xfrm/xfrm_state.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c
> index 03b180878e61..712b6d46f8ee 100644
> --- a/net/xfrm/xfrm_state.c
> +++ b/net/xfrm/xfrm_state.c
> @@ -1592,6 +1592,7 @@ static struct xfrm_state *xfrm_state_clone(struct xfrm_state *orig,
>  	x->replay = orig->replay;
>  	x->preplay = orig->preplay;
>  	x->mapping_maxage = orig->mapping_maxage;
> +	x->lastused = orig->lastused;

We lose lastused when cloning a state, so this one is a fix too.

Please submit to the ipsec tree with a proper 'Fixes' tag.

Thanks!