From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F27C433EF for ; Tue, 12 Jul 2022 01:28:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231295AbiGLB2h (ORCPT ); Mon, 11 Jul 2022 21:28:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231382AbiGLB2e (ORCPT ); Mon, 11 Jul 2022 21:28:34 -0400 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF268234 for ; Mon, 11 Jul 2022 18:28:31 -0700 (PDT) Received: by mail-pl1-x62f.google.com with SMTP id v21so3434142plo.0 for ; Mon, 11 Jul 2022 18:28:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c2vyjIbciyVquzlDajX3qmEOd67pfFD4fFZaxPOLy2U=; b=R0rW8hG8pcYKfOtv7wArgQWO4c5J5gecTD+iAR430JXAX1rRfxks45tN1PZOo1Lp8A JHvlOivBtB+rUjQ2qULebxMkb3MyOr480SWKomBcypBQ7JjjHMpLl0shHWomPo/xwS58 AfNQ8E9RhYkIwS5JkRAlMgppwClic61i8pUKX+ZK7qNZPQqJWR1DpZz62ZvTmstIQfRR 1jTgUyNUZLw7eGAL36cwqNWELwLO/w2TBQhV6aIvvZrEqdsVys0rulPO0TRpdr0D4/lW Tne3R6dIhYbGuioSNhq9rJUlkC9l4m0do3gQe519qzyHXHKQgWJRq32fJwVIYPgIPF8q HvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=c2vyjIbciyVquzlDajX3qmEOd67pfFD4fFZaxPOLy2U=; b=zAmvoXkci1CAY/zgMTGlp6ZkzdYjbT22pZqCBtMid4cD/n8ZZBGI3k216MhyvryYBJ NY7zf57EwssVFxZfYKE+8Tvsf68F0XCY4KKU79uY2znFod45fkoL5/CYpluScTyigmGd Kf2+qbw9MGy3dGiUKbdJ+Jamy7bsw+8cB/T5Ytfqx4GRlypIIPmBQo68W+A/SxB1ec6v 9Xhh4fApYJ1MYzGXFfcr4HTxHIjwYLLOmuq0z6YsDG9ymB9MlG0gryNPj85M3LfPwsPS mmZ9ayV1nPwpP5raUAMRUcDXDIZsqdqNz2mOoguiPUVIEtuC7zeUdWKqG7nSazyvPQjS Z7Yw== X-Gm-Message-State: AJIora80erDah1BJTlOe9xbmYKwNtEPO/LRDbmrZWguiVa8GALWSesy+ Z2CjfUvzhBN6LqrA86PsmJlFcwBrcqB8Jpsl X-Google-Smtp-Source: AGRyM1u1FwY6xJU0oOJI9mtvV2RdU6Dl8F3dLvVLbbm+PSf6Nv5lh52eBhMg0gMvhMbko9Cx4tSdBw== X-Received: by 2002:a17:902:6901:b0:168:9bb4:7adb with SMTP id j1-20020a170902690100b001689bb47adbmr21486583plk.147.1657589311099; Mon, 11 Jul 2022 18:28:31 -0700 (PDT) Received: from leoy-ThinkPad-X240s (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id z62-20020a17090a6d4400b001ef8dd1315esm7613045pjj.27.2022.07.11.18.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 18:28:30 -0700 (PDT) Date: Tue, 12 Jul 2022 09:28:23 +0800 From: Leo Yan To: Georgi Djakov Cc: Andy Gross , Bjorn Andersson , Krzysztof Kozlowski , Konrad Dybcio , Rob Herring , Bryan O'Donoghue , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values Message-ID: <20220712012823.GA10379@leoy-ThinkPad-X240s> References: <20220711115240.806236-1-leo.yan@linaro.org> <20220711115240.806236-6-leo.yan@linaro.org> <480d38db-3114-29d1-8b81-b35a07623060@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <480d38db-3114-29d1-8b81-b35a07623060@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Georgi, On Mon, Jul 11, 2022 at 04:53:47PM +0300, Georgi Djakov wrote: [...] > > static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > > { > > struct qcom_icc_provider *qp; > > struct qcom_icc_node *src_qn = NULL, *dst_qn = NULL; > > struct icc_provider *provider; > > - struct icc_node *n; > > u64 sum_bw; > > - u64 max_peak_bw; > > u64 rate; > > - u32 agg_avg = 0; > > - u32 agg_peak = 0; > > + u64 agg_avg[QCOM_ICC_NUM_BUCKETS], agg_peak[QCOM_ICC_NUM_BUCKETS]; > > + u64 max_agg_avg, max_agg_peak; > > Now max_agg_peak is unused? Sorry for this mistake. Will send new patch series soon. Thanks, Leo