From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB2391FD5 for ; Tue, 12 Jul 2022 00:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657587294; x=1689123294; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=V6w2sMs8zcctI71jT/jdZW5CM1h96l8zoH9VbyJnAnM=; b=Ldv7tubNo0S98EJKfEhYV3eR54b6saKYfLHbV3vcAeS9oy3Qhgq2cfLm 8UeElwpqLa9TeD70uREOlWVLlzKi2p4LIJSyGbFuVvnRMCT//qjVMq4Gi zFvpZBqBd9+E6gT/CR7vUWDSSCvmfQliyAl+TruCHjRbRLhNU4ZyepbQA BmjnajTHw/2ERg3XllpYCHkx7Cq224BKiwCb5EZPzznHP8YbF9We9FNBL pwJKUXC1wtdn09W2BKbHDRm/iYb557BCcDxmuj2BJiQK7iyx/ZRC8VU83 PBQvBI5sxqdNiNeBbrLueEDU9bsbnJXWnhkoRessmF85uy61tuaCevvYI Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10405"; a="310418931" X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="310418931" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 17:54:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="662759318" Received: from lkp-server02.sh.intel.com (HELO 8708c84be1ad) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2022 17:54:48 -0700 Received: from kbuild by 8708c84be1ad with local (Exim 4.95) (envelope-from ) id 1oB4Aq-0001Rz-8h; Tue, 12 Jul 2022 00:54:48 +0000 Date: Tue, 12 Jul 2022 08:54:25 +0800 From: kernel test robot To: Jarrett Schultz , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Catalin Marinas , Will Deacon , Jiri Kosina , Benjamin Tissoires , Bjorn Andersson , Shawn Guo , Geert Uytterhoeven , Marcel Ziswiler , Biju Das , Dmitry Baryshkov , Vinod Koul Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Dmitry Antipov , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jarrett Schultz Subject: Re: [PATCH v5 5/6] HID: add spi-hid, transport driver for HID over SPI bus Message-ID: <202207120839.Ga8kjAG8-lkp@intel.com> References: <20220707165902.3184-6-jaschultzMS@gmail.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220707165902.3184-6-jaschultzMS@gmail.com> Hi Jarrett, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on dtor-input/next robh/for-next linus/master v5.19-rc6 next-20220711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220712/202207120839.Ga8kjAG8-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 77a38f6839980bfac61babb40d83772c51427011) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d0121c2f2d1bb21824555c34c233dd3fbc6aee96 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 git checkout d0121c2f2d1bb21824555c34c233dd3fbc6aee96 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/hid/spi-hid/ drivers/md/ drivers/net/ethernet/marvell/prestera/ drivers/vfio/pci/mlx5/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hid/spi-hid/spi-hid-core.c:193:20: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] static const char *const spi_hid_power_mode_string(u8 power_state) ^~~~~~ >> drivers/hid/spi-hid/spi-hid-core.c:691:4: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:691:17: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:1318:13: error: incompatible function pointer types initializing 'void (*)(struct spi_device *)' with an expression of type 'int (struct spi_device *)' [-Werror,-Wincompatible-function-pointer-types] .remove = spi_hid_remove, ^~~~~~~~~~~~~~ 3 warnings and 1 error generated. -- In file included from drivers/hid/spi-hid/trace.c:9: In file included from drivers/hid/spi-hid/./spi-hid_trace.h:194: In file included from include/trace/define_trace.h:102: In file included from include/trace/trace_events.h:237: >> drivers/hid/spi-hid/./spi-hid_trace.h:140:92: warning: more '%' conversions than data arguments [-Wformat-insufficient-args] TP_printk("spi%d.%d: (%04x:%04x v%d) HID v%d.%d state i:%d p:%d len i:%d o:%d r:%d flags %c", ~^ include/trace/stages/stage3_trace_output.h:9:33: note: expanded from macro 'TP_printk' #define TP_printk(fmt, args...) fmt "\n", args ^~~ include/trace/trace_events.h:203:27: note: expanded from macro 'DECLARE_EVENT_CLASS' trace_event_printf(iter, print); \ ^~~~~ 1 warning generated. vim +/const +193 drivers/hid/spi-hid/spi-hid-core.c 192 > 193 static const char *const spi_hid_power_mode_string(u8 power_state) 194 { 195 switch (power_state) { 196 case SPI_HID_POWER_MODE_ON: 197 return "d0"; 198 case SPI_HID_POWER_MODE_SLEEP: 199 return "d2"; 200 case SPI_HID_POWER_MODE_OFF: 201 return "d3"; 202 case SPI_HID_POWER_MODE_WAKING_SLEEP: 203 return "d3*"; 204 default: 205 return "unknown"; 206 } 207 } 208 -- 0-DAY CI Kernel Test Service https://01.org/lkp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDA78C433EF for ; Tue, 12 Jul 2022 00:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wxiuqIGwqveTa8RZdUdjqEUa+QzUZOv4S25AVlS6GtI=; b=j/bDvIz9on7/Od 0Tz4x0wqEBEFnOFFSQnXZJmhCpmLnAF4yC0v1EwazrcaoNRLYaspsHDSSeaaunqELc6KgcAcCAsG3 tDFqXlObp5YA8k8agKXAgKyOMMbuFXK0vYpiI1fu06fw98STbxPsJZzSwqC6JDyn+dc6MzI/9FnWG D8CyO+4QmfwKLHXog9Z9cP8PpuXESbEdg0Cxi5/V4662H/sCuVvMY22jLu+74LTdieISQRr4bsKpR mM+IA/spOGBFNnCfUJrLQqysMqyh2AkGYs3kRoI2GvYcjl31AcNKomWy2a4CqVXp4Bm13J7IpJvWj V+Dj+dAMHlrQ/VZPRD2w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB4B2-006Ci3-9P; Tue, 12 Jul 2022 00:55:00 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oB4Ay-006Cdc-8g for linux-arm-kernel@lists.infradead.org; Tue, 12 Jul 2022 00:54:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657587296; x=1689123296; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=V6w2sMs8zcctI71jT/jdZW5CM1h96l8zoH9VbyJnAnM=; b=c3p8+RVF3Th9jgAbmMbTKSobmNUZXoH8PQYYuydF/9HYTEwWRudhmIRw LPbDhhFMxapOPjAeT9Oy2IYBG7LTmvVMkOvHQRoj8xmq1KbHKSLl+npEM rhd1h3nW5R0WKLurrgoxNxNO1BUQDrX6eftyjPqSrSNXEfRTqmU78LqOi zb0SNFiKLCa1cVK57XdHDxl1Wswt9kmciF8/pVUKZrAVMSJp+GVNfvwpC XpZhfl2qtGHAHOc5saQqkDkmA83NaRKLKTBmmMe5c28r+MOPaHR1JyAha PRa3FZkZI9Acjql4JXAs3h1o5Uswjw6p7lDk65mg9ESaDfZCS7rAcjp2s w==; X-IronPort-AV: E=McAfee;i="6400,9594,10405"; a="264596212" X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="264596212" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2022 17:54:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,264,1650956400"; d="scan'208";a="662759318" Received: from lkp-server02.sh.intel.com (HELO 8708c84be1ad) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 11 Jul 2022 17:54:48 -0700 Received: from kbuild by 8708c84be1ad with local (Exim 4.95) (envelope-from ) id 1oB4Aq-0001Rz-8h; Tue, 12 Jul 2022 00:54:48 +0000 Date: Tue, 12 Jul 2022 08:54:25 +0800 From: kernel test robot To: Jarrett Schultz , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Catalin Marinas , Will Deacon , Jiri Kosina , Benjamin Tissoires , Bjorn Andersson , Shawn Guo , Geert Uytterhoeven , Marcel Ziswiler , Biju Das , Dmitry Baryshkov , Vinod Koul Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Dmitry Antipov , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jarrett Schultz Subject: Re: [PATCH v5 5/6] HID: add spi-hid, transport driver for HID over SPI bus Message-ID: <202207120839.Ga8kjAG8-lkp@intel.com> References: <20220707165902.3184-6-jaschultzMS@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220707165902.3184-6-jaschultzMS@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220711_175456_346584_D77FFFAE X-CRM114-Status: GOOD ( 16.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jarrett, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on dtor-input/next robh/for-next linus/master v5.19-rc6 next-20220711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220712/202207120839.Ga8kjAG8-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 77a38f6839980bfac61babb40d83772c51427011) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d0121c2f2d1bb21824555c34c233dd3fbc6aee96 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 git checkout d0121c2f2d1bb21824555c34c233dd3fbc6aee96 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/hid/spi-hid/ drivers/md/ drivers/net/ethernet/marvell/prestera/ drivers/vfio/pci/mlx5/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/hid/spi-hid/spi-hid-core.c:193:20: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] static const char *const spi_hid_power_mode_string(u8 power_state) ^~~~~~ >> drivers/hid/spi-hid/spi-hid-core.c:691:4: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:691:17: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:1318:13: error: incompatible function pointer types initializing 'void (*)(struct spi_device *)' with an expression of type 'int (struct spi_device *)' [-Werror,-Wincompatible-function-pointer-types] .remove = spi_hid_remove, ^~~~~~~~~~~~~~ 3 warnings and 1 error generated. -- In file included from drivers/hid/spi-hid/trace.c:9: In file included from drivers/hid/spi-hid/./spi-hid_trace.h:194: In file included from include/trace/define_trace.h:102: In file included from include/trace/trace_events.h:237: >> drivers/hid/spi-hid/./spi-hid_trace.h:140:92: warning: more '%' conversions than data arguments [-Wformat-insufficient-args] TP_printk("spi%d.%d: (%04x:%04x v%d) HID v%d.%d state i:%d p:%d len i:%d o:%d r:%d flags %c", ~^ include/trace/stages/stage3_trace_output.h:9:33: note: expanded from macro 'TP_printk' #define TP_printk(fmt, args...) fmt "\n", args ^~~ include/trace/trace_events.h:203:27: note: expanded from macro 'DECLARE_EVENT_CLASS' trace_event_printf(iter, print); \ ^~~~~ 1 warning generated. vim +/const +193 drivers/hid/spi-hid/spi-hid-core.c 192 > 193 static const char *const spi_hid_power_mode_string(u8 power_state) 194 { 195 switch (power_state) { 196 case SPI_HID_POWER_MODE_ON: 197 return "d0"; 198 case SPI_HID_POWER_MODE_SLEEP: 199 return "d2"; 200 case SPI_HID_POWER_MODE_OFF: 201 return "d3"; 202 case SPI_HID_POWER_MODE_WAKING_SLEEP: 203 return "d3*"; 204 default: 205 return "unknown"; 206 } 207 } 208 -- 0-DAY CI Kernel Test Service https://01.org/lkp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel