From: Vincent Knecht <vincent.knecht@mailoo.org>
To: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Vincent Knecht <vincent.knecht@mailoo.org>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, hns@goldelico.com
Subject: [PATCH v5 00/12] leds: Fix/Add is31fl319{0,1,3} support
Date: Tue, 12 Jul 2022 12:08:26 +0200 [thread overview]
Message-ID: <20220712100841.1538395-1-vincent.knecht@mailoo.org> (raw)
v5:
- added and tested Andy' series which converts driver to use
device properties, dev_err_probe, devm_add_action_or_reset
and simple i2c probe_new:
https://lore.kernel.org/linux-leds/20220711213524.3587-1-andriy.shevchenko@linux.intel.com/
v4:
- took Andy's comments into account
- add patch 7 for cleanup and formatting fixes
v3:
- pick up Rob's R-b for patches 1 and 2
- reinstate bindings docs license and maintainer
changes with Nikolaus agreement
- took Andy's comments on patch 4 into account
v2:
- keep original bindings license and maintainer/owner (Rob)
- squash bindings patches 2 & 4 (Krzysztof)
v1-resend:
- no change, resending after configuring git to accomodate
for smtp provider limit of 5 emails per batch
- just change cover-letter to mention si-en chip for idol347
The is31fl3190, is31fl3191 and is31fl3193 chips (1 or 3 PWM channels)
cannot be handled the same as is31fl3196 and is31fl3199,
if only because the register map is different.
Also:
- the software shutdown bit is reversed
- and additional field needs to be set to enable all channels
- the led-max-microamp current values and setting are not the same
Datasheets:
https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf
https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf
https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf
https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf
This series:
- converts dt-bindings to dtschema, adding all si-en compatibles
for convenience and consistency, and adding constraints on
supported values for eg. reg address and led-max-microamp
- changes vars, structs and defines to not use 319X suffix
but 3190 for 319{0,1,3} and 3196 for 319{6,9}
- adds fields in chipdef struct for chip-specific values
- only in patch 6, adds is31fl319{0,1,3} specific values
so those chips can work.
- patch 7 cleanups parts non touched in previous patches
- patches 8 to 12 are Andy's to modernize the driver
Tested on msm8916-alcatel-idol347, which probably has an
si-en,sn3190 or si-en,sn3191 (only one white led indicator).
Andy Shevchenko (5):
leds: is31fl319x: Make use of device properties
leds: is31fl319x: Make use of dev_err_probe()
leds: is31fl319x: Fix devm vs. non-devm ordering
leds: is31fl319x: use simple i2c probe function
leds: is31fl319x: sort header inclusion alphabetically
Vincent Knecht (7):
dt-bindings: leds: Convert is31fl319x to dtschema
dt-bindings: leds: is31fl319x: Document variants specificities
leds: is31fl319x: Add missing si-en compatibles
leds: is31fl319x: Use non-wildcard names for vars, structs and defines
leds: is31fl319x: Move chipset-specific values in chipdef struct
leds: is31fl319x: Add support for is31fl319{0,1,3} chips
leds: is31fl319x: Cleanup formatting and dev_dbg calls
.../bindings/leds/issi,is31fl319x.yaml | 193 +++++++
.../bindings/leds/leds-is31fl319x.txt | 61 --
drivers/leds/Kconfig | 2 +-
drivers/leds/leds-is31fl319x.c | 533 +++++++++++-------
4 files changed, 537 insertions(+), 252 deletions(-)
create mode 100644 Documentation/devicetree/bindings/leds/issi,is31fl319x.yaml
delete mode 100644 Documentation/devicetree/bindings/leds/leds-is31fl319x.txt
--
2.35.3
next reply other threads:[~2022-07-12 10:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 10:08 Vincent Knecht [this message]
2022-07-12 10:08 ` [PATCH v5 01/12] dt-bindings: leds: Convert is31fl319x to dtschema Vincent Knecht
2022-07-21 17:14 ` Rob Herring
2022-07-12 10:08 ` [PATCH v5 02/12] dt-bindings: leds: is31fl319x: Document variants specificities Vincent Knecht
2022-07-21 17:14 ` Rob Herring
2022-07-12 10:08 ` [PATCH v5 03/12] leds: is31fl319x: Add missing si-en compatibles Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 04/12] leds: is31fl319x: Use non-wildcard names for vars, structs and defines Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 05/12] leds: is31fl319x: Move chipset-specific values in chipdef struct Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 06/12] leds: is31fl319x: Add support for is31fl319{0,1,3} chips Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 07/12] leds: is31fl319x: Cleanup formatting and dev_dbg calls Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 08/12] leds: is31fl319x: Make use of device properties Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 09/12] leds: is31fl319x: Make use of dev_err_probe() Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 10/12] leds: is31fl319x: Fix devm vs. non-devm ordering Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 11/12] leds: is31fl319x: use simple i2c probe function Vincent Knecht
2022-07-12 10:08 ` [PATCH v5 12/12] leds: is31fl319x: sort header inclusion alphabetically Vincent Knecht
2022-07-31 17:21 ` [PATCH v5 00/12] leds: Fix/Add is31fl319{0,1,3} support Vincent Knecht
2022-08-02 14:44 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712100841.1538395-1-vincent.knecht@mailoo.org \
--to=vincent.knecht@mailoo.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.