From: Steven Rostedt <rostedt@goodmis.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Marco Elver <elver@google.com>,
John Ogness <john.ogness@linutronix.de>,
Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Thomas Gleixner <tglx@linutronix.de>,
Johannes Berg <johannes.berg@intel.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH -printk] printk, tracing: fix console tracepoint
Date: Tue, 12 Jul 2022 10:53:53 -0400 [thread overview]
Message-ID: <20220712105353.08358450@gandalf.local.home> (raw)
In-Reply-To: <20220712134916.GT1790663@paulmck-ThinkPad-P17-Gen-1>
On Tue, 12 Jul 2022 06:49:16 -0700
"Paul E. McKenney" <paulmck@kernel.org> wrote:
> > I guess the question is, can we have printk() in such a place? Because this
> > tracepoint is attached to printk and where ever printk is done so is this
> > tracepoint.
>
> As I understand it, code in such a place should be labeled noinstr.
> Then the call to printk() would be complained about as an illegal
> noinstr-to-non-noinstr call.
>
> But where exactly is that printk()?
Perhaps the fix is to remove the _rcuidle() from trace_console_rcuidle().
If printk() can never be called from noinstr (aka RCU not watching).
-- Steve
next prev parent reply other threads:[~2022-07-12 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 7:38 [PATCH -printk] printk, tracing: fix console tracepoint Marco Elver
2022-05-03 16:15 ` Steven Rostedt
2022-05-03 19:14 ` John Ogness
2022-05-04 9:46 ` Petr Mladek
2022-05-06 14:51 ` Petr Mladek
2022-05-06 14:55 ` Marco Elver
2022-07-11 22:29 ` Steven Rostedt
2022-07-12 0:21 ` Paul E. McKenney
2022-07-12 0:53 ` Steven Rostedt
2022-07-12 2:57 ` Paul E. McKenney
2022-07-12 11:49 ` Paul E. McKenney
2022-07-12 13:39 ` Steven Rostedt
2022-07-12 13:49 ` Paul E. McKenney
2022-07-12 14:53 ` Steven Rostedt [this message]
2022-07-12 15:16 ` Paul E. McKenney
2022-07-13 11:25 ` Petr Mladek
2022-07-13 14:05 ` Paul E. McKenney
2022-07-14 14:53 ` Petr Mladek
2022-07-14 15:17 ` Steven Rostedt
2022-07-15 9:40 ` Petr Mladek
2022-07-12 15:25 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712105353.08358450@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=johannes.berg@intel.com \
--cc=john.ogness@linutronix.de \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkft@linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=paulmck@kernel.org \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.