From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>,
John Snow <jsnow@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vladimir Sementsov-Ogievskiy <v.sementsov-og@mail.ru>,
qemu-block@nongnu.org,
Emanuele Giuseppe Esposito <eesposit@redhat.com>
Subject: [RFC PATCH 0/8] Refactor bdrv_try_set_aio_context using transactions
Date: Tue, 12 Jul 2022 17:19:03 -0400 [thread overview]
Message-ID: <20220712211911.1302836-1-eesposit@redhat.com> (raw)
The aim of this series is to reorganize bdrv_try_set_aio_context
and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in
favour of a new one, ->change_aio_ctx.
More informations in patch 3 (which is also RFC, due to the doubts
I have with AioContext locks).
Patch 1 just add assertions in the code, 2 extends the transactions API to be able to add also transactions in the tail
of the list.
Patch 3 is the core of this series, and introduces the new callback.
It is marked as RFC and the reason is explained in the commit message.
Patches 4-5-6 implement ->change_aio_ctx in the various block, blockjob
and block-backend BDSes.
Patch 7 substitutes ->change_aio_ctx with the old callbacks, and
patch 8 takes care of deleting the old callbacks and unused code.
This series is based on "job: replace AioContext lock with job_mutex",
but just because it uses job_set_aio_context() introduced there.
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Based-on: <20220706201533.289775-1-eesposit@redhat.com>
Emanuele Giuseppe Esposito (8):
block.c: assert bs->aio_context is written under BQL and drains
transactions: add tran_add_back
RFC: block: use transactions as a replacement of
->{can_}set_aio_context()
blockjob: implement .change_aio_ctx in child_job
block: implement .change_aio_ctx in child_of_bds
block-backend: implement .change_aio_ctx in child_root
block: use the new _change_ API instead of _can_set_ and _set_
block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks
block.c | 288 +++++++++++++++--------------
block/block-backend.c | 65 +++++--
blockjob.c | 50 +++--
include/block/block-global-state.h | 16 +-
include/block/block_int-common.h | 5 +-
include/qemu/transactions.h | 9 +
util/transactions.c | 29 ++-
7 files changed, 266 insertions(+), 196 deletions(-)
--
2.31.1
next reply other threads:[~2022-07-12 21:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 21:19 Emanuele Giuseppe Esposito [this message]
2022-07-12 21:19 ` [RFC PATCH 1/8] block.c: assert bs->aio_context is written under BQL and drains Emanuele Giuseppe Esposito
2022-07-14 14:03 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 2/8] transactions: add tran_add_back Emanuele Giuseppe Esposito
2022-07-14 15:13 ` Hanna Reitz
2022-07-18 16:20 ` Paolo Bonzini
2022-07-20 13:36 ` Vladimir Sementsov-Ogievskiy
2022-07-12 21:19 ` [RFC PATCH 3/8] RFC: block: use transactions as a replacement of ->{can_}set_aio_context() Emanuele Giuseppe Esposito
2022-07-14 16:45 ` Hanna Reitz
2022-07-18 8:45 ` Emanuele Giuseppe Esposito
2022-07-18 9:09 ` Emanuele Giuseppe Esposito
2022-07-20 14:09 ` Vladimir Sementsov-Ogievskiy
2022-07-25 8:35 ` Emanuele Giuseppe Esposito
2022-07-12 21:19 ` [RFC PATCH 4/8] blockjob: implement .change_aio_ctx in child_job Emanuele Giuseppe Esposito
2022-07-15 11:14 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 5/8] block: implement .change_aio_ctx in child_of_bds Emanuele Giuseppe Esposito
2022-07-15 11:17 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 6/8] block-backend: implement .change_aio_ctx in child_root Emanuele Giuseppe Esposito
2022-07-15 11:34 ` Hanna Reitz
2022-07-12 21:19 ` [RFC PATCH 7/8] block: use the new _change_ API instead of _can_set_ and _set_ Emanuele Giuseppe Esposito
2022-07-15 13:32 ` Hanna Reitz
2022-07-18 16:30 ` Paolo Bonzini
2022-07-18 16:39 ` Paolo Bonzini
2022-07-19 9:57 ` Emanuele Giuseppe Esposito
2022-07-19 18:07 ` Paolo Bonzini
2022-07-20 11:47 ` Emanuele Giuseppe Esposito
2022-07-12 21:19 ` [RFC PATCH 8/8] block: remove all unused ->can_set_aio_ctx and ->set_aio_ctx callbacks Emanuele Giuseppe Esposito
2022-07-15 14:34 ` Hanna Reitz
2022-07-18 8:45 ` Emanuele Giuseppe Esposito
2022-07-18 14:39 ` Emanuele Giuseppe Esposito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712211911.1302836-1-eesposit@redhat.com \
--to=eesposit@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=v.sementsov-og@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.