From: Xiaojuan Yang <yangxiaojuan@loongson.cn>
To: qemu-devel@nongnu.org
Cc: richard.henderson@linaro.org, gaosong@loongson.cn,
maobibo@loongson.cn, mark.cave-ayland@ilande.co.uk,
mst@redhat.com, imammedo@redhat.com, ani@anisinha.ca,
f4bug@amsat.org, peter.maydell@linaro.org
Subject: [PATCH 3/5] target/loongarch/cpu: Fix coverity errors about excp_names
Date: Wed, 13 Jul 2022 17:50:34 +0800 [thread overview]
Message-ID: <20220713095036.705102-4-yangxiaojuan@loongson.cn> (raw)
In-Reply-To: <20220713095036.705102-1-yangxiaojuan@loongson.cn>
Fix out-of-bounds errors when access excp_names[] array. the valid
boundary size of excp_names should be 0 to ARRAY_SIZE(excp_names)-1.
However, the general code do not consider the max boundary.
Fix coverity CID: 1489758
Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
---
target/loongarch/cpu.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
index ed26f9beed..89ea971cde 100644
--- a/target/loongarch/cpu.c
+++ b/target/loongarch/cpu.c
@@ -140,7 +140,7 @@ static void loongarch_cpu_do_interrupt(CPUState *cs)
if (cs->exception_index != EXCCODE_INT) {
if (cs->exception_index < 0 ||
- cs->exception_index > ARRAY_SIZE(excp_names)) {
+ cs->exception_index >= ARRAY_SIZE(excp_names)) {
name = "unknown";
} else {
name = excp_names[cs->exception_index];
@@ -190,8 +190,8 @@ static void loongarch_cpu_do_interrupt(CPUState *cs)
cause = cs->exception_index;
break;
default:
- qemu_log("Error: exception(%d) '%s' has not been supported\n",
- cs->exception_index, excp_names[cs->exception_index]);
+ qemu_log("Error: exception(%d) has not been supported\n",
+ cs->exception_index);
abort();
}
--
2.31.1
next prev parent reply other threads:[~2022-07-13 9:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 9:50 [PATCH v2 0/5] Fix LoongArch coverity error and cpu name bug Xiaojuan Yang
2022-07-13 9:50 ` [PATCH 1/5] target/loongarch/cpu: Fix cpu_class_by_name function Xiaojuan Yang
2022-07-13 16:02 ` Richard Henderson
2022-07-13 9:50 ` [PATCH 2/5] hw/intc/loongarch_pch_pic: Fix coverity errors in update irq Xiaojuan Yang
2022-07-13 16:08 ` Richard Henderson
2022-07-13 9:50 ` Xiaojuan Yang [this message]
2022-07-13 16:04 ` [PATCH 3/5] target/loongarch/cpu: Fix coverity errors about excp_names Richard Henderson
2022-07-13 9:50 ` [PATCH 4/5] target/loongarch/tlb_helper: Fix coverity integer overflow error Xiaojuan Yang
2022-07-13 16:04 ` Richard Henderson
2022-07-13 9:50 ` [PATCH 5/5] target/loongarch/op_helper: Fix coverity cond_at_most error Xiaojuan Yang
2022-07-13 16:05 ` Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2022-07-12 8:01 [PATCH v1 0/5] Fix LoongArch coverity error and cpu name bug Xiaojuan Yang
2022-07-12 8:01 ` [PATCH 3/5] target/loongarch/cpu: Fix coverity errors about excp_names Xiaojuan Yang
2022-07-12 10:13 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220713095036.705102-4-yangxiaojuan@loongson.cn \
--to=yangxiaojuan@loongson.cn \
--cc=ani@anisinha.ca \
--cc=f4bug@amsat.org \
--cc=gaosong@loongson.cn \
--cc=imammedo@redhat.com \
--cc=maobibo@loongson.cn \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.