From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3343BC43334 for ; Thu, 14 Jul 2022 09:36:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237939AbiGNJgR (ORCPT ); Thu, 14 Jul 2022 05:36:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237814AbiGNJgM (ORCPT ); Thu, 14 Jul 2022 05:36:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 970E03718E; Thu, 14 Jul 2022 02:36:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 19AF5B823DA; Thu, 14 Jul 2022 09:36:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73595C34115; Thu, 14 Jul 2022 09:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657791368; bh=6MIUuvwdVpJ4tK1rbwNOev3l1SYrBB/w4GMGLdGU6sU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLubpj75G9oFRJH1WLpBEJaKWFTpChk/WQIOVn6p+VOolGCbg405INhs9InkfmAgX 0YJVvED8VC2/6Rcm6tpLhKnPPEvyA8GAEBWJ/9fSnKl8o5FoCjXuehwB7jNhmOFvVb a9kcfiXani+hCEfiAE8Zm67PQ5rlvVhOLK7twbiUz+WWWoP5fn6def4yK0LyZqBsIu 9MqyOAfLhOBeS59D23Brrpb081+fPRu406W+0f1Wc1lHhjZDLmpM4uTyj9cgTTfzMC XPc5EoYNgBVFIloNs8yEIaQ8w/jS1YbG8J5dl2RsGAO4PAD8lvR0bSYDUVauvL8ymx Lx+Gq63UMGfqg== Received: by pali.im (Postfix) id 6763F1295; Thu, 14 Jul 2022 11:36:05 +0200 (CEST) Date: Thu, 14 Jul 2022 11:36:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Krzysztof Kozlowski Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20220714093605.wdyrcxehg2ij5lvx@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220713200336.addvyfjhakrx72am@pali> <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org> User-Agent: NeoMutt/20180716 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 14 July 2022 08:56:12 Krzysztof Kozlowski wrote: > On 13/07/2022 22:03, Pali Rohár wrote: > > On Wednesday 13 July 2022 21:42:43 Krzysztof Kozlowski wrote: > >> On 13/07/2022 14:56, Pali Rohár wrote: > >>> All Armada 3720 boards have Armada 3720 processor which is of Armada 3700 > >>> family and do not have Armada 3710 processor. So none of them should have > >>> compatible string for Armada 3710 processor. > >>> > >>> Fix compatible string for all these boards by removing wrong processor > >>> string "marvell,armada3710" and adding family string "marvell,armada3700" > >>> as the last one. (Note that this is same way how are defined Armada 3710 > >>> DTS files). > >> > >> Please do not introduce some changes just in DTS, but start from the > >> bindings. Someone wrote the bindings like that and expected to be that > >> way, so first change the bindings with proper rationale. Then change the > >> DTS files. > >> > >> > >> Best regards, > >> Krzysztof > > > > Ok, I tried to update bindings and fix example in it, see patch: > > https://lore.kernel.org/linux-devicetree/20220713200123.22612-1-pali@kernel.org/ > > The reason you used here should be expressed in that commit as well Which I exactly did (Armada 3700 = famity, Armada 3720 = SoC, Armada 3720 DB is name of the board with Armada 3720 SoC, so correctly indicate SoC in example). So what else? > because you change the ABI and affect other users (projects, systems). > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51FA7C43334 for ; Thu, 14 Jul 2022 09:37:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgTtMC8SdBKP9hUNMoczjWIcq+Q4241yXqkv0LhlhEA=; b=YOXGpERe9Ofr+d H4UXgeAZsiE9H+Udyn+Nhiwbu+eo4JT3QWKGdcbZ/zb5ipHzaS7vXNI15kP71Rb9NA6kH1xvortcI dZGPd3dD6e6uWYGoxlrHG/9hIS43aCRS1o0Eqx+GR6m9HQ2yPZK/FJDJVAbDt06OhKEs8kpejlndM rEV6XBAwuK1sPenaAhTPo7BIf+y+KrLcqwBfs16q3cFtznctuRJNZAN3uHpFjYhw0B1D+7SY5IfdO h/lQPdjcAWVGckCAOPpYukRMjeXCi9cTL6c3/Dp3Tc8LvU/RdAN9P83OrIm8uMUHim368sfS9I1cU JEoj3ulOFnU6RI/35DBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBvGa-00CvTF-Gx; Thu, 14 Jul 2022 09:36:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBvGU-00CvQH-C0 for linux-arm-kernel@lists.infradead.org; Thu, 14 Jul 2022 09:36:11 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4354A61F46; Thu, 14 Jul 2022 09:36:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73595C34115; Thu, 14 Jul 2022 09:36:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657791368; bh=6MIUuvwdVpJ4tK1rbwNOev3l1SYrBB/w4GMGLdGU6sU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rLubpj75G9oFRJH1WLpBEJaKWFTpChk/WQIOVn6p+VOolGCbg405INhs9InkfmAgX 0YJVvED8VC2/6Rcm6tpLhKnPPEvyA8GAEBWJ/9fSnKl8o5FoCjXuehwB7jNhmOFvVb a9kcfiXani+hCEfiAE8Zm67PQ5rlvVhOLK7twbiUz+WWWoP5fn6def4yK0LyZqBsIu 9MqyOAfLhOBeS59D23Brrpb081+fPRu406W+0f1Wc1lHhjZDLmpM4uTyj9cgTTfzMC XPc5EoYNgBVFIloNs8yEIaQ8w/jS1YbG8J5dl2RsGAO4PAD8lvR0bSYDUVauvL8ymx Lx+Gq63UMGfqg== Received: by pali.im (Postfix) id 6763F1295; Thu, 14 Jul 2022 11:36:05 +0200 (CEST) Date: Thu, 14 Jul 2022 11:36:05 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Krzysztof Kozlowski Cc: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards Message-ID: <20220714093605.wdyrcxehg2ij5lvx@pali> References: <20220713125644.3117-1-pali@kernel.org> <20220713200336.addvyfjhakrx72am@pali> <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a4fba17-9c71-a4e6-643a-62aa0dfd4774@linaro.org> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220714_023610_466735_A4BDECFC X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1cnNkYXkgMTQgSnVseSAyMDIyIDA4OjU2OjEyIEtyenlzenRvZiBLb3psb3dza2kgd3Jv dGU6Cj4gT24gMTMvMDcvMjAyMiAyMjowMywgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gPiBPbiBXZWRu ZXNkYXkgMTMgSnVseSAyMDIyIDIxOjQyOjQzIEtyenlzenRvZiBLb3psb3dza2kgd3JvdGU6Cj4g Pj4gT24gMTMvMDcvMjAyMiAxNDo1NiwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gPj4+IEFsbCBBcm1h ZGEgMzcyMCBib2FyZHMgaGF2ZSBBcm1hZGEgMzcyMCBwcm9jZXNzb3Igd2hpY2ggaXMgb2YgQXJt YWRhIDM3MDAKPiA+Pj4gZmFtaWx5IGFuZCBkbyBub3QgaGF2ZSBBcm1hZGEgMzcxMCBwcm9jZXNz b3IuIFNvIG5vbmUgb2YgdGhlbSBzaG91bGQgaGF2ZQo+ID4+PiBjb21wYXRpYmxlIHN0cmluZyBm b3IgQXJtYWRhIDM3MTAgcHJvY2Vzc29yLgo+ID4+Pgo+ID4+PiBGaXggY29tcGF0aWJsZSBzdHJp bmcgZm9yIGFsbCB0aGVzZSBib2FyZHMgYnkgcmVtb3Zpbmcgd3JvbmcgcHJvY2Vzc29yCj4gPj4+ IHN0cmluZyAibWFydmVsbCxhcm1hZGEzNzEwIiBhbmQgYWRkaW5nIGZhbWlseSBzdHJpbmcgIm1h cnZlbGwsYXJtYWRhMzcwMCIKPiA+Pj4gYXMgdGhlIGxhc3Qgb25lLiAoTm90ZSB0aGF0IHRoaXMg aXMgc2FtZSB3YXkgaG93IGFyZSBkZWZpbmVkIEFybWFkYSAzNzEwCj4gPj4+IERUUyBmaWxlcyku Cj4gPj4KPiA+PiBQbGVhc2UgZG8gbm90IGludHJvZHVjZSBzb21lIGNoYW5nZXMganVzdCBpbiBE VFMsIGJ1dCBzdGFydCBmcm9tIHRoZQo+ID4+IGJpbmRpbmdzLiBTb21lb25lIHdyb3RlIHRoZSBi aW5kaW5ncyBsaWtlIHRoYXQgYW5kIGV4cGVjdGVkIHRvIGJlIHRoYXQKPiA+PiB3YXksIHNvIGZp cnN0IGNoYW5nZSB0aGUgYmluZGluZ3Mgd2l0aCBwcm9wZXIgcmF0aW9uYWxlLiBUaGVuIGNoYW5n ZSB0aGUKPiA+PiBEVFMgZmlsZXMuCj4gPj4KPiA+Pgo+ID4+IEJlc3QgcmVnYXJkcywKPiA+PiBL cnp5c3p0b2YKPiA+IAo+ID4gT2ssIEkgdHJpZWQgdG8gdXBkYXRlIGJpbmRpbmdzIGFuZCBmaXgg ZXhhbXBsZSBpbiBpdCwgc2VlIHBhdGNoOgo+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGlu dXgtZGV2aWNldHJlZS8yMDIyMDcxMzIwMDEyMy4yMjYxMi0xLXBhbGlAa2VybmVsLm9yZy8KPiAK PiBUaGUgcmVhc29uIHlvdSB1c2VkIGhlcmUgc2hvdWxkIGJlIGV4cHJlc3NlZCBpbiB0aGF0IGNv bW1pdCBhcyB3ZWxsCgpXaGljaCBJIGV4YWN0bHkgZGlkIChBcm1hZGEgMzcwMCA9IGZhbWl0eSwg QXJtYWRhIDM3MjAgPSBTb0MsIEFybWFkYQozNzIwIERCIGlzIG5hbWUgb2YgdGhlIGJvYXJkIHdp dGggQXJtYWRhIDM3MjAgU29DLCBzbyBjb3JyZWN0bHkgaW5kaWNhdGUKU29DIGluIGV4YW1wbGUp LiBTbyB3aGF0IGVsc2U/Cgo+IGJlY2F1c2UgeW91IGNoYW5nZSB0aGUgQUJJIGFuZCBhZmZlY3Qg b3RoZXIgdXNlcnMgKHByb2plY3RzLCBzeXN0ZW1zKS4KPiAKPiBCZXN0IHJlZ2FyZHMsCj4gS3J6 eXN6dG9mCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==