All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: naresh.solanki@9elements.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] regulator: output-supply DT support
Date: Thu, 14 Jul 2022 08:17:12 -0600	[thread overview]
Message-ID: <20220714141712.GC2229197-robh@kernel.org> (raw)
In-Reply-To: <165756666221.1166849.17586001373716391631.b4-ty@kernel.org>

On Mon, Jul 11, 2022 at 08:11:02PM +0100, Mark Brown wrote:
> On Thu, 7 Jul 2022 10:18:22 +0200, Naresh Solanki wrote:
> > v4:
> >  - Add 9elements as vendor.
> >  - Update dt binding.
> > 
> > Add devicetree support of the output-supply driver.
> > The supply names for this driver is provided through DT
> > regulator-names & regulator handle can be acquired.
> > Driver events can be received from sysfs.
> > 
> > [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
> 
> Thanks!
> 
> [1/4] dt-bindings: vendor-prefixes: add 9elements
>       commit: bd9b7998b4816b3d604253a774d83b6736474283
> [2/4] dt-bindings: regulator: add bindings for output-supply
>       commit: df9c96b69a1d2629519a5d8a9dc4b39f775ebe2d
> [3/4] regulator: output-supply: Add devicetree support
>       commit: 34e5700e1e64077ede50eb60d04e7604dc4f508a
> [4/4] regulator: output-supply: Add Notification support
>       commit: 490a15324ce6d55b950fce0eb9e95c793fac0dff

Please revert this. The vendor prefix is not even appropriate here and 
the binding has lots of issues. The first being whether it should even 
be in DT. It's not been reviewed as none of it has gone to the DT list 
and the only thing I got was '[PATCH v4 1/4] dt-bindings: 
vendor-prefixes: add 9elements'.

Rob

  reply	other threads:[~2022-07-14 14:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-07  8:18 [PATCH v4 0/4] regulator: output-supply DT support Naresh Solanki
2022-07-07  8:18 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: add 9elements Naresh Solanki
2022-07-11 22:19   ` Rob Herring
2022-07-07  8:18 ` [PATCH v4 2/4] dt-bindings: regulator: add bindings for output-supply Naresh Solanki
2022-07-08 18:33   ` Mark Brown
2022-07-14 14:02   ` Rob Herring
2022-07-14 14:10   ` Rob Herring
2022-07-14 14:14     ` Mark Brown
2022-07-14 14:23       ` Rob Herring
2022-07-14 14:42         ` Mark Brown
2022-07-14 15:07           ` Rob Herring
2022-07-14 15:54             ` Mark Brown
2022-07-14 16:59               ` Rob Herring
2022-07-14 17:50                 ` Mark Brown
2022-07-21  8:33                 ` Zev Weiss
2022-07-21 11:05                   ` Mark Brown
2022-07-07  8:18 ` [PATCH v4 3/4] regulator: output-supply: Add devicetree support Naresh Solanki
2022-07-07  8:18 ` [PATCH v4 4/4] regulator: output-supply: Add Notification support Naresh Solanki
2022-07-11 19:11 ` [PATCH v4 0/4] regulator: output-supply DT support Mark Brown
2022-07-14 14:17   ` Rob Herring [this message]
2022-07-14 18:24     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220714141712.GC2229197-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naresh.solanki@9elements.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.