[PATCH v5 1/8] hw/i2c: Clear ACK bit in NPCM7xx SMBus module

From: Hao Wu <wuhaotsh@google.com>
To: peter.maydell@linaro.org
Cc: richard.henderson@linaro.org, qemu-arm@nongnu.org,
	qemu-devel@nongnu.org,  wuhaotsh@google.com, venture@google.com,
	Avi.Fishman@nuvoton.com,  kfting@nuvoton.com,
	hskinnemoen@google.com, f4bug@amsat.org,  bin.meng@windriver.com,
	qemu-block@nongnu.org, armbru@redhat.com,  thuth@redhat.com,
	Titus Rwantare <titusr@google.com>
Subject: [PATCH v5 1/8] hw/i2c: Clear ACK bit in NPCM7xx SMBus module
Date: Thu, 14 Jul 2022 11:28:29 -0700	[thread overview]
Message-ID: <20220714182836.89602-2-wuhaotsh@google.com> (raw)
In-Reply-To: <20220714182836.89602-1-wuhaotsh@google.com>

The ACK bit in NPCM7XX SMBus module should be cleared each time it
sends out a NACK signal. This patch fixes the bug that it fails to
do so.

Signed-off-by: Hao Wu <wuhaotsh@google.com>
Reviewed-by: Titus Rwantare <titusr@google.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
 hw/i2c/npcm7xx_smbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
index e7e0ba66fe..f18e311556 100644
--- a/hw/i2c/npcm7xx_smbus.c
+++ b/hw/i2c/npcm7xx_smbus.c
@@ -270,7 +270,7 @@ static void npcm7xx_smbus_recv_byte(NPCM7xxSMBusState *s)
     if (s->st & NPCM7XX_SMBCTL1_ACK) {
         trace_npcm7xx_smbus_nack(DEVICE(s)->canonical_path);
         i2c_nack(s->bus);
-        s->st &= NPCM7XX_SMBCTL1_ACK;
+        s->st &= ~NPCM7XX_SMBCTL1_ACK;
     }
     trace_npcm7xx_smbus_recv_byte((DEVICE(s)->canonical_path), s->sda);
     npcm7xx_smbus_update_irq(s);
-- 
2.37.0.170.g444d1eabd0-goog


