From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B804ACCA479 for ; Sat, 16 Jul 2022 14:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiGPOkr (ORCPT ); Sat, 16 Jul 2022 10:40:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbiGPOkq (ORCPT ); Sat, 16 Jul 2022 10:40:46 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4357175B2 for ; Sat, 16 Jul 2022 07:40:45 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCiy9-0001mp-Lg; Sat, 16 Jul 2022 16:40:33 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCiy7-001Kfv-TI; Sat, 16 Jul 2022 16:40:31 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCiy6-005ZA4-Rm; Sat, 16 Jul 2022 16:40:30 +0200 Date: Sat, 16 Jul 2022 16:40:28 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?B?QmVow7pu?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios Message-ID: <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> References: <20220714115515.5748-1-pali@kernel.org> <20220714183328.4137-1-pali@kernel.org> <20220714183328.4137-3-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zalewdgjudxxklrt" Content-Disposition: inline In-Reply-To: <20220714183328.4137-3-pali@kernel.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --zalewdgjudxxklrt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Roh=E1r wrote: > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre-XP > variants like Armada 370 do not support per CPU interrupts for gpios. >=20 > So change compatible string for Armada 38x from "marvell,armada-370-gpio" > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indicates > XP variant or new. >=20 > Driver gpio-mvebu.c which handles both pre-XP and XP variants already > provides support for per CPU interrupts on XP and newer variants. >=20 > Signed-off-by: Pali Roh=E1r > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-38x") > --- > arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada= -38x.dtsi > index df3c8d1d8f64..9343de6947b3 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -292,7 +292,7 @@ > }; > =20 > gpio0: gpio@18100 { > - compatible =3D "marvell,armada-370-gpio", > + compatible =3D "marvell,armadaxp-gpio", > "marvell,orion-gpio"; If you can treat the XP variant as 370 and everything that is supposed to work on 370 works then, then maybe the right incarnation is: compatible =3D "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "marvel= l,orion-gpio"; ? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --zalewdgjudxxklrt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLSzdkACgkQwfwUeK3K 7Akz2wf+JF6UmqztBz7omhK1mGfW33SmnWY7c88XTanbchqiMR/xEQSaimY4mLAo zad+Y0rz8FY7GhVlnp76zFnGkXKKBDy6PR/RUw4BA0PJPYi1UkYPXINES3PW5Hzj P1/i9jC6IGdcWTkwIl+wLWTXcLm4XaJuJEq63zDtPDEifeYIKpF7dcmh7py2Jd3l 7V71pUvjMLBBGLHpHCMtn3EOfAjpHczxS6krmkadFLbG9YjDKH2t4Fdzn5n1HOUc ofA4Ei4OVgRiQ+pN0YdxEFxeJeW1ipk1DiFHZwhOUQWQV+LuWKHksHGme+w9xX6y C1ZEwTuTRFizN2nkb+imT79hdtgg2g== =XF96 -----END PGP SIGNATURE----- --zalewdgjudxxklrt-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47653C43334 for ; Sat, 16 Jul 2022 14:42:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m40sHUEQKXTXvXruq9WvZH0HDdO8r8w1dbsGlTppqoI=; b=wdx8XGl/L+6Y+9hEXa+PaRPuK4 8U7tGYR4dDLMupOX978iJWxHE2Xv/jtUIo7T3jYBCkGOlo2hBRhqlLNHBJZQRqF7X8276G9LlN2lw ikuN8uLAqXb/9M7ngg3xq7ZsdGnqFvgaPXxaOP6KQhMJkrjLvPEP2Ubqmn+e1C3rrycxN6YAztomH 6uS7ZxEDUQI1iUv1MansLntp/6VDrvuqmi/0lVejltmd8CurRE51T9EPTaja+G7V64Yp9LSq2MU4s gpgN7UISRhlcYLBLdfj1VaaCY14wuc22VQ86CWZTbVWtXSvWM3TJWpYBmTel4UTQgegdp7mdvLBry yqMfbn/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCiyd-00GZPn-Cs; Sat, 16 Jul 2022 14:41:03 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCiyY-00GZGj-6t for linux-arm-kernel@lists.infradead.org; Sat, 16 Jul 2022 14:41:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCiy9-0001mp-Lg; Sat, 16 Jul 2022 16:40:33 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCiy7-001Kfv-TI; Sat, 16 Jul 2022 16:40:31 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCiy6-005ZA4-Rm; Sat, 16 Jul 2022 16:40:30 +0200 Date: Sat, 16 Jul 2022 16:40:28 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?B?QmVow7pu?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios Message-ID: <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> References: <20220714115515.5748-1-pali@kernel.org> <20220714183328.4137-1-pali@kernel.org> <20220714183328.4137-3-pali@kernel.org> MIME-Version: 1.0 In-Reply-To: <20220714183328.4137-3-pali@kernel.org> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220716_074058_290722_8DC8A49C X-CRM114-Status: GOOD ( 22.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============4525495646674887173==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4525495646674887173== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zalewdgjudxxklrt" Content-Disposition: inline --zalewdgjudxxklrt Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Roh=E1r wrote: > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre-XP > variants like Armada 370 do not support per CPU interrupts for gpios. >=20 > So change compatible string for Armada 38x from "marvell,armada-370-gpio" > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indicates > XP variant or new. >=20 > Driver gpio-mvebu.c which handles both pre-XP and XP variants already > provides support for per CPU interrupts on XP and newer variants. >=20 > Signed-off-by: Pali Roh=E1r > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-38x") > --- > arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada= -38x.dtsi > index df3c8d1d8f64..9343de6947b3 100644 > --- a/arch/arm/boot/dts/armada-38x.dtsi > +++ b/arch/arm/boot/dts/armada-38x.dtsi > @@ -292,7 +292,7 @@ > }; > =20 > gpio0: gpio@18100 { > - compatible =3D "marvell,armada-370-gpio", > + compatible =3D "marvell,armadaxp-gpio", > "marvell,orion-gpio"; If you can treat the XP variant as 370 and everything that is supposed to work on 370 works then, then maybe the right incarnation is: compatible =3D "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "marvel= l,orion-gpio"; ? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --zalewdgjudxxklrt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLSzdkACgkQwfwUeK3K 7Akz2wf+JF6UmqztBz7omhK1mGfW33SmnWY7c88XTanbchqiMR/xEQSaimY4mLAo zad+Y0rz8FY7GhVlnp76zFnGkXKKBDy6PR/RUw4BA0PJPYi1UkYPXINES3PW5Hzj P1/i9jC6IGdcWTkwIl+wLWTXcLm4XaJuJEq63zDtPDEifeYIKpF7dcmh7py2Jd3l 7V71pUvjMLBBGLHpHCMtn3EOfAjpHczxS6krmkadFLbG9YjDKH2t4Fdzn5n1HOUc ofA4Ei4OVgRiQ+pN0YdxEFxeJeW1ipk1DiFHZwhOUQWQV+LuWKHksHGme+w9xX6y C1ZEwTuTRFizN2nkb+imT79hdtgg2g== =XF96 -----END PGP SIGNATURE----- --zalewdgjudxxklrt-- --===============4525495646674887173== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4525495646674887173==--