From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B78EC433EF for ; Sat, 16 Jul 2022 15:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230140AbiGPPII (ORCPT ); Sat, 16 Jul 2022 11:08:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbiGPPII (ORCPT ); Sat, 16 Jul 2022 11:08:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3431A1B7B3 for ; Sat, 16 Jul 2022 08:08:07 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCjOe-0004aH-Ee; Sat, 16 Jul 2022 17:07:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCjOc-001L74-Od; Sat, 16 Jul 2022 17:07:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCjOc-005ZED-4N; Sat, 16 Jul 2022 17:07:54 +0200 Date: Sat, 16 Jul 2022 17:07:51 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?B?QmVow7pu?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios Message-ID: <20220716150751.6yaknmo3qwusyy5h@pengutronix.de> References: <20220714115515.5748-1-pali@kernel.org> <20220714183328.4137-1-pali@kernel.org> <20220714183328.4137-3-pali@kernel.org> <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> <20220716145019.nps3oh4a22fsuzup@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mbmakiw7qwh6ws4a" Content-Disposition: inline In-Reply-To: <20220716145019.nps3oh4a22fsuzup@pali> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org --mbmakiw7qwh6ws4a Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 16, 2022 at 04:50:19PM +0200, Pali Roh=E1r wrote: > On Saturday 16 July 2022 16:40:28 Uwe Kleine-K=F6nig wrote: > > On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Roh=E1r wrote: > > > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre= -XP > > > variants like Armada 370 do not support per CPU interrupts for gpios. > > >=20 > > > So change compatible string for Armada 38x from "marvell,armada-370-g= pio" > > > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indic= ates > > > XP variant or new. > > >=20 > > > Driver gpio-mvebu.c which handles both pre-XP and XP variants already > > > provides support for per CPU interrupts on XP and newer variants. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-= 38x") > > > --- > > > arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/ar= mada-38x.dtsi > > > index df3c8d1d8f64..9343de6947b3 100644 > > > --- a/arch/arm/boot/dts/armada-38x.dtsi > > > +++ b/arch/arm/boot/dts/armada-38x.dtsi > > > @@ -292,7 +292,7 @@ > > > }; > > > =20 > > > gpio0: gpio@18100 { > > > - compatible =3D "marvell,armada-370-gpio", > > > + compatible =3D "marvell,armadaxp-gpio", > > > "marvell,orion-gpio"; > >=20 > > If you can treat the XP variant as 370 and everything that is supposed > > to work on 370 works then, then maybe the right incarnation is: > >=20 > > compatible =3D "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "ma= rvell,orion-gpio"; > >=20 > > ? >=20 > For pre-XP variants is "marvell,orion-gpio" enough and for XP + post-XP > is needed "marvell,armadaxp-gpio" (with possible "marvell,orion-gpio" > for backward compatibility). >=20 > So I do not see reason why to add "marvell,armada-370-gpio" nor what > value it brings. If you boot an older kernel (i.e. one that doesn't support marvell,armadaxp-gpio, but does support marvell,armada-370-gpio), it will work better as there are relevant differences between marvell,orion-gpio and marvell,armada-370-gpio. For example some registers seem to have a different offset ... Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --mbmakiw7qwh6ws4a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLS1EMACgkQwfwUeK3K 7AkxzQf+JnWj+P369JeEqvihi0Qj5V7qPoBnMdsxxJcFW/lDUKlNfHlvbYTaiKPP 65Wkco8ncalzS1rFIfTXD9Kg4oc7CUft8x4OvgFug7GMkPnvdzYMzC1ey1rJBvUJ 8dPt8BcscOAaE3NegqnDwVw44Yg7/qHFaFpxkmvPGCFAY1g/c6cZGJd6CDOrT0Q6 czIEy2FpqhdcDJZ8yMHjqp5dImcZn277LMIY5dqziupIBVKFIh0YuV7MdksXu/XP rjqP/FSKB71ZOX/lPTyzKa69FyV5P/+2f15LptLxLoM3qLbpfI+tXTd21uEZgw3f IerhFelatP+M9dKpMSMFaMk8N/cQcg== =UqHw -----END PGP SIGNATURE----- --mbmakiw7qwh6ws4a-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA9D8C43334 for ; Sat, 16 Jul 2022 15:09:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QM9S4nSdAZd/N0A1IrbWmo2JEdQvGSqlN1fOU0ZM0B0=; b=GzWU7Nw7VU8XxLWbjxbfEjoArZ OHUKHu0D2/2axw1b7umYCJ1gPO1sc1oLCVMP/y9MZZv3k979a0ATRQMK+FVukhyI5wmcN1EYrj8HQ LzVwj8AHVV7Wu4sJbEP9AuGgtJOQ8AOMmqK709xyls5tZytalrvqtmK+ZVb22I8q+Bok/zId6v7Qm swxKReL0tioDd9kK3ubmw/NZJQi31+n6OVvL4qCeYzHjSXA1yNzO8E7X18BETCi4p3YK7PfHVkgu7 rRG4gHrXBcQ67H1bi5oVLqX+oxm3nky3cR2ACcTvKrEOgBSgxmuIWHSLsNMHFnkVyKyKwNynThfod DJqqf59Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCjOu-00GjYt-Su; Sat, 16 Jul 2022 15:08:13 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oCjOr-00GjWg-O8 for linux-arm-kernel@lists.infradead.org; Sat, 16 Jul 2022 15:08:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oCjOe-0004aH-Ee; Sat, 16 Jul 2022 17:07:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oCjOc-001L74-Od; Sat, 16 Jul 2022 17:07:54 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oCjOc-005ZED-4N; Sat, 16 Jul 2022 17:07:54 +0200 Date: Sat, 16 Jul 2022 17:07:51 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Pali =?utf-8?B?Um9ow6Fy?= Cc: Thierry Reding , Lee Jones , Linus Walleij , Bartosz Golaszewski , Rob Herring , Krzysztof Kozlowski , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Marek =?utf-8?B?QmVow7pu?= , linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/4] ARM: dts: armada-38x: Fix compatible string for gpios Message-ID: <20220716150751.6yaknmo3qwusyy5h@pengutronix.de> References: <20220714115515.5748-1-pali@kernel.org> <20220714183328.4137-1-pali@kernel.org> <20220714183328.4137-3-pali@kernel.org> <20220716144028.rzwcn4wl5uyxepjd@pengutronix.de> <20220716145019.nps3oh4a22fsuzup@pali> MIME-Version: 1.0 In-Reply-To: <20220716145019.nps3oh4a22fsuzup@pali> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220716_080809_807406_7E0473EE X-CRM114-Status: GOOD ( 29.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0808560932634994537==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0808560932634994537== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mbmakiw7qwh6ws4a" Content-Disposition: inline --mbmakiw7qwh6ws4a Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 16, 2022 at 04:50:19PM +0200, Pali Roh=E1r wrote: > On Saturday 16 July 2022 16:40:28 Uwe Kleine-K=F6nig wrote: > > On Thu, Jul 14, 2022 at 08:33:27PM +0200, Pali Roh=E1r wrote: > > > Armada 38x supports per CPU interrupts for gpios, like Armada XP. Pre= -XP > > > variants like Armada 370 do not support per CPU interrupts for gpios. > > >=20 > > > So change compatible string for Armada 38x from "marvell,armada-370-g= pio" > > > which indicates pre-XP variant to "marvell,armadaxp-gpio" which indic= ates > > > XP variant or new. > > >=20 > > > Driver gpio-mvebu.c which handles both pre-XP and XP variants already > > > provides support for per CPU interrupts on XP and newer variants. > > >=20 > > > Signed-off-by: Pali Roh=E1r > > > Fixes: 7cb2acb3fbae ("ARM: dts: mvebu: Add PWM properties for armada-= 38x") > > > --- > > > arch/arm/boot/dts/armada-38x.dtsi | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/ar= mada-38x.dtsi > > > index df3c8d1d8f64..9343de6947b3 100644 > > > --- a/arch/arm/boot/dts/armada-38x.dtsi > > > +++ b/arch/arm/boot/dts/armada-38x.dtsi > > > @@ -292,7 +292,7 @@ > > > }; > > > =20 > > > gpio0: gpio@18100 { > > > - compatible =3D "marvell,armada-370-gpio", > > > + compatible =3D "marvell,armadaxp-gpio", > > > "marvell,orion-gpio"; > >=20 > > If you can treat the XP variant as 370 and everything that is supposed > > to work on 370 works then, then maybe the right incarnation is: > >=20 > > compatible =3D "marvell,armadaxp-gpio", "marvell,armada-370-gpio", "ma= rvell,orion-gpio"; > >=20 > > ? >=20 > For pre-XP variants is "marvell,orion-gpio" enough and for XP + post-XP > is needed "marvell,armadaxp-gpio" (with possible "marvell,orion-gpio" > for backward compatibility). >=20 > So I do not see reason why to add "marvell,armada-370-gpio" nor what > value it brings. If you boot an older kernel (i.e. one that doesn't support marvell,armadaxp-gpio, but does support marvell,armada-370-gpio), it will work better as there are relevant differences between marvell,orion-gpio and marvell,armada-370-gpio. For example some registers seem to have a different offset ... Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --mbmakiw7qwh6ws4a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmLS1EMACgkQwfwUeK3K 7AkxzQf+JnWj+P369JeEqvihi0Qj5V7qPoBnMdsxxJcFW/lDUKlNfHlvbYTaiKPP 65Wkco8ncalzS1rFIfTXD9Kg4oc7CUft8x4OvgFug7GMkPnvdzYMzC1ey1rJBvUJ 8dPt8BcscOAaE3NegqnDwVw44Yg7/qHFaFpxkmvPGCFAY1g/c6cZGJd6CDOrT0Q6 czIEy2FpqhdcDJZ8yMHjqp5dImcZn277LMIY5dqziupIBVKFIh0YuV7MdksXu/XP rjqP/FSKB71ZOX/lPTyzKa69FyV5P/+2f15LptLxLoM3qLbpfI+tXTd21uEZgw3f IerhFelatP+M9dKpMSMFaMk8N/cQcg== =UqHw -----END PGP SIGNATURE----- --mbmakiw7qwh6ws4a-- --===============0808560932634994537== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0808560932634994537==--