All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v2 25/28] cxl/hdm: Commit decoder state to hardware
Date: Sun, 17 Jul 2022 05:58:22 +0800	[thread overview]
Message-ID: <202207170530.EyDKrQwG-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2457 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
In-Reply-To: <165784338418.1758207.14659830845389904356.stgit@dwillia2-xfh.jf.intel.com>
References: <165784338418.1758207.14659830845389904356.stgit@dwillia2-xfh.jf.intel.com>
TO: Dan Williams <dan.j.williams@intel.com>

Hi Dan,

I love your patch! Perhaps something to improve:

[auto build test WARNING on b060edfd8cdd52bc8648392500bf152a8dd6d4c5]

url:    https://github.com/intel-lab-lkp/linux/commits/Dan-Williams/CXL-PMEM-Region-Provisioning/20220715-080748
base:   b060edfd8cdd52bc8648392500bf152a8dd6d4c5
:::::: branch date: 2 days ago
:::::: commit date: 2 days ago
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220717/202207170530.EyDKrQwG-lkp(a)intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
drivers/cxl/core/hdm.c:475 cxld_set_interleave() error: uninitialized symbol 'eig'.
drivers/cxl/core/hdm.c:476 cxld_set_interleave() error: uninitialized symbol 'eiw'.

Old smatch warnings:
drivers/cxl/core/hdm.c:344 cxl_dpa_free() error: uninitialized symbol 'rc'.
drivers/cxl/core/hdm.c:461 cxl_dpa_alloc() error: uninitialized symbol 'rc'.

vim +/eig +475 drivers/cxl/core/hdm.c

5ccc075e8e0da0 Dan Williams 2022-07-14  466  
4eeba6d677001b Dan Williams 2022-07-14  467  static void cxld_set_interleave(struct cxl_decoder *cxld, u32 *ctrl)
4eeba6d677001b Dan Williams 2022-07-14  468  {
4eeba6d677001b Dan Williams 2022-07-14  469  	u16 eig;
4eeba6d677001b Dan Williams 2022-07-14  470  	u8 eiw;
4eeba6d677001b Dan Williams 2022-07-14  471  
4eeba6d677001b Dan Williams 2022-07-14  472  	ways_to_cxl(cxld->interleave_ways, &eiw);
4eeba6d677001b Dan Williams 2022-07-14  473  	granularity_to_cxl(cxld->interleave_granularity, &eig);
4eeba6d677001b Dan Williams 2022-07-14  474  
4eeba6d677001b Dan Williams 2022-07-14 @475  	u32p_replace_bits(ctrl, eig, CXL_HDM_DECODER0_CTRL_IG_MASK);
4eeba6d677001b Dan Williams 2022-07-14 @476  	u32p_replace_bits(ctrl, eiw, CXL_HDM_DECODER0_CTRL_IW_MASK);
4eeba6d677001b Dan Williams 2022-07-14  477  	*ctrl |= CXL_HDM_DECODER0_CTRL_COMMIT;
4eeba6d677001b Dan Williams 2022-07-14  478  }
4eeba6d677001b Dan Williams 2022-07-14  479  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-07-16 21:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-16 21:58 kernel test robot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-07-15  0:00 [PATCH v2 00/28] CXL PMEM Region Provisioning Dan Williams
2022-07-15  0:03 ` [PATCH v2 25/28] cxl/hdm: Commit decoder state to hardware Dan Williams
2022-07-20 17:44   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202207170530.EyDKrQwG-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.