* [PATCH] nvme-pci: remove useless assignment in nvme_pci_setup_prps
@ 2022-07-16 11:49 Liu Song
2022-07-18 4:59 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Liu Song @ 2022-07-16 11:49 UTC (permalink / raw)
To: kbusch, axboe, hch, sagi; +Cc: linux-nvme, linux-kernel
From: Liu Song <liusong@linux.alibaba.com>
If prp_list is NULL, nvme_unmap_sg will be performed, and the assignment
to first_dma is meaningless, so remove it.
Signed-off-by: Liu Song <liusong@linux.alibaba.com>
---
drivers/nvme/host/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 193b447..3872e33 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -670,7 +670,6 @@ static blk_status_t nvme_pci_setup_prps(struct nvme_dev *dev,
prp_list = dma_pool_alloc(pool, GFP_ATOMIC, &prp_dma);
if (!prp_list) {
- iod->first_dma = dma_addr;
iod->npages = -1;
return BLK_STS_RESOURCE;
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nvme-pci: remove useless assignment in nvme_pci_setup_prps
2022-07-16 11:49 [PATCH] nvme-pci: remove useless assignment in nvme_pci_setup_prps Liu Song
@ 2022-07-18 4:59 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2022-07-18 4:59 UTC (permalink / raw)
To: Liu Song; +Cc: kbusch, axboe, hch, sagi, linux-nvme, linux-kernel
Thanks,
applied to nvme-5.20.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 4:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-16 11:49 [PATCH] nvme-pci: remove useless assignment in nvme_pci_setup_prps Liu Song
2022-07-18 4:59 ` Christoph Hellwig
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.