All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tzung-Bi Shih <tzungbi@kernel.org>
To: bleung@chromium.org, groeck@chromium.org
Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2 07/10] platform/chrome: cros_ec_proto: change Kunit expectation when timed out
Date: Mon, 18 Jul 2022 05:09:11 +0000	[thread overview]
Message-ID: <20220718050914.2267370-8-tzungbi@kernel.org> (raw)
In-Reply-To: <20220718050914.2267370-1-tzungbi@kernel.org>

While EC_COMMS_STATUS_PROCESSING flag is still on after it tries
EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS,
cros_ec_wait_until_complete() doesn't return an error code.

Change the expectation to an error code.

Reviewed-by: Guenter Roeck <groeck@chromium.org>
Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
---
Changes from v1:
- Add R-b tag.

 drivers/platform/chrome/cros_ec_proto_test.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c
index 64100fd81c6a..fbb872040711 100644
--- a/drivers/platform/chrome/cros_ec_proto_test.c
+++ b/drivers/platform/chrome/cros_ec_proto_test.c
@@ -1870,9 +1870,7 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_retries_status_processing(st
 	}
 
 	ret = cros_ec_cmd_xfer(ec_dev, &msg);
-	KUNIT_EXPECT_EQ(test, ret, sizeof(struct ec_response_get_comms_status));
-
-	KUNIT_EXPECT_EQ(test, msg.result, EC_RES_SUCCESS);
+	KUNIT_EXPECT_EQ(test, ret, -EAGAIN);
 
 	/* For EC_CMD_GET_COMMS_STATUS EC_COMMAND_RETRIES times. */
 	KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 51);
-- 
2.37.0.170.g444d1eabd0-goog


  parent reply	other threads:[~2022-07-18  5:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-18  5:09 [PATCH v2 00/10] platform/chrome: Kunit tests and refactor for cros_ec_cmd_xfer() Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 01/10] platform/chrome: cros_kunit_util: add default value for `msg->result` Tzung-Bi Shih
2022-07-18 13:35   ` Guenter Roeck
2022-07-19  4:00     ` Tzung-Bi Shih
2022-07-19 21:27       ` Guenter Roeck
2022-07-20  1:00         ` Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 02/10] platform/chrome: cros_ec_proto: add "cros_ec_" prefix to send_command() Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 03/10] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_cmd_xfer() Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 04/10] platform/chrome: cros_ec_proto: add Kunit tests for cros_ec_send_command() Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 05/10] platform/chrome: cros_ec_proto: separate cros_ec_xfer_command() Tzung-Bi Shih
2022-07-18  5:09 ` [PATCH v2 06/10] platform/chrome: cros_ec_proto: separate cros_ec_wait_until_complete() Tzung-Bi Shih
2022-07-18 13:32   ` Guenter Roeck
2022-07-18  5:09 ` Tzung-Bi Shih [this message]
2022-07-18  5:09 ` [PATCH v2 08/10] platform/chrome: cros_ec_proto: return -EAGAIN when retries timed out Tzung-Bi Shih
2022-07-18 13:33   ` Guenter Roeck
2022-07-18  5:09 ` [PATCH v2 09/10] platform/chrome: cros_ec_proto: add Kunit test for empty payload Tzung-Bi Shih
2022-07-18 13:36   ` Guenter Roeck
2022-07-18  5:09 ` [PATCH v2 10/10] platform/chrome: cros_ec_proto: return -EPROTO if " Tzung-Bi Shih
2022-07-20  1:30 ` [PATCH v2 00/10] platform/chrome: Kunit tests and refactor for cros_ec_cmd_xfer() patchwork-bot+chrome-platform
2022-07-21  8:50 ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220718050914.2267370-8-tzungbi@kernel.org \
    --to=tzungbi@kernel.org \
    --cc=bleung@chromium.org \
    --cc=chrome-platform@lists.linux.dev \
    --cc=groeck@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.